diff options
| author | Thomas Meyer <thomas@m3y3r.de> | 2017-10-09 14:38:54 -0400 |
|---|---|---|
| committer | Darrick J. Wong <darrick.wong@oracle.com> | 2017-10-11 13:21:06 -0400 |
| commit | 749f24f33e87c1706d716c283027595b72a034f3 (patch) | |
| tree | f8c46c500374a87f6e78e4eb292d630c485e158a /fs/xfs | |
| parent | 67f2ffe31d1a683170c2ba0ecc643e42a5fdd397 (diff) | |
xfs: Fix bool initialization/comparison
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs')
| -rw-r--r-- | fs/xfs/libxfs/xfs_bmap.c | 4 | ||||
| -rw-r--r-- | fs/xfs/libxfs/xfs_ialloc.c | 4 | ||||
| -rw-r--r-- | fs/xfs/xfs_file.c | 4 | ||||
| -rw-r--r-- | fs/xfs/xfs_log.c | 2 | ||||
| -rw-r--r-- | fs/xfs/xfs_mount.c | 2 |
5 files changed, 8 insertions, 8 deletions
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c index 044a363119be..def32fa1c225 100644 --- a/fs/xfs/libxfs/xfs_bmap.c +++ b/fs/xfs/libxfs/xfs_bmap.c | |||
| @@ -1477,14 +1477,14 @@ xfs_bmap_isaeof( | |||
| 1477 | int is_empty; | 1477 | int is_empty; |
| 1478 | int error; | 1478 | int error; |
| 1479 | 1479 | ||
| 1480 | bma->aeof = 0; | 1480 | bma->aeof = false; |
| 1481 | error = xfs_bmap_last_extent(NULL, bma->ip, whichfork, &rec, | 1481 | error = xfs_bmap_last_extent(NULL, bma->ip, whichfork, &rec, |
| 1482 | &is_empty); | 1482 | &is_empty); |
| 1483 | if (error) | 1483 | if (error) |
| 1484 | return error; | 1484 | return error; |
| 1485 | 1485 | ||
| 1486 | if (is_empty) { | 1486 | if (is_empty) { |
| 1487 | bma->aeof = 1; | 1487 | bma->aeof = true; |
| 1488 | return 0; | 1488 | return 0; |
| 1489 | } | 1489 | } |
| 1490 | 1490 | ||
diff --git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c index 988bb3f31446..dfd643909f85 100644 --- a/fs/xfs/libxfs/xfs_ialloc.c +++ b/fs/xfs/libxfs/xfs_ialloc.c | |||
| @@ -1962,7 +1962,7 @@ xfs_difree_inobt( | |||
| 1962 | if (!(mp->m_flags & XFS_MOUNT_IKEEP) && | 1962 | if (!(mp->m_flags & XFS_MOUNT_IKEEP) && |
| 1963 | rec.ir_free == XFS_INOBT_ALL_FREE && | 1963 | rec.ir_free == XFS_INOBT_ALL_FREE && |
| 1964 | mp->m_sb.sb_inopblock <= XFS_INODES_PER_CHUNK) { | 1964 | mp->m_sb.sb_inopblock <= XFS_INODES_PER_CHUNK) { |
| 1965 | xic->deleted = 1; | 1965 | xic->deleted = true; |
| 1966 | xic->first_ino = XFS_AGINO_TO_INO(mp, agno, rec.ir_startino); | 1966 | xic->first_ino = XFS_AGINO_TO_INO(mp, agno, rec.ir_startino); |
| 1967 | xic->alloc = xfs_inobt_irec_to_allocmask(&rec); | 1967 | xic->alloc = xfs_inobt_irec_to_allocmask(&rec); |
| 1968 | 1968 | ||
| @@ -1989,7 +1989,7 @@ xfs_difree_inobt( | |||
| 1989 | 1989 | ||
| 1990 | xfs_difree_inode_chunk(mp, agno, &rec, dfops); | 1990 | xfs_difree_inode_chunk(mp, agno, &rec, dfops); |
| 1991 | } else { | 1991 | } else { |
| 1992 | xic->deleted = 0; | 1992 | xic->deleted = false; |
| 1993 | 1993 | ||
| 1994 | error = xfs_inobt_update(cur, &rec); | 1994 | error = xfs_inobt_update(cur, &rec); |
| 1995 | if (error) { | 1995 | if (error) { |
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 309e26c9dddb..56d0e526870c 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c | |||
| @@ -764,7 +764,7 @@ xfs_file_fallocate( | |||
| 764 | enum xfs_prealloc_flags flags = 0; | 764 | enum xfs_prealloc_flags flags = 0; |
| 765 | uint iolock = XFS_IOLOCK_EXCL; | 765 | uint iolock = XFS_IOLOCK_EXCL; |
| 766 | loff_t new_size = 0; | 766 | loff_t new_size = 0; |
| 767 | bool do_file_insert = 0; | 767 | bool do_file_insert = false; |
| 768 | 768 | ||
| 769 | if (!S_ISREG(inode->i_mode)) | 769 | if (!S_ISREG(inode->i_mode)) |
| 770 | return -EINVAL; | 770 | return -EINVAL; |
| @@ -825,7 +825,7 @@ xfs_file_fallocate( | |||
| 825 | error = -EINVAL; | 825 | error = -EINVAL; |
| 826 | goto out_unlock; | 826 | goto out_unlock; |
| 827 | } | 827 | } |
| 828 | do_file_insert = 1; | 828 | do_file_insert = true; |
| 829 | } else { | 829 | } else { |
| 830 | flags |= XFS_PREALLOC_SET; | 830 | flags |= XFS_PREALLOC_SET; |
| 831 | 831 | ||
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index c5107c7bc4bf..dc95a49d62e7 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c | |||
| @@ -2515,7 +2515,7 @@ next_lv: | |||
| 2515 | if (lv) | 2515 | if (lv) |
| 2516 | vecp = lv->lv_iovecp; | 2516 | vecp = lv->lv_iovecp; |
| 2517 | } | 2517 | } |
| 2518 | if (record_cnt == 0 && ordered == false) { | 2518 | if (record_cnt == 0 && !ordered) { |
| 2519 | if (!lv) | 2519 | if (!lv) |
| 2520 | return 0; | 2520 | return 0; |
| 2521 | break; | 2521 | break; |
diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index ea7d4b4e50d0..e9727d0a541a 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c | |||
| @@ -704,7 +704,7 @@ xfs_mountfs( | |||
| 704 | xfs_set_maxicount(mp); | 704 | xfs_set_maxicount(mp); |
| 705 | 705 | ||
| 706 | /* enable fail_at_unmount as default */ | 706 | /* enable fail_at_unmount as default */ |
| 707 | mp->m_fail_unmount = 1; | 707 | mp->m_fail_unmount = true; |
| 708 | 708 | ||
| 709 | error = xfs_sysfs_init(&mp->m_kobj, &xfs_mp_ktype, NULL, mp->m_fsname); | 709 | error = xfs_sysfs_init(&mp->m_kobj, &xfs_mp_ktype, NULL, mp->m_fsname); |
| 710 | if (error) | 710 | if (error) |
