diff options
author | Christoph Hellwig <hch@infradead.org> | 2013-12-06 15:30:09 -0500 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2013-12-18 16:39:30 -0500 |
commit | 309ecac8e7c937c5811ef8f0efc14b3d1bd18775 (patch) | |
tree | b1a34a04e6ac1500e456d5d3ecca5d7cfb56a7c7 /fs/xfs | |
parent | 01f4f3277556d4f4f833371db0219b0ca11c5409 (diff) |
xfs: rename xfs_ilock_map_shared
Make it clear that we're only locking against the extent map on the data
fork. Also clean the function up a little bit.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs')
-rw-r--r-- | fs/xfs/xfs_aops.c | 2 | ||||
-rw-r--r-- | fs/xfs/xfs_bmap_util.c | 2 | ||||
-rw-r--r-- | fs/xfs/xfs_file.c | 6 | ||||
-rw-r--r-- | fs/xfs/xfs_inode.c | 17 | ||||
-rw-r--r-- | fs/xfs/xfs_inode.h | 2 |
5 files changed, 12 insertions, 17 deletions
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 71c8c9d2b882..a26739451b53 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c | |||
@@ -1217,7 +1217,7 @@ __xfs_get_blocks( | |||
1217 | lockmode = XFS_ILOCK_EXCL; | 1217 | lockmode = XFS_ILOCK_EXCL; |
1218 | xfs_ilock(ip, lockmode); | 1218 | xfs_ilock(ip, lockmode); |
1219 | } else { | 1219 | } else { |
1220 | lockmode = xfs_ilock_map_shared(ip); | 1220 | lockmode = xfs_ilock_data_map_shared(ip); |
1221 | } | 1221 | } |
1222 | 1222 | ||
1223 | ASSERT(offset <= mp->m_super->s_maxbytes); | 1223 | ASSERT(offset <= mp->m_super->s_maxbytes); |
diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c index 2f32d7ee1411..460aeb87c04e 100644 --- a/fs/xfs/xfs_bmap_util.c +++ b/fs/xfs/xfs_bmap_util.c | |||
@@ -632,7 +632,7 @@ xfs_getbmap( | |||
632 | */ | 632 | */ |
633 | } | 633 | } |
634 | 634 | ||
635 | lock = xfs_ilock_map_shared(ip); | 635 | lock = xfs_ilock_data_map_shared(ip); |
636 | 636 | ||
637 | /* | 637 | /* |
638 | * Don't let nex be bigger than the number of extents | 638 | * Don't let nex be bigger than the number of extents |
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 349bfa28aa3d..e00121592632 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c | |||
@@ -912,7 +912,7 @@ xfs_dir_open( | |||
912 | * If there are any blocks, read-ahead block 0 as we're almost | 912 | * If there are any blocks, read-ahead block 0 as we're almost |
913 | * certain to have the next operation be a read there. | 913 | * certain to have the next operation be a read there. |
914 | */ | 914 | */ |
915 | mode = xfs_ilock_map_shared(ip); | 915 | mode = xfs_ilock_data_map_shared(ip); |
916 | if (ip->i_d.di_nextents > 0) | 916 | if (ip->i_d.di_nextents > 0) |
917 | xfs_dir3_data_readahead(NULL, ip, 0, -1); | 917 | xfs_dir3_data_readahead(NULL, ip, 0, -1); |
918 | xfs_iunlock(ip, mode); | 918 | xfs_iunlock(ip, mode); |
@@ -1215,7 +1215,7 @@ xfs_seek_data( | |||
1215 | uint lock; | 1215 | uint lock; |
1216 | int error; | 1216 | int error; |
1217 | 1217 | ||
1218 | lock = xfs_ilock_map_shared(ip); | 1218 | lock = xfs_ilock_data_map_shared(ip); |
1219 | 1219 | ||
1220 | isize = i_size_read(inode); | 1220 | isize = i_size_read(inode); |
1221 | if (start >= isize) { | 1221 | if (start >= isize) { |
@@ -1319,7 +1319,7 @@ xfs_seek_hole( | |||
1319 | if (XFS_FORCED_SHUTDOWN(mp)) | 1319 | if (XFS_FORCED_SHUTDOWN(mp)) |
1320 | return -XFS_ERROR(EIO); | 1320 | return -XFS_ERROR(EIO); |
1321 | 1321 | ||
1322 | lock = xfs_ilock_map_shared(ip); | 1322 | lock = xfs_ilock_data_map_shared(ip); |
1323 | 1323 | ||
1324 | isize = i_size_read(inode); | 1324 | isize = i_size_read(inode); |
1325 | if (start >= isize) { | 1325 | if (start >= isize) { |
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index 967f90625eae..fdd483783365 100644 --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c | |||
@@ -91,20 +91,15 @@ xfs_get_extsz_hint( | |||
91 | * xfs_iunlock() call. | 91 | * xfs_iunlock() call. |
92 | */ | 92 | */ |
93 | uint | 93 | uint |
94 | xfs_ilock_map_shared( | 94 | xfs_ilock_data_map_shared( |
95 | xfs_inode_t *ip) | 95 | struct xfs_inode *ip) |
96 | { | 96 | { |
97 | uint lock_mode; | 97 | uint lock_mode = XFS_ILOCK_SHARED; |
98 | 98 | ||
99 | if ((ip->i_d.di_format == XFS_DINODE_FMT_BTREE) && | 99 | if (ip->i_d.di_format == XFS_DINODE_FMT_BTREE && |
100 | ((ip->i_df.if_flags & XFS_IFEXTENTS) == 0)) { | 100 | (ip->i_df.if_flags & XFS_IFEXTENTS) == 0) |
101 | lock_mode = XFS_ILOCK_EXCL; | 101 | lock_mode = XFS_ILOCK_EXCL; |
102 | } else { | ||
103 | lock_mode = XFS_ILOCK_SHARED; | ||
104 | } | ||
105 | |||
106 | xfs_ilock(ip, lock_mode); | 102 | xfs_ilock(ip, lock_mode); |
107 | |||
108 | return lock_mode; | 103 | return lock_mode; |
109 | } | 104 | } |
110 | 105 | ||
@@ -575,7 +570,7 @@ xfs_lookup( | |||
575 | if (XFS_FORCED_SHUTDOWN(dp->i_mount)) | 570 | if (XFS_FORCED_SHUTDOWN(dp->i_mount)) |
576 | return XFS_ERROR(EIO); | 571 | return XFS_ERROR(EIO); |
577 | 572 | ||
578 | lock_mode = xfs_ilock_map_shared(dp); | 573 | lock_mode = xfs_ilock_data_map_shared(dp); |
579 | error = xfs_dir_lookup(NULL, dp, name, &inum, ci_name); | 574 | error = xfs_dir_lookup(NULL, dp, name, &inum, ci_name); |
580 | xfs_iunlock(dp, lock_mode); | 575 | xfs_iunlock(dp, lock_mode); |
581 | 576 | ||
diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h index 5e2bd17cf2be..fde368624ea7 100644 --- a/fs/xfs/xfs_inode.h +++ b/fs/xfs/xfs_inode.h | |||
@@ -337,7 +337,7 @@ int xfs_ilock_nowait(xfs_inode_t *, uint); | |||
337 | void xfs_iunlock(xfs_inode_t *, uint); | 337 | void xfs_iunlock(xfs_inode_t *, uint); |
338 | void xfs_ilock_demote(xfs_inode_t *, uint); | 338 | void xfs_ilock_demote(xfs_inode_t *, uint); |
339 | int xfs_isilocked(xfs_inode_t *, uint); | 339 | int xfs_isilocked(xfs_inode_t *, uint); |
340 | uint xfs_ilock_map_shared(xfs_inode_t *); | 340 | uint xfs_ilock_data_map_shared(struct xfs_inode *); |
341 | int xfs_ialloc(struct xfs_trans *, xfs_inode_t *, umode_t, | 341 | int xfs_ialloc(struct xfs_trans *, xfs_inode_t *, umode_t, |
342 | xfs_nlink_t, xfs_dev_t, prid_t, int, | 342 | xfs_nlink_t, xfs_dev_t, prid_t, int, |
343 | struct xfs_buf **, xfs_inode_t **); | 343 | struct xfs_buf **, xfs_inode_t **); |