diff options
author | Dave Chinner <dchinner@redhat.com> | 2018-05-09 10:49:37 -0400 |
---|---|---|
committer | Darrick J. Wong <darrick.wong@oracle.com> | 2018-05-10 11:56:46 -0400 |
commit | e6631f85546c8ff8842f62c73be44ff502d4287a (patch) | |
tree | 23d3a8cc1c0a452442c53adefd990bfc81e970c0 /fs/xfs/xfs_trans_inode.c | |
parent | 1a2ebf835a3c23e0491e3279959cfb6c65a6ebbb (diff) |
xfs: get rid of the log item descriptor
It's just a connector between a transaction and a log item. There's
a 1:1 relationship between a log item descriptor and a log item,
and a 1:1 relationship between a log item descriptor and a
transaction. Both relationships are created and terminated at the
same time, so why do we even have the descriptor?
Replace it with a specific list_head in the log item and a new
log item dirtied flag to replace the XFS_LID_DIRTY flag.
Signed-Off-By: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
[darrick: fix up deferred agfl intent finish_item use of LID_DIRTY]
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs/xfs_trans_inode.c')
-rw-r--r-- | fs/xfs/xfs_trans_inode.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/xfs/xfs_trans_inode.c b/fs/xfs/xfs_trans_inode.c index 07cea592dc01..f7bd7960a90f 100644 --- a/fs/xfs/xfs_trans_inode.c +++ b/fs/xfs/xfs_trans_inode.c | |||
@@ -133,14 +133,13 @@ xfs_trans_log_inode( | |||
133 | * set however, then go ahead and bump the i_version counter | 133 | * set however, then go ahead and bump the i_version counter |
134 | * unconditionally. | 134 | * unconditionally. |
135 | */ | 135 | */ |
136 | if (!(ip->i_itemp->ili_item.li_desc->lid_flags & XFS_LID_DIRTY) && | 136 | if (!test_and_set_bit(XFS_LI_DIRTY, &ip->i_itemp->ili_item.li_flags) && |
137 | IS_I_VERSION(VFS_I(ip))) { | 137 | IS_I_VERSION(VFS_I(ip))) { |
138 | if (inode_maybe_inc_iversion(VFS_I(ip), flags & XFS_ILOG_CORE)) | 138 | if (inode_maybe_inc_iversion(VFS_I(ip), flags & XFS_ILOG_CORE)) |
139 | flags |= XFS_ILOG_CORE; | 139 | flags |= XFS_ILOG_CORE; |
140 | } | 140 | } |
141 | 141 | ||
142 | tp->t_flags |= XFS_TRANS_DIRTY; | 142 | tp->t_flags |= XFS_TRANS_DIRTY; |
143 | ip->i_itemp->ili_item.li_desc->lid_flags |= XFS_LID_DIRTY; | ||
144 | 143 | ||
145 | /* | 144 | /* |
146 | * Always OR in the bits from the ili_last_fields field. | 145 | * Always OR in the bits from the ili_last_fields field. |