xfs: reserve enough blocks to handle btree splits when remapping

In xfs_reflink_end_cow, we erroneously reserve only enough blocks to
handle adding 1 extent.  This is problematic if we fragment free space,
have to do CoW, and then have to perform multiple bmap btree expansions.
Furthermore, the BUI recovery routine doesn't reserve /any/ blocks to
handle btree splits, so log recovery fails after our first error causes
the filesystem to go down.

Therefore, refactor the transaction block reservation macros until we
have a macro that works for our deferred (re)mapping activities, and fix
both problems by using that macro.

With 1k blocks we can hit this fairly often in g/187 if the scratch fs
is big enough.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

1 files changed, 16 insertions, 2 deletions

diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c
index c0f3754caca2..ffe6fe7a7eb5 100644
--- a/fs/xfs/xfs_reflink.c
+++ b/fs/xfs/xfs_reflink.c
@@ -705,8 +705,22 @@ xfs_reflink_end_cow(
         offset_fsb = XFS_B_TO_FSBT(ip->i_mount, offset);
         end_fsb = XFS_B_TO_FSB(ip->i_mount, offset + count);
 
-        /* Start a rolling transaction to switch the mappings */
-        resblks = XFS_EXTENTADD_SPACE_RES(ip->i_mount, XFS_DATA_FORK);
+        /*
+         * Start a rolling transaction to switch the mappings.  We're
+         * unlikely ever to have to remap 16T worth of single-block
+         * extents, so just cap the worst case extent count to 2^32-1.
+         * Stick a warning in just in case, and avoid 64-bit division.
+         */
+        BUILD_BUG_ON(MAX_RW_COUNT > UINT_MAX);
+        if (end_fsb - offset_fsb > UINT_MAX) {
+                error = -EFSCORRUPTED;
+                xfs_force_shutdown(ip->i_mount, SHUTDOWN_CORRUPT_INCORE);
+                ASSERT(0);
+                goto out;
+        }
+        resblks = XFS_NEXTENTADD_SPACE_RES(ip->i_mount,
+                        (unsigned int)(end_fsb - offset_fsb),
+                        XFS_DATA_FORK);
         error = xfs_trans_alloc(ip->i_mount, &M_RES(ip->i_mount)->tr_write,
                         resblks, 0, 0, &tp);
         if (error)