xfs: make errortag a per-mountpoint structure

Remove the xfs_etest structure in favor of a per-mountpoint structure.
This will give us the flexibility to set as many error injection points
as we want, and later enable us to set up sysfs knobs to set the trigger
frequency as we wish.  This comes at a cost of higher memory use, but
unti we hit 1024 injection points (we're at 29) or a lot of mounts this
shouldn't be a huge issue.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

1 files changed, 8 insertions, 2 deletions

diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
index cc6789d35232..1a98c35e1ccf 100644
--- a/fs/xfs/xfs_mount.c
+++ b/fs/xfs/xfs_mount.c
@@ -720,10 +720,13 @@ xfs_mountfs(
         if (error)
                 goto out_del_stats;
 
+        error = xfs_errortag_init(mp);
+        if (error)
+                goto out_remove_error_sysfs;
 
         error = xfs_uuid_mount(mp);
         if (error)
-                goto out_remove_error_sysfs;
+                goto out_remove_errortag;
 
         /*
          * Set the minimum read and write sizes
@@ -1042,6 +1045,8 @@ xfs_mountfs(
         xfs_da_unmount(mp);
  out_remove_uuid:
         xfs_uuid_unmount(mp);
+ out_remove_errortag:
+        xfs_errortag_del(mp);
  out_remove_error_sysfs:
         xfs_error_sysfs_del(mp);
  out_del_stats:
@@ -1145,10 +1150,11 @@ xfs_unmountfs(
         xfs_uuid_unmount(mp);
 
 #if defined(DEBUG)
-        xfs_errortag_clearall(mp, 0);
+        xfs_errortag_clearall(mp);
 #endif
         xfs_free_perag(mp);
 
+        xfs_errortag_del(mp);
         xfs_error_sysfs_del(mp);
         xfs_sysfs_del(&mp->m_stats.xs_kobj);
         xfs_sysfs_del(&mp->m_kobj);