aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ocfs2/journal.c
diff options
context:
space:
mode:
authorJunxiao Bi <junxiao.bi@oracle.com>2013-09-11 17:19:45 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2013-09-11 18:56:30 -0400
commitf17c20dd2ec81e8ff328b81bc847da9429d0975b (patch)
tree288ff70d8c78e14f51dde033921ee0bc7072e4cd /fs/ocfs2/journal.c
parent2b1e55c389105b722cccadfa47f5615f57d8887f (diff)
ocfs2: use i_size_read() to access i_size
Though ocfs2 uses inode->i_mutex to protect i_size, there are both i_size_read/write() and direct accesses. Clean up all direct access to eliminate confusion. Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com> Cc: Jie Liu <jeff.liu@oracle.com> Cc: Mark Fasheh <mfasheh@suse.com> Cc: Joel Becker <jlbec@evilplan.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ocfs2/journal.c')
-rw-r--r--fs/ocfs2/journal.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c
index a126cb37ca4d..44fc3e530c3d 100644
--- a/fs/ocfs2/journal.c
+++ b/fs/ocfs2/journal.c
@@ -836,14 +836,14 @@ int ocfs2_journal_init(struct ocfs2_journal *journal, int *dirty)
836 inode_lock = 1; 836 inode_lock = 1;
837 di = (struct ocfs2_dinode *)bh->b_data; 837 di = (struct ocfs2_dinode *)bh->b_data;
838 838
839 if (inode->i_size < OCFS2_MIN_JOURNAL_SIZE) { 839 if (i_size_read(inode) < OCFS2_MIN_JOURNAL_SIZE) {
840 mlog(ML_ERROR, "Journal file size (%lld) is too small!\n", 840 mlog(ML_ERROR, "Journal file size (%lld) is too small!\n",
841 inode->i_size); 841 i_size_read(inode));
842 status = -EINVAL; 842 status = -EINVAL;
843 goto done; 843 goto done;
844 } 844 }
845 845
846 trace_ocfs2_journal_init(inode->i_size, 846 trace_ocfs2_journal_init(i_size_read(inode),
847 (unsigned long long)inode->i_blocks, 847 (unsigned long long)inode->i_blocks,
848 OCFS2_I(inode)->ip_clusters); 848 OCFS2_I(inode)->ip_clusters);
849 849
@@ -1131,7 +1131,7 @@ static int ocfs2_force_read_journal(struct inode *inode)
1131 1131
1132 memset(bhs, 0, sizeof(struct buffer_head *) * CONCURRENT_JOURNAL_FILL); 1132 memset(bhs, 0, sizeof(struct buffer_head *) * CONCURRENT_JOURNAL_FILL);
1133 1133
1134 num_blocks = ocfs2_blocks_for_bytes(inode->i_sb, inode->i_size); 1134 num_blocks = ocfs2_blocks_for_bytes(inode->i_sb, i_size_read(inode));
1135 v_blkno = 0; 1135 v_blkno = 0;
1136 while (v_blkno < num_blocks) { 1136 while (v_blkno < num_blocks) {
1137 status = ocfs2_extent_map_get_blocks(inode, v_blkno, 1137 status = ocfs2_extent_map_get_blocks(inode, v_blkno,