aboutsummaryrefslogtreecommitdiffstats
path: root/fs/nfs/write.c
diff options
context:
space:
mode:
authorAnna Schumaker <Anna.Schumaker@netapp.com>2014-05-06 09:12:38 -0400
committerTrond Myklebust <trond.myklebust@primarydata.com>2014-05-29 11:11:40 -0400
commitc3766276f26090f4459329839cdcc8506dfbced5 (patch)
tree3ab2e9fbafd8241995a0bf16302373db947ee9b3 /fs/nfs/write.c
parent1ed26f33008e954a8e91d26f97d4380dea8145db (diff)
NFS: Create a common multiple_pgios() function
Once again, these two functions look identical in the read and write case. Time to combine them together! Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to 'fs/nfs/write.c')
-rw-r--r--fs/nfs/write.c31
1 files changed, 1 insertions, 30 deletions
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index e46a1fc6c1fe..d3fa181053ad 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -945,35 +945,6 @@ static void nfs_initiate_write(struct nfs_pgio_data *data, struct rpc_message *m
945 &task_setup_data->rpc_client, msg, data); 945 &task_setup_data->rpc_client, msg, data);
946} 946}
947 947
948static int nfs_do_write(struct nfs_pgio_data *data,
949 const struct rpc_call_ops *call_ops,
950 int how)
951{
952 struct inode *inode = data->header->inode;
953
954 return nfs_initiate_pgio(NFS_CLIENT(inode), data, call_ops, how, 0);
955}
956
957static int nfs_do_multiple_writes(struct list_head *head,
958 const struct rpc_call_ops *call_ops,
959 int how)
960{
961 struct nfs_pgio_data *data;
962 int ret = 0;
963
964 while (!list_empty(head)) {
965 int ret2;
966
967 data = list_first_entry(head, struct nfs_pgio_data, list);
968 list_del_init(&data->list);
969
970 ret2 = nfs_do_write(data, call_ops, how);
971 if (ret == 0)
972 ret = ret2;
973 }
974 return ret;
975}
976
977/* If a nfs_flush_* function fails, it should remove reqs from @head and 948/* If a nfs_flush_* function fails, it should remove reqs from @head and
978 * call this on each, which will prepare them to be retried on next 949 * call this on each, which will prepare them to be retried on next
979 * writeback using standard nfs. 950 * writeback using standard nfs.
@@ -1018,7 +989,7 @@ static int nfs_generic_pg_writepages(struct nfs_pageio_descriptor *desc)
1018 atomic_inc(&hdr->refcnt); 989 atomic_inc(&hdr->refcnt);
1019 ret = nfs_generic_pgio(desc, hdr); 990 ret = nfs_generic_pgio(desc, hdr);
1020 if (ret == 0) 991 if (ret == 0)
1021 ret = nfs_do_multiple_writes(&hdr->rpc_list, 992 ret = nfs_do_multiple_pgios(&hdr->rpc_list,
1022 desc->pg_rpc_callops, 993 desc->pg_rpc_callops,
1023 desc->pg_ioflags); 994 desc->pg_ioflags);
1024 if (atomic_dec_and_test(&hdr->refcnt)) 995 if (atomic_dec_and_test(&hdr->refcnt))