aboutsummaryrefslogtreecommitdiffstats
path: root/fs/nfs/direct.c
diff options
context:
space:
mode:
authorDave Wysochanski <dwysocha@redhat.com>2016-04-01 13:45:09 -0400
committerAnna Schumaker <Anna.Schumaker@Netapp.com>2016-05-09 09:05:40 -0400
commitfe238e601d2519f259103ab65caea3b077ed7b39 (patch)
tree88b50933a24b69ccae24bb52f2f9bfb6b1dce2e7 /fs/nfs/direct.c
parented3743a6d4f309f5278c87a69e3125382b78455c (diff)
NFS: Save struct inode * inside nfs_commit_info to clarify usage of i_lock
Commit ea2cf22 created nfs_commit_info and saved &inode->i_lock inside this NFS specific structure. This obscures the usage of i_lock. Instead, save struct inode * so later it's clear the spinlock taken is i_lock. Should be no functional change. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'fs/nfs/direct.c')
-rw-r--r--fs/nfs/direct.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
index f79d98ae4c10..7f03163b5364 100644
--- a/fs/nfs/direct.c
+++ b/fs/nfs/direct.c
@@ -278,7 +278,7 @@ static void nfs_direct_release_pages(struct page **pages, unsigned int npages)
278void nfs_init_cinfo_from_dreq(struct nfs_commit_info *cinfo, 278void nfs_init_cinfo_from_dreq(struct nfs_commit_info *cinfo,
279 struct nfs_direct_req *dreq) 279 struct nfs_direct_req *dreq)
280{ 280{
281 cinfo->lock = &dreq->inode->i_lock; 281 cinfo->inode = dreq->inode;
282 cinfo->mds = &dreq->mds_cinfo; 282 cinfo->mds = &dreq->mds_cinfo;
283 cinfo->ds = &dreq->ds_cinfo; 283 cinfo->ds = &dreq->ds_cinfo;
284 cinfo->dreq = dreq; 284 cinfo->dreq = dreq;
@@ -635,13 +635,13 @@ nfs_direct_write_scan_commit_list(struct inode *inode,
635 struct list_head *list, 635 struct list_head *list,
636 struct nfs_commit_info *cinfo) 636 struct nfs_commit_info *cinfo)
637{ 637{
638 spin_lock(cinfo->lock); 638 spin_lock(&cinfo->inode->i_lock);
639#ifdef CONFIG_NFS_V4_1 639#ifdef CONFIG_NFS_V4_1
640 if (cinfo->ds != NULL && cinfo->ds->nwritten != 0) 640 if (cinfo->ds != NULL && cinfo->ds->nwritten != 0)
641 NFS_SERVER(inode)->pnfs_curr_ld->recover_commit_reqs(list, cinfo); 641 NFS_SERVER(inode)->pnfs_curr_ld->recover_commit_reqs(list, cinfo);
642#endif 642#endif
643 nfs_scan_commit_list(&cinfo->mds->list, list, cinfo, 0); 643 nfs_scan_commit_list(&cinfo->mds->list, list, cinfo, 0);
644 spin_unlock(cinfo->lock); 644 spin_unlock(&cinfo->inode->i_lock);
645} 645}
646 646
647static void nfs_direct_write_reschedule(struct nfs_direct_req *dreq) 647static void nfs_direct_write_reschedule(struct nfs_direct_req *dreq)
@@ -676,13 +676,13 @@ static void nfs_direct_write_reschedule(struct nfs_direct_req *dreq)
676 if (!nfs_pageio_add_request(&desc, req)) { 676 if (!nfs_pageio_add_request(&desc, req)) {
677 nfs_list_remove_request(req); 677 nfs_list_remove_request(req);
678 nfs_list_add_request(req, &failed); 678 nfs_list_add_request(req, &failed);
679 spin_lock(cinfo.lock); 679 spin_lock(&cinfo.inode->i_lock);
680 dreq->flags = 0; 680 dreq->flags = 0;
681 if (desc.pg_error < 0) 681 if (desc.pg_error < 0)
682 dreq->error = desc.pg_error; 682 dreq->error = desc.pg_error;
683 else 683 else
684 dreq->error = -EIO; 684 dreq->error = -EIO;
685 spin_unlock(cinfo.lock); 685 spin_unlock(&cinfo.inode->i_lock);
686 } 686 }
687 nfs_release_request(req); 687 nfs_release_request(req);
688 } 688 }