diff options
author | Tejun Heo <tj@kernel.org> | 2015-05-22 17:14:02 -0400 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2015-06-02 10:33:37 -0400 |
commit | 0747259d13febfcc838980a63c414c9b920cea6f (patch) | |
tree | 648ca5300a5ccbf0500a7c5e8135f2ad65085383 /fs/fs-writeback.c | |
parent | db125360409fc320790e0d38218bd7a3e9cd2552 (diff) |
writeback: dirty inodes against their matching cgroup bdi_writeback's
__mark_inode_dirty() always dirtied the inode against the root wb
(bdi_writeback). The previous patches added all the infrastructure
necessary to attribute an inode against the wb of the dirtying cgroup.
This patch updates __mark_inode_dirty() so that it uses the wb
associated with the inode instead of unconditionally using the root
one.
Currently, none of the filesystems has FS_CGROUP_WRITEBACK and all
pages will keep being dirtied against the root wb.
v2: Updated for per-inode wb association.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Jan Kara <jack@suse.cz>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'fs/fs-writeback.c')
-rw-r--r-- | fs/fs-writeback.c | 23 |
1 files changed, 11 insertions, 12 deletions
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 59d76f6c9d8d..881ea5d97c00 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c | |||
@@ -1504,7 +1504,6 @@ static noinline void block_dump___mark_inode_dirty(struct inode *inode) | |||
1504 | void __mark_inode_dirty(struct inode *inode, int flags) | 1504 | void __mark_inode_dirty(struct inode *inode, int flags) |
1505 | { | 1505 | { |
1506 | struct super_block *sb = inode->i_sb; | 1506 | struct super_block *sb = inode->i_sb; |
1507 | struct backing_dev_info *bdi = NULL; | ||
1508 | int dirtytime; | 1507 | int dirtytime; |
1509 | 1508 | ||
1510 | trace_writeback_mark_inode_dirty(inode, flags); | 1509 | trace_writeback_mark_inode_dirty(inode, flags); |
@@ -1574,30 +1573,30 @@ void __mark_inode_dirty(struct inode *inode, int flags) | |||
1574 | * reposition it (that would break b_dirty time-ordering). | 1573 | * reposition it (that would break b_dirty time-ordering). |
1575 | */ | 1574 | */ |
1576 | if (!was_dirty) { | 1575 | if (!was_dirty) { |
1576 | struct bdi_writeback *wb = inode_to_wb(inode); | ||
1577 | struct list_head *dirty_list; | 1577 | struct list_head *dirty_list; |
1578 | bool wakeup_bdi = false; | 1578 | bool wakeup_bdi = false; |
1579 | bdi = inode_to_bdi(inode); | ||
1580 | 1579 | ||
1581 | spin_unlock(&inode->i_lock); | 1580 | spin_unlock(&inode->i_lock); |
1582 | spin_lock(&bdi->wb.list_lock); | 1581 | spin_lock(&wb->list_lock); |
1583 | 1582 | ||
1584 | WARN(bdi_cap_writeback_dirty(bdi) && | 1583 | WARN(bdi_cap_writeback_dirty(wb->bdi) && |
1585 | !test_bit(WB_registered, &bdi->wb.state), | 1584 | !test_bit(WB_registered, &wb->state), |
1586 | "bdi-%s not registered\n", bdi->name); | 1585 | "bdi-%s not registered\n", wb->bdi->name); |
1587 | 1586 | ||
1588 | inode->dirtied_when = jiffies; | 1587 | inode->dirtied_when = jiffies; |
1589 | if (dirtytime) | 1588 | if (dirtytime) |
1590 | inode->dirtied_time_when = jiffies; | 1589 | inode->dirtied_time_when = jiffies; |
1591 | 1590 | ||
1592 | if (inode->i_state & (I_DIRTY_INODE | I_DIRTY_PAGES)) | 1591 | if (inode->i_state & (I_DIRTY_INODE | I_DIRTY_PAGES)) |
1593 | dirty_list = &bdi->wb.b_dirty; | 1592 | dirty_list = &wb->b_dirty; |
1594 | else | 1593 | else |
1595 | dirty_list = &bdi->wb.b_dirty_time; | 1594 | dirty_list = &wb->b_dirty_time; |
1596 | 1595 | ||
1597 | wakeup_bdi = inode_wb_list_move_locked(inode, &bdi->wb, | 1596 | wakeup_bdi = inode_wb_list_move_locked(inode, wb, |
1598 | dirty_list); | 1597 | dirty_list); |
1599 | 1598 | ||
1600 | spin_unlock(&bdi->wb.list_lock); | 1599 | spin_unlock(&wb->list_lock); |
1601 | trace_writeback_dirty_inode_enqueue(inode); | 1600 | trace_writeback_dirty_inode_enqueue(inode); |
1602 | 1601 | ||
1603 | /* | 1602 | /* |
@@ -1606,8 +1605,8 @@ void __mark_inode_dirty(struct inode *inode, int flags) | |||
1606 | * to make sure background write-back happens | 1605 | * to make sure background write-back happens |
1607 | * later. | 1606 | * later. |
1608 | */ | 1607 | */ |
1609 | if (bdi_cap_writeback_dirty(bdi) && wakeup_bdi) | 1608 | if (bdi_cap_writeback_dirty(wb->bdi) && wakeup_bdi) |
1610 | wb_wakeup_delayed(&bdi->wb); | 1609 | wb_wakeup_delayed(wb); |
1611 | return; | 1610 | return; |
1612 | } | 1611 | } |
1613 | } | 1612 | } |