diff options
author | David Sterba <dsterba@suse.com> | 2015-10-10 12:35:10 -0400 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2015-10-10 12:35:10 -0400 |
commit | 33a9eca7e4a4c2c17aebbb11f0e506a48ebc30c9 (patch) | |
tree | d7651da94ff1ef4ad27ab0ac932665fd8ef7b41c /fs/btrfs/tree-log.c | |
parent | b666a9cd993c6a49c4bf23a1ed476359c978f60b (diff) |
btrfs: comment waitqueue_active implied by locks
Suggested-by: Chris Mason <clm@fb.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/tree-log.c')
-rw-r--r-- | fs/btrfs/tree-log.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c index 1bbaace73383..d0deb4643502 100644 --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c | |||
@@ -2950,6 +2950,9 @@ out_wake_log_root: | |||
2950 | atomic_set(&log_root_tree->log_commit[index2], 0); | 2950 | atomic_set(&log_root_tree->log_commit[index2], 0); |
2951 | mutex_unlock(&log_root_tree->log_mutex); | 2951 | mutex_unlock(&log_root_tree->log_mutex); |
2952 | 2952 | ||
2953 | /* | ||
2954 | * The barrier before waitqueue_active is implied by mutex_unlock | ||
2955 | */ | ||
2953 | if (waitqueue_active(&log_root_tree->log_commit_wait[index2])) | 2956 | if (waitqueue_active(&log_root_tree->log_commit_wait[index2])) |
2954 | wake_up(&log_root_tree->log_commit_wait[index2]); | 2957 | wake_up(&log_root_tree->log_commit_wait[index2]); |
2955 | out: | 2958 | out: |
@@ -2961,6 +2964,9 @@ out: | |||
2961 | atomic_set(&root->log_commit[index1], 0); | 2964 | atomic_set(&root->log_commit[index1], 0); |
2962 | mutex_unlock(&root->log_mutex); | 2965 | mutex_unlock(&root->log_mutex); |
2963 | 2966 | ||
2967 | /* | ||
2968 | * The barrier before waitqueue_active is implied by mutex_unlock | ||
2969 | */ | ||
2964 | if (waitqueue_active(&root->log_commit_wait[index1])) | 2970 | if (waitqueue_active(&root->log_commit_wait[index1])) |
2965 | wake_up(&root->log_commit_wait[index1]); | 2971 | wake_up(&root->log_commit_wait[index1]); |
2966 | return ret; | 2972 | return ret; |