btrfs: allow unlink to exceed subvolume quota

Once a qgroup limit is exceeded, it's impossible to restore normal
operation to the subvolume without modifying the limit or removing
the subvolume.  This is a surprising situation for many users used
to the typical workflow with quotas on other file systems where it's
possible to remove files until the used space is back under the limit.

When we go to unlink a file and start the transaction, we'll hit
the qgroup limit while trying to reserve space for the items we'll
modify while removing the file.  We discussed last month how best
to handle this situation and agreed that there is no perfect solution.
The best principle-of-least-surprise solution is to handle it similarly
to how we already handle ENOSPC when unlinking, which is to allow
the operation to succeed with the expectation that it will ultimately
release space under most circumstances.

This patch modifies the transaction start path to select whether to
honor the qgroups limits.  btrfs_start_transaction_fallback_global_rsv
is the only caller that skips enforcement.  The reservation and tracking
still happens normally -- it just skips the enforcement step.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Reviewed-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.com>

1 files changed, 19 insertions, 14 deletions

diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index 1c555f1e49ba..8496dbf3f38b 100644
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -2324,7 +2324,20 @@ out:
         return ret;
 }
 
-static int qgroup_reserve(struct btrfs_root *root, u64 num_bytes)
+static bool qgroup_check_limits(const struct btrfs_qgroup *qg, u64 num_bytes)
+{
+        if ((qg->lim_flags & BTRFS_QGROUP_LIMIT_MAX_RFER) &&
+            qg->reserved + (s64)qg->rfer + num_bytes > qg->max_rfer)
+                return false;
+
+        if ((qg->lim_flags & BTRFS_QGROUP_LIMIT_MAX_EXCL) &&
+            qg->reserved + (s64)qg->excl + num_bytes > qg->max_excl)
+                return false;
+
+        return true;
+}
+
+static int qgroup_reserve(struct btrfs_root *root, u64 num_bytes, bool enforce)
 {
         struct btrfs_root *quota_root;
         struct btrfs_qgroup *qgroup;
@@ -2365,16 +2378,7 @@ static int qgroup_reserve(struct btrfs_root *root, u64 num_bytes)
 
                 qg = unode_aux_to_qgroup(unode);
 
-                if ((qg->lim_flags & BTRFS_QGROUP_LIMIT_MAX_RFER) &&
-                    qg->reserved + (s64)qg->rfer + num_bytes >
-                    qg->max_rfer) {
-                        ret = -EDQUOT;
-                        goto out;
-                }
-
-                if ((qg->lim_flags & BTRFS_QGROUP_LIMIT_MAX_EXCL) &&
-                    qg->reserved + (s64)qg->excl + num_bytes >
-                    qg->max_excl) {
+                if (enforce && !qgroup_check_limits(qg, num_bytes)) {
                         ret = -EDQUOT;
                         goto out;
                 }
@@ -2832,7 +2836,7 @@ int btrfs_qgroup_reserve_data(struct inode *inode, u64 start, u64 len)
                                         QGROUP_RESERVE);
         if (ret < 0)
                 goto cleanup;
-        ret = qgroup_reserve(root, changeset.bytes_changed);
+        ret = qgroup_reserve(root, changeset.bytes_changed, true);
         if (ret < 0)
                 goto cleanup;
 
@@ -2913,7 +2917,8 @@ int btrfs_qgroup_release_data(struct inode *inode, u64 start, u64 len)
         return __btrfs_qgroup_release_data(inode, start, len, 0);
 }
 
-int btrfs_qgroup_reserve_meta(struct btrfs_root *root, int num_bytes)
+int btrfs_qgroup_reserve_meta(struct btrfs_root *root, int num_bytes,
+                              bool enforce)
 {
         struct btrfs_fs_info *fs_info = root->fs_info;
         int ret;
@@ -2923,7 +2928,7 @@ int btrfs_qgroup_reserve_meta(struct btrfs_root *root, int num_bytes)
                 return 0;
 
         BUG_ON(num_bytes != round_down(num_bytes, fs_info->nodesize));
-        ret = qgroup_reserve(root, num_bytes);
+        ret = qgroup_reserve(root, num_bytes, enforce);
         if (ret < 0)
                 return ret;
         atomic_add(num_bytes, &root->qgroup_meta_rsv);