diff options
author | David Sterba <dsterba@suse.com> | 2015-02-16 13:36:47 -0500 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2015-10-10 12:40:04 -0400 |
commit | a83342aa0c8f0ca90057d3837ae8d198186e5153 (patch) | |
tree | 723d60098638e0f048ae630399d2f77d0e1a0c9d /fs/btrfs/ordered-data.c | |
parent | 33a9eca7e4a4c2c17aebbb11f0e506a48ebc30c9 (diff) |
btrfs: add comments to barriers before waitqueue_active
Reduce number of undocumented barriers out there.
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/ordered-data.c')
-rw-r--r-- | fs/btrfs/ordered-data.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c index 52170cf1757e..071005f008c1 100644 --- a/fs/btrfs/ordered-data.c +++ b/fs/btrfs/ordered-data.c | |||
@@ -345,6 +345,9 @@ int btrfs_dec_test_first_ordered_pending(struct inode *inode, | |||
345 | 345 | ||
346 | if (entry->bytes_left == 0) { | 346 | if (entry->bytes_left == 0) { |
347 | ret = test_and_set_bit(BTRFS_ORDERED_IO_DONE, &entry->flags); | 347 | ret = test_and_set_bit(BTRFS_ORDERED_IO_DONE, &entry->flags); |
348 | /* | ||
349 | * Implicit memory barrier after test_and_set_bit | ||
350 | */ | ||
348 | if (waitqueue_active(&entry->wait)) | 351 | if (waitqueue_active(&entry->wait)) |
349 | wake_up(&entry->wait); | 352 | wake_up(&entry->wait); |
350 | } else { | 353 | } else { |
@@ -409,6 +412,9 @@ have_entry: | |||
409 | 412 | ||
410 | if (entry->bytes_left == 0) { | 413 | if (entry->bytes_left == 0) { |
411 | ret = test_and_set_bit(BTRFS_ORDERED_IO_DONE, &entry->flags); | 414 | ret = test_and_set_bit(BTRFS_ORDERED_IO_DONE, &entry->flags); |
415 | /* | ||
416 | * Implicit memory barrier after test_and_set_bit | ||
417 | */ | ||
412 | if (waitqueue_active(&entry->wait)) | 418 | if (waitqueue_active(&entry->wait)) |
413 | wake_up(&entry->wait); | 419 | wake_up(&entry->wait); |
414 | } else { | 420 | } else { |