aboutsummaryrefslogtreecommitdiffstats
path: root/fs/btrfs/inode.c
diff options
context:
space:
mode:
authorFilipe Manana <fdmanana@suse.com>2014-10-06 17:14:26 -0400
committerChris Mason <clm@fb.com>2014-11-20 20:14:26 -0500
commitdec8f1756342c92fc31ba8bc7060b55dd62836a0 (patch)
treefbe9f1ffbe92ec004cee9d9f346a8eb8928679ef /fs/btrfs/inode.c
parent3d7a820f713a1a3339139ea8c86a98437ae0a2c1 (diff)
Btrfs: make inode.c:submit_compressed_extents() return void
Its return value is completely ignored by its single caller and it's useless anyway, since errors are indicated through SetPageError and the bit AS_EIO set in the flags of the inode's mapping. The caller can't do anything with the value, as it's invoked from a workqueue task and not by the task calling filemap_fdatawrite_range (which calls the writepages address space callback, which in turn calls the inode's fill_delalloc callback). Signed-off-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs/btrfs/inode.c')
-rw-r--r--fs/btrfs/inode.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index d1a52850d17d..6fed30c3f9ce 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -655,7 +655,7 @@ static void free_async_extent_pages(struct async_extent *async_extent)
655 * queued. We walk all the async extents created by compress_file_range 655 * queued. We walk all the async extents created by compress_file_range
656 * and send them down to the disk. 656 * and send them down to the disk.
657 */ 657 */
658static noinline int submit_compressed_extents(struct inode *inode, 658static noinline void submit_compressed_extents(struct inode *inode,
659 struct async_cow *async_cow) 659 struct async_cow *async_cow)
660{ 660{
661 struct async_extent *async_extent; 661 struct async_extent *async_extent;
@@ -667,9 +667,6 @@ static noinline int submit_compressed_extents(struct inode *inode,
667 struct extent_io_tree *io_tree; 667 struct extent_io_tree *io_tree;
668 int ret = 0; 668 int ret = 0;
669 669
670 if (list_empty(&async_cow->extents))
671 return 0;
672
673again: 670again:
674 while (!list_empty(&async_cow->extents)) { 671 while (!list_empty(&async_cow->extents)) {
675 async_extent = list_entry(async_cow->extents.next, 672 async_extent = list_entry(async_cow->extents.next,
@@ -841,7 +838,7 @@ retry:
841 kfree(async_extent); 838 kfree(async_extent);
842 cond_resched(); 839 cond_resched();
843 } 840 }
844 return 0; 841 return;
845out_free_reserve: 842out_free_reserve:
846 btrfs_free_reserved_extent(root, ins.objectid, ins.offset, 1); 843 btrfs_free_reserved_extent(root, ins.objectid, ins.offset, 1);
847out_free: 844out_free: