diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2015-12-18 18:35:08 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-12-18 18:35:08 -0500 |
commit | fc315e3e5c9418df6ce5cee97fd4adcce9dcf24e (patch) | |
tree | 16843039ea2efa2504b495d0a168d0b5a834aec3 /fs/btrfs/file.c | |
parent | 8b4414f51d098ca6f9fa3c6b6b31926f3b45d4bc (diff) | |
parent | 1d3a5a82fe724c53c472a18a31fb0bbf33dfaba2 (diff) |
Merge branch 'for-linus-4.4' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs
Pull btrfs fixes from Chris Mason:
"A couple of small fixes"
* 'for-linus-4.4' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs:
Btrfs: check prepare_uptodate_page() error code earlier
Btrfs: check for empty bitmap list in setup_cluster_bitmaps
btrfs: fix misleading warning when space cache failed to load
Btrfs: fix transaction handle leak in balance
Btrfs: fix unprotected list move from unused_bgs to deleted_bgs list
Diffstat (limited to 'fs/btrfs/file.c')
-rw-r--r-- | fs/btrfs/file.c | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 72e73461c064..0f09526aa7d9 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c | |||
@@ -1291,7 +1291,8 @@ out: | |||
1291 | * on error we return an unlocked page and the error value | 1291 | * on error we return an unlocked page and the error value |
1292 | * on success we return a locked page and 0 | 1292 | * on success we return a locked page and 0 |
1293 | */ | 1293 | */ |
1294 | static int prepare_uptodate_page(struct page *page, u64 pos, | 1294 | static int prepare_uptodate_page(struct inode *inode, |
1295 | struct page *page, u64 pos, | ||
1295 | bool force_uptodate) | 1296 | bool force_uptodate) |
1296 | { | 1297 | { |
1297 | int ret = 0; | 1298 | int ret = 0; |
@@ -1306,6 +1307,10 @@ static int prepare_uptodate_page(struct page *page, u64 pos, | |||
1306 | unlock_page(page); | 1307 | unlock_page(page); |
1307 | return -EIO; | 1308 | return -EIO; |
1308 | } | 1309 | } |
1310 | if (page->mapping != inode->i_mapping) { | ||
1311 | unlock_page(page); | ||
1312 | return -EAGAIN; | ||
1313 | } | ||
1309 | } | 1314 | } |
1310 | return 0; | 1315 | return 0; |
1311 | } | 1316 | } |
@@ -1324,6 +1329,7 @@ static noinline int prepare_pages(struct inode *inode, struct page **pages, | |||
1324 | int faili; | 1329 | int faili; |
1325 | 1330 | ||
1326 | for (i = 0; i < num_pages; i++) { | 1331 | for (i = 0; i < num_pages; i++) { |
1332 | again: | ||
1327 | pages[i] = find_or_create_page(inode->i_mapping, index + i, | 1333 | pages[i] = find_or_create_page(inode->i_mapping, index + i, |
1328 | mask | __GFP_WRITE); | 1334 | mask | __GFP_WRITE); |
1329 | if (!pages[i]) { | 1335 | if (!pages[i]) { |
@@ -1333,13 +1339,17 @@ static noinline int prepare_pages(struct inode *inode, struct page **pages, | |||
1333 | } | 1339 | } |
1334 | 1340 | ||
1335 | if (i == 0) | 1341 | if (i == 0) |
1336 | err = prepare_uptodate_page(pages[i], pos, | 1342 | err = prepare_uptodate_page(inode, pages[i], pos, |
1337 | force_uptodate); | 1343 | force_uptodate); |
1338 | if (i == num_pages - 1) | 1344 | if (!err && i == num_pages - 1) |
1339 | err = prepare_uptodate_page(pages[i], | 1345 | err = prepare_uptodate_page(inode, pages[i], |
1340 | pos + write_bytes, false); | 1346 | pos + write_bytes, false); |
1341 | if (err) { | 1347 | if (err) { |
1342 | page_cache_release(pages[i]); | 1348 | page_cache_release(pages[i]); |
1349 | if (err == -EAGAIN) { | ||
1350 | err = 0; | ||
1351 | goto again; | ||
1352 | } | ||
1343 | faili = i - 1; | 1353 | faili = i - 1; |
1344 | goto fail; | 1354 | goto fail; |
1345 | } | 1355 | } |