aboutsummaryrefslogtreecommitdiffstats
path: root/fs/btrfs/dev-replace.c
diff options
context:
space:
mode:
authorDavid Sterba <dsterba@suse.com>2018-04-04 19:41:06 -0400
committerDavid Sterba <dsterba@suse.com>2018-12-17 08:51:45 -0500
commit53176dde0acd8fa49c6c2e6097283acc6241480f (patch)
treefe42e45af2f699762556d58619b8365091ea445e /fs/btrfs/dev-replace.c
parent129827e3001fd1e6892a0629b48f9c7c91cbb8b6 (diff)
btrfs: dev-replace: remove custom read/write blocking scheme
After the rw semaphore has been added, the custom blocking using ::blocking_readers and ::read_lock_wq is redundant. The blocking logic in __btrfs_map_block is replaced by extending the time the semaphore is held, that has the same blocking effect on writes as the previous custom scheme that waited until ::blocking_readers was zero. Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/dev-replace.c')
-rw-r--r--fs/btrfs/dev-replace.c16
1 files changed, 0 insertions, 16 deletions
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
index 316a29278306..a71661f43dec 100644
--- a/fs/btrfs/dev-replace.c
+++ b/fs/btrfs/dev-replace.c
@@ -1012,14 +1012,7 @@ void btrfs_dev_replace_read_unlock(struct btrfs_dev_replace *dev_replace)
1012 1012
1013void btrfs_dev_replace_write_lock(struct btrfs_dev_replace *dev_replace) 1013void btrfs_dev_replace_write_lock(struct btrfs_dev_replace *dev_replace)
1014{ 1014{
1015again:
1016 wait_event(dev_replace->read_lock_wq,
1017 atomic_read(&dev_replace->blocking_readers) == 0);
1018 down_write(&dev_replace->rwsem); 1015 down_write(&dev_replace->rwsem);
1019 if (atomic_read(&dev_replace->blocking_readers)) {
1020 up_write(&dev_replace->rwsem);
1021 goto again;
1022 }
1023} 1016}
1024 1017
1025void btrfs_dev_replace_write_unlock(struct btrfs_dev_replace *dev_replace) 1018void btrfs_dev_replace_write_unlock(struct btrfs_dev_replace *dev_replace)
@@ -1027,15 +1020,6 @@ void btrfs_dev_replace_write_unlock(struct btrfs_dev_replace *dev_replace)
1027 up_write(&dev_replace->rwsem); 1020 up_write(&dev_replace->rwsem);
1028} 1021}
1029 1022
1030/* inc blocking cnt and release read lock */
1031void btrfs_dev_replace_set_lock_blocking(
1032 struct btrfs_dev_replace *dev_replace)
1033{
1034 /* only set blocking for read lock */
1035 atomic_inc(&dev_replace->blocking_readers);
1036 up_read(&dev_replace->rwsem);
1037}
1038
1039void btrfs_bio_counter_inc_noblocked(struct btrfs_fs_info *fs_info) 1023void btrfs_bio_counter_inc_noblocked(struct btrfs_fs_info *fs_info)
1040{ 1024{
1041 percpu_counter_inc(&fs_info->dev_replace.bio_counter); 1025 percpu_counter_inc(&fs_info->dev_replace.bio_counter);