diff options
author | David Sterba <dsterba@suse.com> | 2018-02-26 10:15:17 -0500 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2018-05-28 12:23:09 -0400 |
commit | 093258e6ebaf178bb25da514f0d1f744968cc900 (patch) | |
tree | c9ee01a7d5cc576fbe07f0df782088ce504791d1 /fs/btrfs/dev-replace.c | |
parent | 3d3a2e610ea5e7c6d4f9481ecce5d8e2d8317843 (diff) |
btrfs: replace waitqueue_actvie with cond_wake_up
Use the wrappers and reduce the amount of low-level details about the
waitqueue management.
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/dev-replace.c')
-rw-r--r-- | fs/btrfs/dev-replace.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c index 12f703e127dd..89946285203d 100644 --- a/fs/btrfs/dev-replace.c +++ b/fs/btrfs/dev-replace.c | |||
@@ -1009,9 +1009,9 @@ void btrfs_dev_replace_clear_lock_blocking( | |||
1009 | ASSERT(atomic_read(&dev_replace->read_locks) > 0); | 1009 | ASSERT(atomic_read(&dev_replace->read_locks) > 0); |
1010 | ASSERT(atomic_read(&dev_replace->blocking_readers) > 0); | 1010 | ASSERT(atomic_read(&dev_replace->blocking_readers) > 0); |
1011 | read_lock(&dev_replace->lock); | 1011 | read_lock(&dev_replace->lock); |
1012 | if (atomic_dec_and_test(&dev_replace->blocking_readers) && | 1012 | /* Barrier implied by atomic_dec_and_test */ |
1013 | waitqueue_active(&dev_replace->read_lock_wq)) | 1013 | if (atomic_dec_and_test(&dev_replace->blocking_readers)) |
1014 | wake_up(&dev_replace->read_lock_wq); | 1014 | cond_wake_up_nomb(&dev_replace->read_lock_wq); |
1015 | } | 1015 | } |
1016 | 1016 | ||
1017 | void btrfs_bio_counter_inc_noblocked(struct btrfs_fs_info *fs_info) | 1017 | void btrfs_bio_counter_inc_noblocked(struct btrfs_fs_info *fs_info) |
@@ -1022,9 +1022,7 @@ void btrfs_bio_counter_inc_noblocked(struct btrfs_fs_info *fs_info) | |||
1022 | void btrfs_bio_counter_sub(struct btrfs_fs_info *fs_info, s64 amount) | 1022 | void btrfs_bio_counter_sub(struct btrfs_fs_info *fs_info, s64 amount) |
1023 | { | 1023 | { |
1024 | percpu_counter_sub(&fs_info->bio_counter, amount); | 1024 | percpu_counter_sub(&fs_info->bio_counter, amount); |
1025 | 1025 | cond_wake_up_nomb(&fs_info->replace_wait); | |
1026 | if (waitqueue_active(&fs_info->replace_wait)) | ||
1027 | wake_up(&fs_info->replace_wait); | ||
1028 | } | 1026 | } |
1029 | 1027 | ||
1030 | void btrfs_bio_counter_inc_blocked(struct btrfs_fs_info *fs_info) | 1028 | void btrfs_bio_counter_inc_blocked(struct btrfs_fs_info *fs_info) |