diff options
author | Ilya Dryomov <idryomov@gmail.com> | 2015-11-20 16:18:43 -0500 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2016-01-13 12:24:27 -0500 |
commit | ed8a9d2c816e0b0a2c5a605505e0f09ae9010dd6 (patch) | |
tree | db36fbeeb9480457e126a1e29e26acaf4011f8f4 /fs/block_dev.c | |
parent | e36f6204288088fda50d1c84830340ccb70f85ff (diff) |
block: use bd{grab,put}() instead of open-coding
- bd_acquire() and bd_forget() open-code bdgrab() and bdput()
- raw driver uses igrab() but never checks its return value and always
holds another ref from bind_set() while calling it, so it's
equivalent to bdgrab()
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'fs/block_dev.c')
-rw-r--r-- | fs/block_dev.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/block_dev.c b/fs/block_dev.c index aa1a45985889..8b02c90ced87 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c | |||
@@ -696,7 +696,7 @@ static struct block_device *bd_acquire(struct inode *inode) | |||
696 | spin_lock(&bdev_lock); | 696 | spin_lock(&bdev_lock); |
697 | bdev = inode->i_bdev; | 697 | bdev = inode->i_bdev; |
698 | if (bdev) { | 698 | if (bdev) { |
699 | ihold(bdev->bd_inode); | 699 | bdgrab(bdev); |
700 | spin_unlock(&bdev_lock); | 700 | spin_unlock(&bdev_lock); |
701 | return bdev; | 701 | return bdev; |
702 | } | 702 | } |
@@ -712,7 +712,7 @@ static struct block_device *bd_acquire(struct inode *inode) | |||
712 | * So, we can access it via ->i_mapping always | 712 | * So, we can access it via ->i_mapping always |
713 | * without igrab(). | 713 | * without igrab(). |
714 | */ | 714 | */ |
715 | ihold(bdev->bd_inode); | 715 | bdgrab(bdev); |
716 | inode->i_bdev = bdev; | 716 | inode->i_bdev = bdev; |
717 | inode->i_mapping = bdev->bd_inode->i_mapping; | 717 | inode->i_mapping = bdev->bd_inode->i_mapping; |
718 | list_add(&inode->i_devices, &bdev->bd_inodes); | 718 | list_add(&inode->i_devices, &bdev->bd_inodes); |
@@ -735,7 +735,7 @@ void bd_forget(struct inode *inode) | |||
735 | spin_unlock(&bdev_lock); | 735 | spin_unlock(&bdev_lock); |
736 | 736 | ||
737 | if (bdev) | 737 | if (bdev) |
738 | iput(bdev->bd_inode); | 738 | bdput(bdev); |
739 | } | 739 | } |
740 | 740 | ||
741 | /** | 741 | /** |