Merge tag 'mac80211-next-for-davem-2016-07-06' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next

Johannes Berg says:

====================
One more set of new features:
 * beacon report (for radio measurement) support in cfg80211/mac80211
 * hwsim: allow wmediumd in namespaces
 * mac80211: extend 160MHz workaround to CSA IEs
 * mesh: properly encrypt group-addressed privacy action frames
 * mesh: allow setting peer AID
 * first steps for MU-MIMO monitor mode
 * along with various other cleanups and improvements
====================

Signed-off-by: David S. Miller <davem@davemloft.net>

27 files changed, 292 insertions, 91 deletions

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index d4b7a168f7c0..ebc12c521fe0 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -3858,12 +3858,16 @@ void __ath10k_scan_finish(struct ath10k *ar)
                 break;
         case ATH10K_SCAN_RUNNING:
         case ATH10K_SCAN_ABORTING:
-                if (!ar->scan.is_roc)
-                        ieee80211_scan_completed(ar->hw,
-                                                 (ar->scan.state ==
-                                                  ATH10K_SCAN_ABORTING));
-                else if (ar->scan.roc_notify)
+                if (!ar->scan.is_roc) {
+                        struct cfg80211_scan_info info = {
+                                .aborted = (ar->scan.state ==
+                                            ATH10K_SCAN_ABORTING),
+                        };
+
+                        ieee80211_scan_completed(ar->hw, &info);
+                } else if (ar->scan.roc_notify) {
                         ieee80211_remain_on_channel_expired(ar->hw);
+                }
                 /* fall through */
         case ATH10K_SCAN_STARTING:
                 ar->scan.state = ATH10K_SCAN_IDLE;
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 4e11ba06f089..ef5b40ef6d67 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -859,7 +859,11 @@ void ath6kl_cfg80211_disconnect_event(struct ath6kl_vif *vif, u8 reason,
         struct ath6kl *ar = vif->ar;
 
         if (vif->scan_req) {
-                cfg80211_scan_done(vif->scan_req, true);
+                struct cfg80211_scan_info info = {
+                        .aborted = true,
+                };
+
+                cfg80211_scan_done(vif->scan_req, &info);
                 vif->scan_req = NULL;
         }
 
@@ -1069,6 +1073,9 @@ static int ath6kl_cfg80211_scan(struct wiphy *wiphy,
 void ath6kl_cfg80211_scan_complete_event(struct ath6kl_vif *vif, bool aborted)
 {
         struct ath6kl *ar = vif->ar;
+        struct cfg80211_scan_info info = {
+                .aborted = aborted,
+        };
         int i;
 
         ath6kl_dbg(ATH6KL_DBG_WLAN_CFG, "%s: status%s\n", __func__,
@@ -1089,7 +1096,7 @@ void ath6kl_cfg80211_scan_complete_event(struct ath6kl_vif *vif, bool aborted)
         }
 
 out:
-        cfg80211_scan_done(vif->scan_req, aborted);
+        cfg80211_scan_done(vif->scan_req, &info);
         vif->scan_req = NULL;
 }
 
@@ -3614,7 +3621,11 @@ void ath6kl_cfg80211_vif_stop(struct ath6kl_vif *vif, bool wmi_ready)
         }
 
         if (vif->scan_req) {
-                cfg80211_scan_done(vif->scan_req, true);
+                struct cfg80211_scan_info info = {
+                        .aborted = true,
+                };
+
+                cfg80211_scan_done(vif->scan_req, &info);
                 vif->scan_req = NULL;
         }
 
diff --git a/drivers/net/wireless/ath/ath9k/channel.c b/drivers/net/wireless/ath/ath9k/channel.c
index e56bafcf5864..57e26a640477 100644
--- a/drivers/net/wireless/ath/ath9k/channel.c
+++ b/drivers/net/wireless/ath/ath9k/channel.c
@@ -960,6 +960,9 @@ void ath_roc_complete(struct ath_softc *sc, enum ath_roc_complete_reason reason)
 void ath_scan_complete(struct ath_softc *sc, bool abort)
 {
         struct ath_common *common = ath9k_hw_common(sc->sc_ah);
+        struct cfg80211_scan_info info = {
+                .aborted = abort,
+        };
 
         if (abort)
                 ath_dbg(common, CHAN_CTX, "HW scan aborted\n");
@@ -969,7 +972,7 @@ void ath_scan_complete(struct ath_softc *sc, bool abort)
         sc->offchannel.scan_req = NULL;
         sc->offchannel.scan_vif = NULL;
         sc->offchannel.state = ATH_OFFCHANNEL_IDLE;
-        ieee80211_scan_completed(sc->hw, abort);
+        ieee80211_scan_completed(sc->hw, &info);
         clear_bit(ATH_OP_SCANNING, &common->op_flags);
         spin_lock_bh(&sc->chan_lock);
         if (test_bit(ATH_OP_MULTI_CHANNEL, &common->op_flags))
diff --git a/drivers/net/wireless/ath/wil6210/cfg80211.c b/drivers/net/wireless/ath/wil6210/cfg80211.c
index 62bf9331bd7f..f0e1175fb76a 100644
--- a/drivers/net/wireless/ath/wil6210/cfg80211.c
+++ b/drivers/net/wireless/ath/wil6210/cfg80211.c
@@ -1369,7 +1369,11 @@ static void wil_cfg80211_stop_p2p_device(struct wiphy *wiphy,
         mutex_lock(&wil->mutex);
         started = wil_p2p_stop_discovery(wil);
         if (started && wil->scan_request) {
-                cfg80211_scan_done(wil->scan_request, 1);
+                struct cfg80211_scan_info info = {
+                        .aborted = true,
+                };
+
+                cfg80211_scan_done(wil->scan_request, &info);
                 wil->scan_request = NULL;
                 wil->radio_wdev = wil->wdev;
         }
diff --git a/drivers/net/wireless/ath/wil6210/main.c b/drivers/net/wireless/ath/wil6210/main.c
index 8e31d755bbee..4bc92e54984a 100644
--- a/drivers/net/wireless/ath/wil6210/main.c
+++ b/drivers/net/wireless/ath/wil6210/main.c
@@ -850,10 +850,14 @@ int wil_reset(struct wil6210_priv *wil, bool load_fw)
         mutex_unlock(&wil->wmi_mutex);
 
         if (wil->scan_request) {
+                struct cfg80211_scan_info info = {
+                        .aborted = true,
+                };
+
                 wil_dbg_misc(wil, "Abort scan_request 0x%p\n",
                              wil->scan_request);
                 del_timer_sync(&wil->scan_timer);
-                cfg80211_scan_done(wil->scan_request, true);
+                cfg80211_scan_done(wil->scan_request, &info);
                 wil->scan_request = NULL;
         }
 
@@ -1049,10 +1053,14 @@ int __wil_down(struct wil6210_priv *wil)
         (void)wil_p2p_stop_discovery(wil);
 
         if (wil->scan_request) {
+                struct cfg80211_scan_info info = {
+                        .aborted = true,
+                };
+
                 wil_dbg_misc(wil, "Abort scan_request 0x%p\n",
                              wil->scan_request);
                 del_timer_sync(&wil->scan_timer);
-                cfg80211_scan_done(wil->scan_request, true);
+                cfg80211_scan_done(wil->scan_request, &info);
                 wil->scan_request = NULL;
         }
 
diff --git a/drivers/net/wireless/ath/wil6210/p2p.c b/drivers/net/wireless/ath/wil6210/p2p.c
index 213b8259638c..e0f8aa0ebfac 100644
--- a/drivers/net/wireless/ath/wil6210/p2p.c
+++ b/drivers/net/wireless/ath/wil6210/p2p.c
@@ -252,8 +252,12 @@ void wil_p2p_search_expired(struct work_struct *work)
         mutex_unlock(&wil->mutex);
 
         if (started) {
+                struct cfg80211_scan_info info = {
+                        .aborted = false,
+                };
+
                 mutex_lock(&wil->p2p_wdev_mutex);
-                cfg80211_scan_done(wil->scan_request, 0);
+                cfg80211_scan_done(wil->scan_request, &info);
                 wil->scan_request = NULL;
                 wil->radio_wdev = wil->wdev;
                 mutex_unlock(&wil->p2p_wdev_mutex);
diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c
index b80c5d850e1e..4d92541913c0 100644
--- a/drivers/net/wireless/ath/wil6210/wmi.c
+++ b/drivers/net/wireless/ath/wil6210/wmi.c
@@ -426,15 +426,17 @@ static void wmi_evt_scan_complete(struct wil6210_priv *wil, int id,
 {
         if (wil->scan_request) {
                 struct wmi_scan_complete_event *data = d;
-                bool aborted = (data->status != WMI_SCAN_SUCCESS);
+                struct cfg80211_scan_info info = {
+                        .aborted = (data->status != WMI_SCAN_SUCCESS),
+                };
 
                 wil_dbg_wmi(wil, "SCAN_COMPLETE(0x%08x)\n", data->status);
                 wil_dbg_misc(wil, "Complete scan_request 0x%p aborted %d\n",
-                             wil->scan_request, aborted);
+                             wil->scan_request, info.aborted);
 
                 del_timer_sync(&wil->scan_timer);
                 mutex_lock(&wil->p2p_wdev_mutex);
-                cfg80211_scan_done(wil->scan_request, aborted);
+                cfg80211_scan_done(wil->scan_request, &info);
                 wil->radio_wdev = wil->wdev;
                 mutex_unlock(&wil->p2p_wdev_mutex);
                 wil->scan_request = NULL;
diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c b/drivers/net/wireless/atmel/at76c50x-usb.c
index 7c108047fb46..0e180677c7fc 100644
--- a/drivers/net/wireless/atmel/at76c50x-usb.c
+++ b/drivers/net/wireless/atmel/at76c50x-usb.c
@@ -1922,6 +1922,9 @@ static void at76_dwork_hw_scan(struct work_struct *work)
 {
         struct at76_priv *priv = container_of(work, struct at76_priv,
                                               dwork_hw_scan.work);
+        struct cfg80211_scan_info info = {
+                .aborted = false,
+        };
         int ret;
 
         if (priv->device_unplugged)
@@ -1948,7 +1951,7 @@ static void at76_dwork_hw_scan(struct work_struct *work)
 
         mutex_unlock(&priv->mtx);
 
-        ieee80211_scan_completed(priv->hw, false);
+        ieee80211_scan_completed(priv->hw, &info);
 
         ieee80211_wake_queues(priv->hw);
 }
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 264bd638a3d9..afe2b202040a 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -775,9 +775,13 @@ s32 brcmf_notify_escan_complete(struct brcmf_cfg80211_info *cfg,
                 if (!aborted)
                         cfg80211_sched_scan_results(cfg_to_wiphy(cfg));
         } else if (scan_request) {
+                struct cfg80211_scan_info info = {
+                        .aborted = aborted,
+                };
+
                 brcmf_dbg(SCAN, "ESCAN Completed scan: %s\n",
                           aborted ? "Aborted" : "Done");
-                cfg80211_scan_done(scan_request, aborted);
+                cfg80211_scan_done(scan_request, &info);
         }
         if (!test_and_clear_bit(BRCMF_SCAN_STATUS_BUSY, &cfg->scan_status))
                 brcmf_dbg(SCAN, "Scan complete, probably P2P scan\n");
diff --git a/drivers/net/wireless/intel/iwlegacy/common.c b/drivers/net/wireless/intel/iwlegacy/common.c
index eb24b9241bb2..140b6ea8f7cc 100644
--- a/drivers/net/wireless/intel/iwlegacy/common.c
+++ b/drivers/net/wireless/intel/iwlegacy/common.c
@@ -1305,10 +1305,14 @@ il_send_scan_abort(struct il_priv *il)
 static void
 il_complete_scan(struct il_priv *il, bool aborted)
 {
+        struct cfg80211_scan_info info = {
+                .aborted = aborted,
+        };
+
         /* check if scan was requested from mac80211 */
         if (il->scan_request) {
                 D_SCAN("Complete scan in mac80211\n");
-                ieee80211_scan_completed(il->hw, aborted);
+                ieee80211_scan_completed(il->hw, &info);
         }
 
         il->scan_vif = NULL;
diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/scan.c b/drivers/net/wireless/intel/iwlwifi/dvm/scan.c
index d01766f16175..17e6a32384d3 100644
--- a/drivers/net/wireless/intel/iwlwifi/dvm/scan.c
+++ b/drivers/net/wireless/intel/iwlwifi/dvm/scan.c
@@ -94,10 +94,14 @@ static int iwl_send_scan_abort(struct iwl_priv *priv)
 
 static void iwl_complete_scan(struct iwl_priv *priv, bool aborted)
 {
+        struct cfg80211_scan_info info = {
+                .aborted = aborted,
+        };
+
         /* check if scan was requested from mac80211 */
         if (priv->scan_request) {
                 IWL_DEBUG_SCAN(priv, "Complete scan in mac80211\n");
-                ieee80211_scan_completed(priv->hw, aborted);
+                ieee80211_scan_completed(priv->hw, &info);
         }
 
         priv->scan_type = IWL_SCAN_NORMAL;
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
index e78fc567ff7d..1cac10c5d818 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
@@ -391,13 +391,16 @@ void iwl_mvm_rx_lmac_scan_complete_notif(struct iwl_mvm *mvm,
                 ieee80211_sched_scan_stopped(mvm->hw);
                 mvm->sched_scan_pass_all = SCHED_SCAN_PASS_ALL_DISABLED;
         } else if (mvm->scan_status & IWL_MVM_SCAN_REGULAR) {
+                struct cfg80211_scan_info info = {
+                        .aborted = aborted,
+                };
+
                 IWL_DEBUG_SCAN(mvm, "Regular scan %s, EBS status %s (FW)\n",
                                aborted ? "aborted" : "completed",
                                iwl_mvm_ebs_status_str(scan_notif->ebs_status));
 
                 mvm->scan_status &= ~IWL_MVM_SCAN_REGULAR;
-                ieee80211_scan_completed(mvm->hw,
-                                scan_notif->status == IWL_SCAN_OFFLOAD_ABORTED);
+                ieee80211_scan_completed(mvm->hw, &info);
                 iwl_mvm_unref(mvm, IWL_MVM_REF_SCAN);
                 del_timer(&mvm->scan_timer);
         } else {
@@ -1430,7 +1433,11 @@ void iwl_mvm_rx_umac_scan_complete_notif(struct iwl_mvm *mvm,
 
         /* if the scan is already stopping, we don't need to notify mac80211 */
         if (mvm->scan_uid_status[uid] == IWL_MVM_SCAN_REGULAR) {
-                ieee80211_scan_completed(mvm->hw, aborted);
+                struct cfg80211_scan_info info = {
+                        .aborted = aborted,
+                };
+
+                ieee80211_scan_completed(mvm->hw, &info);
                 iwl_mvm_unref(mvm, IWL_MVM_REF_SCAN);
                 del_timer(&mvm->scan_timer);
         } else if (mvm->scan_uid_status[uid] == IWL_MVM_SCAN_SCHED) {
@@ -1564,7 +1571,11 @@ void iwl_mvm_report_scan_aborted(struct iwl_mvm *mvm)
 
                 uid = iwl_mvm_scan_uid_by_status(mvm, IWL_MVM_SCAN_REGULAR);
                 if (uid >= 0) {
-                        ieee80211_scan_completed(mvm->hw, true);
+                        struct cfg80211_scan_info info = {
+                                .aborted = true,
+                        };
+
+                        ieee80211_scan_completed(mvm->hw, &info);
                         mvm->scan_uid_status[uid] = 0;
                 }
                 uid = iwl_mvm_scan_uid_by_status(mvm, IWL_MVM_SCAN_SCHED);
@@ -1585,8 +1596,13 @@ void iwl_mvm_report_scan_aborted(struct iwl_mvm *mvm)
                                 mvm->scan_uid_status[i] = 0;
                 }
         } else {
-                if (mvm->scan_status & IWL_MVM_SCAN_REGULAR)
-                        ieee80211_scan_completed(mvm->hw, true);
+                if (mvm->scan_status & IWL_MVM_SCAN_REGULAR) {
+                        struct cfg80211_scan_info info = {
+                                .aborted = true,
+                        };
+
+                        ieee80211_scan_completed(mvm->hw, &info);
+                }
 
                 /* Sched scan will be restarted by mac80211 in
                  * restart_hw, so do not report if FW is about to be
@@ -1629,8 +1645,13 @@ out:
                  */
                 iwl_mvm_unref(mvm, IWL_MVM_REF_SCAN);
                 del_timer(&mvm->scan_timer);
-                if (notify)
-                        ieee80211_scan_completed(mvm->hw, true);
+                if (notify) {
+                        struct cfg80211_scan_info info = {
+                                .aborted = true,
+                        };
+
+                        ieee80211_scan_completed(mvm->hw, &info);
+                }
         } else if (notify) {
                 ieee80211_sched_scan_stopped(mvm->hw);
                 mvm->sched_scan_pass_all = SCHED_SCAN_PASS_ALL_DISABLED;
diff --git a/drivers/net/wireless/intersil/orinoco/scan.c b/drivers/net/wireless/intersil/orinoco/scan.c
index d0ceb06c72d0..6d1d084854fb 100644
--- a/drivers/net/wireless/intersil/orinoco/scan.c
+++ b/drivers/net/wireless/intersil/orinoco/scan.c
@@ -237,7 +237,11 @@ void orinoco_add_hostscan_results(struct orinoco_private *priv,
 
  scan_abort:
         if (priv->scan_request) {
-                cfg80211_scan_done(priv->scan_request, abort);
+                struct cfg80211_scan_info info = {
+                        .aborted = abort,
+                };
+
+                cfg80211_scan_done(priv->scan_request, &info);
                 priv->scan_request = NULL;
         }
 }
@@ -245,7 +249,11 @@ void orinoco_add_hostscan_results(struct orinoco_private *priv,
 void orinoco_scan_done(struct orinoco_private *priv, bool abort)
 {
         if (priv->scan_request) {
-                cfg80211_scan_done(priv->scan_request, abort);
+                struct cfg80211_scan_info info = {
+                        .aborted = abort,
+                };
+
+                cfg80211_scan_done(priv->scan_request, &info);
                 priv->scan_request = NULL;
         }
 }
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index a1e28a4fd658..8c35ac838fce 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -41,8 +41,6 @@ MODULE_AUTHOR("Jouni Malinen");
 MODULE_DESCRIPTION("Software simulator of 802.11 radio(s) for mac80211");
 MODULE_LICENSE("GPL");
 
-static u32 wmediumd_portid;
-
 static int radios = 2;
 module_param(radios, int, 0444);
 MODULE_PARM_DESC(radios, "Number of simulated radios");
@@ -252,12 +250,13 @@ static inline void hwsim_clear_chanctx_magic(struct ieee80211_chanctx_conf *c)
         cp->magic = 0;
 }
 
-static unsigned int hwsim_net_id;
+static int hwsim_net_id;
 
 static int hwsim_netgroup;
 
 struct hwsim_net {
         int netgroup;
+        u32 wmediumd;
 };
 
 static inline int hwsim_net_get_netgroup(struct net *net)
@@ -274,6 +273,20 @@ static inline void hwsim_net_set_netgroup(struct net *net)
         hwsim_net->netgroup = hwsim_netgroup++;
 }
 
+static inline u32 hwsim_net_get_wmediumd(struct net *net)
+{
+        struct hwsim_net *hwsim_net = net_generic(net, hwsim_net_id);
+
+        return hwsim_net->wmediumd;
+}
+
+static inline void hwsim_net_set_wmediumd(struct net *net, u32 portid)
+{
+        struct hwsim_net *hwsim_net = net_generic(net, hwsim_net_id);
+
+        hwsim_net->wmediumd = portid;
+}
+
 static struct class *hwsim_class;
 
 static struct net_device *hwsim_mon; /* global monitor netdev */
@@ -444,10 +457,6 @@ static const struct ieee80211_iface_limit hwsim_if_limits[] = {
         { .max = 1, .types = BIT(NL80211_IFTYPE_P2P_DEVICE) }
 };
 
-static const struct ieee80211_iface_limit hwsim_if_dfs_limits[] = {
-        { .max = 8, .types = BIT(NL80211_IFTYPE_AP) },
-};
-
 static const struct ieee80211_iface_combination hwsim_if_comb[] = {
         {
                 .limits = hwsim_if_limits,
@@ -455,18 +464,12 @@ static const struct ieee80211_iface_combination hwsim_if_comb[] = {
                 .n_limits = ARRAY_SIZE(hwsim_if_limits) - 1,
                 .max_interfaces = 2048,
                 .num_different_channels = 1,
-        },
-        {
-                .limits = hwsim_if_dfs_limits,
-                .n_limits = ARRAY_SIZE(hwsim_if_dfs_limits),
-                .max_interfaces = 8,
-                .num_different_channels = 1,
                 .radar_detect_widths = BIT(NL80211_CHAN_WIDTH_20_NOHT) |
                                        BIT(NL80211_CHAN_WIDTH_20) |
                                        BIT(NL80211_CHAN_WIDTH_40) |
                                        BIT(NL80211_CHAN_WIDTH_80) |
                                        BIT(NL80211_CHAN_WIDTH_160),
-        }
+        },
 };
 
 static const struct ieee80211_iface_combination hwsim_if_comb_p2p_dev[] = {
@@ -475,18 +478,12 @@ static const struct ieee80211_iface_combination hwsim_if_comb_p2p_dev[] = {
                 .n_limits = ARRAY_SIZE(hwsim_if_limits),
                 .max_interfaces = 2048,
                 .num_different_channels = 1,
-        },
-        {
-                .limits = hwsim_if_dfs_limits,
-                .n_limits = ARRAY_SIZE(hwsim_if_dfs_limits),
-                .max_interfaces = 8,
-                .num_different_channels = 1,
                 .radar_detect_widths = BIT(NL80211_CHAN_WIDTH_20_NOHT) |
                                        BIT(NL80211_CHAN_WIDTH_20) |
                                        BIT(NL80211_CHAN_WIDTH_40) |
                                        BIT(NL80211_CHAN_WIDTH_80) |
                                        BIT(NL80211_CHAN_WIDTH_160),
-        }
+        },
 };
 
 static spinlock_t hwsim_radio_lock;
@@ -552,6 +549,8 @@ struct mac80211_hwsim_data {
 
         /* group shared by radios created in the same netns */
         int netgroup;
+        /* wmediumd portid responsible for netgroup of this radio */
+        u32 wmediumd;
 
         int power_level;
 
@@ -983,6 +982,29 @@ static bool hwsim_ps_rx_ok(struct mac80211_hwsim_data *data,
         return true;
 }
 
+static int hwsim_unicast_netgroup(struct mac80211_hwsim_data *data,
+                                  struct sk_buff *skb, int portid)
+{
+        struct net *net;
+        bool found = false;
+        int res = -ENOENT;
+
+        rcu_read_lock();
+        for_each_net_rcu(net) {
+                if (data->netgroup == hwsim_net_get_netgroup(net)) {
+                        res = genlmsg_unicast(net, skb, portid);
+                        found = true;
+                        break;
+                }
+        }
+        rcu_read_unlock();
+
+        if (!found)
+                nlmsg_free(skb);
+
+        return res;
+}
+
 static void mac80211_hwsim_tx_frame_nl(struct ieee80211_hw *hw,
                                        struct sk_buff *my_skb,
                                        int dst_portid)
@@ -1062,7 +1084,7 @@ static void mac80211_hwsim_tx_frame_nl(struct ieee80211_hw *hw,
                 goto nla_put_failure;
 
         genlmsg_end(skb, msg_head);
-        if (genlmsg_unicast(&init_net, skb, dst_portid))
+        if (hwsim_unicast_netgroup(data, skb, dst_portid))
                 goto err_free_txskb;
 
         /* Enqueue the packet */
@@ -1355,7 +1377,7 @@ static void mac80211_hwsim_tx(struct ieee80211_hw *hw,
         mac80211_hwsim_monitor_rx(hw, skb, channel);
 
         /* wmediumd mode check */
-        _portid = ACCESS_ONCE(wmediumd_portid);
+        _portid = ACCESS_ONCE(data->wmediumd);
 
         if (_portid)
                 return mac80211_hwsim_tx_frame_nl(hw, skb, _portid);
@@ -1451,7 +1473,8 @@ static void mac80211_hwsim_tx_frame(struct ieee80211_hw *hw,
                                     struct sk_buff *skb,
                                     struct ieee80211_channel *chan)
 {
-        u32 _pid = ACCESS_ONCE(wmediumd_portid);
+        struct mac80211_hwsim_data *data = hw->priv;
+        u32 _pid = ACCESS_ONCE(data->wmediumd);
 
         if (ieee80211_hw_check(hw, SUPPORTS_RC_TABLE)) {
                 struct ieee80211_tx_info *txi = IEEE80211_SKB_CB(skb);
@@ -1918,8 +1941,12 @@ static void hw_scan_work(struct work_struct *work)
 
         mutex_lock(&hwsim->mutex);
         if (hwsim->scan_chan_idx >= req->n_channels) {
+                struct cfg80211_scan_info info = {
+                        .aborted = false,
+                };
+
                 wiphy_debug(hwsim->hw->wiphy, "hw scan complete\n");
-                ieee80211_scan_completed(hwsim->hw, false);
+                ieee80211_scan_completed(hwsim->hw, &info);
                 hwsim->hw_scan_request = NULL;
                 hwsim->hw_scan_vif = NULL;
                 hwsim->tmp_chan = NULL;
@@ -2004,13 +2031,16 @@ static void mac80211_hwsim_cancel_hw_scan(struct ieee80211_hw *hw,
                                           struct ieee80211_vif *vif)
 {
         struct mac80211_hwsim_data *hwsim = hw->priv;
+        struct cfg80211_scan_info info = {
+                .aborted = true,
+        };
 
         wiphy_debug(hw->wiphy, "hwsim cancel_hw_scan\n");
 
         cancel_delayed_work_sync(&hwsim->hw_scan);
 
         mutex_lock(&hwsim->mutex);
-        ieee80211_scan_completed(hwsim->hw, true);
+        ieee80211_scan_completed(hwsim->hw, &info);
         hwsim->tmp_chan = NULL;
         hwsim->hw_scan_request = NULL;
         hwsim->hw_scan_vif = NULL;
@@ -2448,13 +2478,14 @@ static int mac80211_hwsim_new_radio(struct genl_info *info,
                 hw->wiphy->max_scan_ssids = 255;
                 hw->wiphy->max_scan_ie_len = IEEE80211_MAX_DATA_LEN;
                 hw->wiphy->max_remain_on_channel_duration = 1000;
-                /* For channels > 1 DFS is not allowed */
-                hw->wiphy->n_iface_combinations = 1;
                 hw->wiphy->iface_combinations = &data->if_combination;
                 if (param->p2p_device)
                         data->if_combination = hwsim_if_comb_p2p_dev[0];
                 else
                         data->if_combination = hwsim_if_comb[0];
+                hw->wiphy->n_iface_combinations = 1;
+                /* For channels > 1 DFS is not allowed */
+                data->if_combination.radar_detect_widths = 0;
                 data->if_combination.num_different_channels = data->channels;
         } else if (param->p2p_device) {
                 hw->wiphy->iface_combinations = hwsim_if_comb_p2p_dev;
@@ -2796,6 +2827,20 @@ static struct mac80211_hwsim_data *get_hwsim_data_ref_from_addr(const u8 *addr)
         return data;
 }
 
+static void hwsim_register_wmediumd(struct net *net, u32 portid)
+{
+        struct mac80211_hwsim_data *data;
+
+        hwsim_net_set_wmediumd(net, portid);
+
+        spin_lock_bh(&hwsim_radio_lock);
+        list_for_each_entry(data, &hwsim_radios, list) {
+                if (data->netgroup == hwsim_net_get_netgroup(net))
+                        data->wmediumd = portid;
+        }
+        spin_unlock_bh(&hwsim_radio_lock);
+}
+
 static int hwsim_tx_info_frame_received_nl(struct sk_buff *skb_2,
                                            struct genl_info *info)
 {
@@ -2811,9 +2856,6 @@ static int hwsim_tx_info_frame_received_nl(struct sk_buff *skb_2,
         int i;
         bool found = false;
 
-        if (info->snd_portid != wmediumd_portid)
-                return -EINVAL;
-
         if (!info->attrs[HWSIM_ATTR_ADDR_TRANSMITTER] ||
             !info->attrs[HWSIM_ATTR_FLAGS] ||
             !info->attrs[HWSIM_ATTR_COOKIE] ||
@@ -2829,6 +2871,12 @@ static int hwsim_tx_info_frame_received_nl(struct sk_buff *skb_2,
         if (!data2)
                 goto out;
 
+        if (hwsim_net_get_netgroup(genl_info_net(info)) != data2->netgroup)
+                goto out;
+
+        if (info->snd_portid != data2->wmediumd)
+                goto out;
+
         /* look for the skb matching the cookie passed back from user */
         skb_queue_walk_safe(&data2->pending, skb, tmp) {
                 u64 skb_cookie;
@@ -2892,9 +2940,6 @@ static int hwsim_cloned_frame_received_nl(struct sk_buff *skb_2,
         void *frame_data;
         struct sk_buff *skb = NULL;
 
-        if (info->snd_portid != wmediumd_portid)
-                return -EINVAL;
-
         if (!info->attrs[HWSIM_ATTR_ADDR_RECEIVER] ||
             !info->attrs[HWSIM_ATTR_FRAME] ||
             !info->attrs[HWSIM_ATTR_RX_RATE] ||
@@ -2920,6 +2965,12 @@ static int hwsim_cloned_frame_received_nl(struct sk_buff *skb_2,
         if (!data2)
                 goto out;
 
+        if (hwsim_net_get_netgroup(genl_info_net(info)) != data2->netgroup)
+                goto out;
+
+        if (info->snd_portid != data2->wmediumd)
+                goto out;
+
         /* check if radio is configured properly */
 
         if (data2->idle || !data2->started)
@@ -2966,6 +3017,7 @@ out:
 static int hwsim_register_received_nl(struct sk_buff *skb_2,
                                       struct genl_info *info)
 {
+        struct net *net = genl_info_net(info);
         struct mac80211_hwsim_data *data;
         int chans = 1;
 
@@ -2982,10 +3034,10 @@ static int hwsim_register_received_nl(struct sk_buff *skb_2,
         if (chans > 1)
                 return -EOPNOTSUPP;
 
-        if (wmediumd_portid)
+        if (hwsim_net_get_wmediumd(net))
                 return -EBUSY;
 
-        wmediumd_portid = info->snd_portid;
+        hwsim_register_wmediumd(net, info->snd_portid);
 
         printk(KERN_DEBUG "mac80211_hwsim: received a REGISTER, "
                "switching to wmediumd mode with pid %d\n", info->snd_portid);
@@ -3152,7 +3204,7 @@ static const struct genl_ops hwsim_ops[] = {
                 .cmd = HWSIM_CMD_REGISTER,
                 .policy = hwsim_genl_policy,
                 .doit = hwsim_register_received_nl,
-                .flags = GENL_ADMIN_PERM,
+                .flags = GENL_UNS_ADMIN_PERM,
         },
         {
                 .cmd = HWSIM_CMD_FRAME,
@@ -3218,10 +3270,10 @@ static int mac80211_hwsim_netlink_notify(struct notifier_block *nb,
 
         remove_user_radios(notify->portid);
 
-        if (notify->portid == wmediumd_portid) {
+        if (notify->portid == hwsim_net_get_wmediumd(notify->net)) {
                 printk(KERN_INFO "mac80211_hwsim: wmediumd released netlink"
                        " socket, switching to perfect channel medium\n");
-                wmediumd_portid = 0;
+                hwsim_register_wmediumd(notify->net, 0);
         }
         return NOTIFY_DONE;
 
diff --git a/drivers/net/wireless/marvell/libertas/cfg.c b/drivers/net/wireless/marvell/libertas/cfg.c
index 776b44bfd93a..ea4802446618 100644
--- a/drivers/net/wireless/marvell/libertas/cfg.c
+++ b/drivers/net/wireless/marvell/libertas/cfg.c
@@ -796,10 +796,15 @@ void lbs_scan_done(struct lbs_private *priv)
 {
         WARN_ON(!priv->scan_req);
 
-        if (priv->internal_scan)
+        if (priv->internal_scan) {
                 kfree(priv->scan_req);
-        else
-                cfg80211_scan_done(priv->scan_req, false);
+        } else {
+                struct cfg80211_scan_info info = {
+                        .aborted = false,
+                };
+
+                cfg80211_scan_done(priv->scan_req, &info);
+        }
 
         priv->scan_req = NULL;
 }
diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
index 6bc2011d8609..e7a21443647e 100644
--- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c
+++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
@@ -1057,8 +1057,12 @@ mwifiex_cancel_all_pending_cmd(struct mwifiex_adapter *adapter)
                         if (!priv)
                                 continue;
                         if (priv->scan_request) {
+                                struct cfg80211_scan_info info = {
+                                        .aborted = true,
+                                };
+
                                 mwifiex_dbg(adapter, WARN, "info: aborting scan\n");
-                                cfg80211_scan_done(priv->scan_request, 1);
+                                cfg80211_scan_done(priv->scan_request, &info);
                                 priv->scan_request = NULL;
                         }
                 }
@@ -1112,8 +1116,12 @@ mwifiex_cancel_pending_ioctl(struct mwifiex_adapter *adapter)
                         if (!priv)
                                 continue;
                         if (priv->scan_request) {
+                                struct cfg80211_scan_info info = {
+                                        .aborted = true,
+                                };
+
                                 mwifiex_dbg(adapter, WARN, "info: aborting scan\n");
-                                cfg80211_scan_done(priv->scan_request, 1);
+                                cfg80211_scan_done(priv->scan_request, &info);
                                 priv->scan_request = NULL;
                         }
                 }
diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wireless/marvell/mwifiex/main.c
index 0e280f879b58..db4925db39aa 100644
--- a/drivers/net/wireless/marvell/mwifiex/main.c
+++ b/drivers/net/wireless/marvell/mwifiex/main.c
@@ -697,9 +697,13 @@ mwifiex_close(struct net_device *dev)
         struct mwifiex_private *priv = mwifiex_netdev_get_priv(dev);
 
         if (priv->scan_request) {
+                struct cfg80211_scan_info info = {
+                        .aborted = true,
+                };
+
                 mwifiex_dbg(priv->adapter, INFO,
                             "aborting scan on ndo_stop\n");
-                cfg80211_scan_done(priv->scan_request, 1);
+                cfg80211_scan_done(priv->scan_request, &info);
                 priv->scan_request = NULL;
                 priv->scan_aborting = true;
         }
diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c b/drivers/net/wireless/marvell/mwifiex/scan.c
index bc5e52cebce1..fdd749110fcb 100644
--- a/drivers/net/wireless/marvell/mwifiex/scan.c
+++ b/drivers/net/wireless/marvell/mwifiex/scan.c
@@ -1956,9 +1956,13 @@ static void mwifiex_check_next_scan_command(struct mwifiex_private *priv)
                         mwifiex_complete_scan(priv);
 
                 if (priv->scan_request) {
+                        struct cfg80211_scan_info info = {
+                                .aborted = false,
+                        };
+
                         mwifiex_dbg(adapter, INFO,
                                     "info: notifying scan done\n");
-                        cfg80211_scan_done(priv->scan_request, 0);
+                        cfg80211_scan_done(priv->scan_request, &info);
                         priv->scan_request = NULL;
                 } else {
                         priv->scan_aborting = false;
@@ -1977,9 +1981,13 @@ static void mwifiex_check_next_scan_command(struct mwifiex_private *priv)
 
                 if (!adapter->active_scan_triggered) {
                         if (priv->scan_request) {
+                                struct cfg80211_scan_info info = {
+                                        .aborted = true,
+                                };
+
                                 mwifiex_dbg(adapter, INFO,
                                             "info: aborting scan\n");
-                                cfg80211_scan_done(priv->scan_request, 1);
+                                cfg80211_scan_done(priv->scan_request, &info);
                                 priv->scan_request = NULL;
                         } else {
                                 priv->scan_aborting = false;
diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
index 569918c485b4..603c90470225 100644
--- a/drivers/net/wireless/rndis_wlan.c
+++ b/drivers/net/wireless/rndis_wlan.c
@@ -2134,6 +2134,7 @@ static void rndis_get_scan_results(struct work_struct *work)
         struct rndis_wlan_private *priv =
                 container_of(work, struct rndis_wlan_private, scan_work.work);
         struct usbnet *usbdev = priv->usbdev;
+        struct cfg80211_scan_info info = {};
         int ret;
 
         netdev_dbg(usbdev->net, "get_scan_results\n");
@@ -2143,7 +2144,8 @@ static void rndis_get_scan_results(struct work_struct *work)
 
         ret = rndis_check_bssid_list(usbdev, NULL, NULL);
 
-        cfg80211_scan_done(priv->scan_request, ret < 0);
+        info.aborted = ret < 0;
+        cfg80211_scan_done(priv->scan_request, &info);
 
         priv->scan_request = NULL;
 }
@@ -3574,7 +3576,11 @@ static int rndis_wlan_stop(struct usbnet *usbdev)
         flush_workqueue(priv->workqueue);
 
         if (priv->scan_request) {
-                cfg80211_scan_done(priv->scan_request, true);
+                struct cfg80211_scan_info info = {
+                        .aborted = true,
+                };
+
+                cfg80211_scan_done(priv->scan_request, &info);
                 priv->scan_request = NULL;
         }
 
diff --git a/drivers/net/wireless/st/cw1200/scan.c b/drivers/net/wireless/st/cw1200/scan.c
index 983788156bb0..0a0ff7e31f5b 100644
--- a/drivers/net/wireless/st/cw1200/scan.c
+++ b/drivers/net/wireless/st/cw1200/scan.c
@@ -167,6 +167,10 @@ void cw1200_scan_work(struct work_struct *work)
         }
 
         if (!priv->scan.req || (priv->scan.curr == priv->scan.end)) {
+                struct cfg80211_scan_info info = {
+                        .aborted = priv->scan.status ? 1 : 0,
+                };
+
                 if (priv->scan.output_power != priv->output_power)
                         wsm_set_output_power(priv, priv->output_power * 10);
                 if (priv->join_status == CW1200_JOIN_STATUS_STA &&
@@ -188,7 +192,7 @@ void cw1200_scan_work(struct work_struct *work)
                 cw1200_scan_restart_delayed(priv);
                 wsm_unlock_tx(priv);
                 mutex_unlock(&priv->conf_mutex);
-                ieee80211_scan_completed(priv->hw, priv->scan.status ? 1 : 0);
+                ieee80211_scan_completed(priv->hw, &info);
                 up(&priv->scan.lock);
                 return;
         } else {
diff --git a/drivers/net/wireless/ti/wl1251/event.c b/drivers/net/wireless/ti/wl1251/event.c
index c98630394a1a..d0593bc1f1a9 100644
--- a/drivers/net/wireless/ti/wl1251/event.c
+++ b/drivers/net/wireless/ti/wl1251/event.c
@@ -36,7 +36,11 @@ static int wl1251_event_scan_complete(struct wl1251 *wl,
                      mbox->scheduled_scan_channels);
 
         if (wl->scanning) {
-                ieee80211_scan_completed(wl->hw, false);
+                struct cfg80211_scan_info info = {
+                        .aborted = false,
+                };
+
+                ieee80211_scan_completed(wl->hw, &info);
                 wl1251_debug(DEBUG_MAC80211, "mac80211 hw scan completed");
                 wl->scanning = false;
                 if (wl->hw->conf.flags & IEEE80211_CONF_IDLE)
diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/ti/wl1251/main.c
index 56384a4e2a35..bbf7604889b7 100644
--- a/drivers/net/wireless/ti/wl1251/main.c
+++ b/drivers/net/wireless/ti/wl1251/main.c
@@ -448,7 +448,11 @@ static void wl1251_op_stop(struct ieee80211_hw *hw)
         WARN_ON(wl->state != WL1251_STATE_ON);
 
         if (wl->scanning) {
-                ieee80211_scan_completed(wl->hw, true);
+                struct cfg80211_scan_info info = {
+                        .aborted = true,
+                };
+
+                ieee80211_scan_completed(wl->hw, &info);
                 wl->scanning = false;
         }
 
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 10fd24c28ece..69267d592504 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -2615,6 +2615,10 @@ static void __wl1271_op_remove_interface(struct wl1271 *wl,
 
         if (wl->scan.state != WL1271_SCAN_STATE_IDLE &&
             wl->scan_wlvif == wlvif) {
+                struct cfg80211_scan_info info = {
+                        .aborted = true,
+                };
+
                 /*
                  * Rearm the tx watchdog just before idling scan. This
                  * prevents just-finished scans from triggering the watchdog
@@ -2625,7 +2629,7 @@ static void __wl1271_op_remove_interface(struct wl1271 *wl,
                 memset(wl->scan.scanned_ch, 0, sizeof(wl->scan.scanned_ch));
                 wl->scan_wlvif = NULL;
                 wl->scan.req = NULL;
-                ieee80211_scan_completed(wl->hw, true);
+                ieee80211_scan_completed(wl->hw, &info);
         }
 
         if (wl->sched_vif == wlvif)
@@ -3649,6 +3653,9 @@ static void wl1271_op_cancel_hw_scan(struct ieee80211_hw *hw,
 {
         struct wl1271 *wl = hw->priv;
         struct wl12xx_vif *wlvif = wl12xx_vif_to_data(vif);
+        struct cfg80211_scan_info info = {
+                .aborted = true,
+        };
         int ret;
 
         wl1271_debug(DEBUG_MAC80211, "mac80211 cancel hw scan");
@@ -3681,7 +3688,7 @@ static void wl1271_op_cancel_hw_scan(struct ieee80211_hw *hw,
         memset(wl->scan.scanned_ch, 0, sizeof(wl->scan.scanned_ch));
         wl->scan_wlvif = NULL;
         wl->scan.req = NULL;
-        ieee80211_scan_completed(wl->hw, true);
+        ieee80211_scan_completed(wl->hw, &info);
 
 out_sleep:
         wl1271_ps_elp_sleep(wl);
diff --git a/drivers/net/wireless/ti/wlcore/scan.c b/drivers/net/wireless/ti/wlcore/scan.c
index 23343643207a..5612f5916b4e 100644
--- a/drivers/net/wireless/ti/wlcore/scan.c
+++ b/drivers/net/wireless/ti/wlcore/scan.c
@@ -36,6 +36,9 @@ void wl1271_scan_complete_work(struct work_struct *work)
         struct delayed_work *dwork;
         struct wl1271 *wl;
         struct wl12xx_vif *wlvif;
+        struct cfg80211_scan_info info = {
+                .aborted = false,
+        };
         int ret;
 
         dwork = to_delayed_work(work);
@@ -82,7 +85,7 @@ void wl1271_scan_complete_work(struct work_struct *work)
 
         wlcore_cmd_regdomain_config_locked(wl);
 
-        ieee80211_scan_completed(wl->hw, false);
+        ieee80211_scan_completed(wl->hw, &info);
 
 out:
         mutex_unlock(&wl->mutex);
diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
index 0da559d929bc..d0ba3778990e 100644
--- a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
@@ -1256,10 +1256,15 @@ void rtw_cfg80211_indicate_scan_done(struct rtw_wdev_priv *pwdev_priv,
                 DBG_8723A("%s with scan req\n", __func__);
 
                 if (pwdev_priv->scan_request->wiphy !=
-                    pwdev_priv->rtw_wdev->wiphy)
+                    pwdev_priv->rtw_wdev->wiphy) {
                         DBG_8723A("error wiphy compare\n");
-                else
-                        cfg80211_scan_done(pwdev_priv->scan_request, aborted);
+                } else {
+                        struct cfg80211_scan_info info = {
+                                .aborted = aborted,
+                        };
+
+                        cfg80211_scan_done(pwdev_priv->scan_request, &info);
+                }
 
                 pwdev_priv->scan_request = NULL;
         } else {
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index 51aff4ff7d7c..a0d8e22e575b 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -454,7 +454,11 @@ static void CfgScanResult(enum scan_event scan_event,
                         mutex_lock(&priv->scan_req_lock);
 
                         if (priv->pstrScanReq) {
-                                cfg80211_scan_done(priv->pstrScanReq, false);
+                                struct cfg80211_scan_info info = {
+                                        .aborted = false,
+                                };
+
+                                cfg80211_scan_done(priv->pstrScanReq, &info);
                                 priv->u32RcvdChCount = 0;
                                 priv->bCfgScanning = false;
                                 priv->pstrScanReq = NULL;
@@ -464,10 +468,14 @@ static void CfgScanResult(enum scan_event scan_event,
                         mutex_lock(&priv->scan_req_lock);
 
                         if (priv->pstrScanReq) {
+                                struct cfg80211_scan_info info = {
+                                        .aborted = false,
+                                };
+
                                 update_scan_time();
                                 refresh_scan(priv, 1, false);
 
-                                cfg80211_scan_done(priv->pstrScanReq, false);
+                                cfg80211_scan_done(priv->pstrScanReq, &info);
                                 priv->bCfgScanning = false;
                                 priv->pstrScanReq = NULL;
                         }
diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index a6e6fb9f42e1..f46dfe6b24e8 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -338,6 +338,8 @@ static int prism2_scan(struct wiphy *wiphy,
         struct p80211msg_dot11req_scan msg1;
         struct p80211msg_dot11req_scan_results msg2;
         struct cfg80211_bss *bss;
+        struct cfg80211_scan_info info = {};
+
         int result;
         int err = 0;
         int numbss = 0;
@@ -440,7 +442,8 @@ static int prism2_scan(struct wiphy *wiphy,
                 err = prism2_result2err(msg2.resultcode.data);
 
 exit:
-        cfg80211_scan_done(request, err ? 1 : 0);
+        info.aborted = !!(err);
+        cfg80211_scan_done(request, &info);
         priv->scan_request = NULL;
         return err;
 }