Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

Pull networking fixes from David Miller:
 "Mostly fixing some light fallout from the changes that went into the
  merge window.

   1) Fix memory leaks on network namespace teardown in netfilter, from
      Liping Zhang.

   2) When comparing ipv6 nexthops, we have to take the lightweight
      tunnel state into account as well. From David Ahern.

   3) Fix socket option object length check in the new TLS code, from
      Matthias Rosenfelder.

   4) Fix memory leak in nfp driver flower support, from Jakub Kicinski.

   5) Several netlink attribute validation fixes in cfg80211, from
      Srinivas Dasari.

   6) Fix context array leak in virtio_net, from Jason Wang.

   7) SKB use after free in hns driver, from Yusheng Lin.

   8) Fix socket leak on accept() in RDS, from Sowmini Varadhan. Also
      add a WARN_ON() to sock_graft() so other protocol stacks don't
      trip over this as well"

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net: (26 commits)
  net: ethernet: mediatek: remove useless code in mtk_probe()
  mpls: fix uninitialized in_label var warning in mpls_getroute
  doc: SKB_GSO_[IPIP|SIT] have been replaced
  bonding: avoid NETDEV_CHANGEMTU event when unregistering slave
  net/sock: add WARN_ON(parent->sk) in sock_graft()
  rds: tcp: use sock_create_lite() to create the accept socket
  net: hns: Fix a skb used after free bug
  net: hns: Fix a wrong op phy C45 code
  net: macb: Adding Support for Jumbo Frames up to 10240 Bytes in SAMA5D3
  net: Update networking MAINTAINERS entry.
  virtio-net: fix leaking of ctx array
  cfg80211: Validate frequencies nested in NL80211_ATTR_SCAN_FREQUENCIES
  cfg80211: Define nla_policy for NL80211_ATTR_LOCAL_MESH_POWER_MODE
  cfg80211: Check if NAN service ID is of expected size
  cfg80211: Check if PMKID attribute is of expected size
  arcnet: com20020-pci: Fix an error handling path in 'com20020pci_probe()'
  nfp: flower: add missing clean up call to avoid memory leaks
  vrf: fix bug_on triggered by rx when destroying a vrf
  ptp: dte: Use LL suffix for 64-bit constants
  sctp: set the value of flowi6_oif to sk_bound_dev_if to make sctp_v6_get_dst to find the correct route entry.
  ...

13 files changed, 40 insertions, 38 deletions

diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c
index 2d956cb59d06..01cab9548785 100644
--- a/drivers/net/arcnet/com20020-pci.c
+++ b/drivers/net/arcnet/com20020-pci.c
@@ -225,8 +225,10 @@ static int com20020pci_probe(struct pci_dev *pdev,
 
                 card = devm_kzalloc(&pdev->dev, sizeof(struct com20020_dev),
                                     GFP_KERNEL);
-                if (!card)
-                        return -ENOMEM;
+                if (!card) {
+                        ret = -ENOMEM;
+                        goto out_port;
+                }
 
                 card->index = i;
                 card->pci_priv = priv;
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 2865f31c6076..14ff622190a5 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1820,7 +1820,7 @@ err_undo_flags:
  */
 static int __bond_release_one(struct net_device *bond_dev,
                               struct net_device *slave_dev,
-                              bool all)
+                              bool all, bool unregister)
 {
         struct bonding *bond = netdev_priv(bond_dev);
         struct slave *slave, *oldcurrent;
@@ -1965,7 +1965,10 @@ static int __bond_release_one(struct net_device *bond_dev,
                 dev_set_mac_address(slave_dev, (struct sockaddr *)&ss);
         }
 
-        dev_set_mtu(slave_dev, slave->original_mtu);
+        if (unregister)
+                __dev_set_mtu(slave_dev, slave->original_mtu);
+        else
+                dev_set_mtu(slave_dev, slave->original_mtu);
 
         slave_dev->priv_flags &= ~IFF_BONDING;
 
@@ -1977,7 +1980,7 @@ static int __bond_release_one(struct net_device *bond_dev,
 /* A wrapper used because of ndo_del_link */
 int bond_release(struct net_device *bond_dev, struct net_device *slave_dev)
 {
-        return __bond_release_one(bond_dev, slave_dev, false);
+        return __bond_release_one(bond_dev, slave_dev, false, false);
 }
 
 /* First release a slave and then destroy the bond if no more slaves are left.
@@ -1989,7 +1992,7 @@ static int  bond_release_and_destroy(struct net_device *bond_dev,
         struct bonding *bond = netdev_priv(bond_dev);
         int ret;
 
-        ret = bond_release(bond_dev, slave_dev);
+        ret = __bond_release_one(bond_dev, slave_dev, false, true);
         if (ret == 0 && !bond_has_slaves(bond)) {
                 bond_dev->priv_flags |= IFF_DISABLE_NETPOLL;
                 netdev_info(bond_dev, "Destroying bond %s\n",
@@ -3060,7 +3063,7 @@ static int bond_slave_netdev_event(unsigned long event,
                 if (bond_dev->type != ARPHRD_ETHER)
                         bond_release_and_destroy(bond_dev, slave_dev);
                 else
-                        bond_release(bond_dev, slave_dev);
+                        __bond_release_one(bond_dev, slave_dev, false, true);
                 break;
         case NETDEV_UP:
         case NETDEV_CHANGE:
@@ -4252,7 +4255,7 @@ static void bond_uninit(struct net_device *bond_dev)
 
         /* Release the bonded slaves */
         bond_for_each_slave(bond, slave, iter)
-                __bond_release_one(bond_dev, slave->dev, true);
+                __bond_release_one(bond_dev, slave->dev, true, true);
         netdev_info(bond_dev, "Released all slaves\n");
 
         arr = rtnl_dereference(bond->slave_arr);
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index e69ebdd65658..26d25749c3e4 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -3314,10 +3314,11 @@ static const struct macb_config sama5d2_config = {
 
 static const struct macb_config sama5d3_config = {
         .caps = MACB_CAPS_SG_DISABLED | MACB_CAPS_GIGABIT_MODE_AVAILABLE
-              | MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII,
+              | MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII | MACB_CAPS_JUMBO,
         .dma_burst_length = 16,
         .clk_init = macb_clk_init,
         .init = macb_init,
+        .jumbo_max_len = 10240,
 };
 
 static const struct macb_config sama5d4_config = {
diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c
index 6081c3132135..4b0ca9fb2cb4 100644
--- a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c
+++ b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c
@@ -221,7 +221,7 @@ static int cn23xx_pf_soft_reset(struct octeon_device *oct)
         /* Wait for 100ms as Octeon resets. */
         mdelay(100);
 
-        if (octeon_read_csr64(oct, CN23XX_SLI_SCRATCH1) == 0x1234ULL) {
+        if (octeon_read_csr64(oct, CN23XX_SLI_SCRATCH1)) {
                 dev_err(&oct->pci_dev->dev, "OCTEON[%d]: Soft reset failed\n",
                         oct->octeon_id);
                 return 1;
diff --git a/drivers/net/ethernet/cavium/liquidio/cn66xx_device.c b/drivers/net/ethernet/cavium/liquidio/cn66xx_device.c
index b28253c96d97..2df7440f58df 100644
--- a/drivers/net/ethernet/cavium/liquidio/cn66xx_device.c
+++ b/drivers/net/ethernet/cavium/liquidio/cn66xx_device.c
@@ -44,7 +44,7 @@ int lio_cn6xxx_soft_reset(struct octeon_device *oct)
         /* Wait for 10ms as Octeon resets. */
         mdelay(100);
 
-        if (octeon_read_csr64(oct, CN6XXX_SLI_SCRATCH1) == 0x1234ULL) {
+        if (octeon_read_csr64(oct, CN6XXX_SLI_SCRATCH1)) {
                 dev_err(&oct->pci_dev->dev, "Soft reset failed\n");
                 return 1;
         }
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
index c6700b91a2df..fe166e0f6781 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
@@ -300,9 +300,9 @@ static void fill_tso_desc(struct hnae_ring *ring, void *priv,
                              mtu);
 }
 
-int hns_nic_net_xmit_hw(struct net_device *ndev,
-                        struct sk_buff *skb,
-                        struct hns_nic_ring_data *ring_data)
+netdev_tx_t hns_nic_net_xmit_hw(struct net_device *ndev,
+                                struct sk_buff *skb,
+                                struct hns_nic_ring_data *ring_data)
 {
         struct hns_nic_priv *priv = netdev_priv(ndev);
         struct hnae_ring *ring = ring_data->ring;
@@ -361,6 +361,10 @@ int hns_nic_net_xmit_hw(struct net_device *ndev,
         dev_queue = netdev_get_tx_queue(ndev, skb->queue_mapping);
         netdev_tx_sent_queue(dev_queue, skb->len);
 
+        netif_trans_update(ndev);
+        ndev->stats.tx_bytes += skb->len;
+        ndev->stats.tx_packets++;
+
         wmb(); /* commit all data before submit */
         assert(skb->queue_mapping < priv->ae_handle->q_num);
         hnae_queue_xmit(priv->ae_handle->qs[skb->queue_mapping], buf_num);
@@ -1469,17 +1473,11 @@ static netdev_tx_t hns_nic_net_xmit(struct sk_buff *skb,
                                     struct net_device *ndev)
 {
         struct hns_nic_priv *priv = netdev_priv(ndev);
-        int ret;
 
         assert(skb->queue_mapping < ndev->ae_handle->q_num);
-        ret = hns_nic_net_xmit_hw(ndev, skb,
-                                  &tx_ring_data(priv, skb->queue_mapping));
-        if (ret == NETDEV_TX_OK) {
-                netif_trans_update(ndev);
-                ndev->stats.tx_bytes += skb->len;
-                ndev->stats.tx_packets++;
-        }
-        return (netdev_tx_t)ret;
+
+        return hns_nic_net_xmit_hw(ndev, skb,
+                                   &tx_ring_data(priv, skb->queue_mapping));
 }
 
 static void hns_nic_drop_rx_fetch(struct hns_nic_ring_data *ring_data,
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.h b/drivers/net/ethernet/hisilicon/hns/hns_enet.h
index 1b83232082b2..9cb4c7884201 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_enet.h
+++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.h
@@ -92,8 +92,8 @@ void hns_ethtool_set_ops(struct net_device *ndev);
 void hns_nic_net_reset(struct net_device *ndev);
 void hns_nic_net_reinit(struct net_device *netdev);
 int hns_nic_init_phy(struct net_device *ndev, struct hnae_handle *h);
-int hns_nic_net_xmit_hw(struct net_device *ndev,
-                        struct sk_buff *skb,
-                        struct hns_nic_ring_data *ring_data);
+netdev_tx_t hns_nic_net_xmit_hw(struct net_device *ndev,
+                                struct sk_buff *skb,
+                                struct hns_nic_ring_data *ring_data);
 
 #endif  /**__HNS_ENET_H */
diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c
index e5221d95afe1..017e08452d8c 100644
--- a/drivers/net/ethernet/hisilicon/hns_mdio.c
+++ b/drivers/net/ethernet/hisilicon/hns_mdio.c
@@ -261,7 +261,7 @@ static int hns_mdio_write(struct mii_bus *bus,
 
                 /* config the data needed writing */
                 cmd_reg_cfg = devad;
-                op = MDIO_C45_WRITE_ADDR;
+                op = MDIO_C45_WRITE_DATA;
         }
 
         MDIO_SET_REG_FIELD(mdio_dev, MDIO_WDATA_REG, MDIO_WDATA_DATA_M,
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 41a5c5d2ac89..b3d0c2e6347a 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -2401,15 +2401,10 @@ static int mtk_probe(struct platform_device *pdev)
 {
         struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
         struct device_node *mac_np;
-        const struct of_device_id *match;
-        struct mtk_soc_data *soc;
         struct mtk_eth *eth;
         int err;
         int i;
 
-        match = of_match_device(of_mtk_match, &pdev->dev);
-        soc = (struct mtk_soc_data *)match->data;
-
         eth = devm_kzalloc(&pdev->dev, sizeof(*eth), GFP_KERNEL);
         if (!eth)
                 return -ENOMEM;
diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c b/drivers/net/ethernet/netronome/nfp/flower/main.c
index fc10f27e0a0c..6a65c8b33807 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/main.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/main.c
@@ -356,6 +356,7 @@ err_free_app_priv:
 
 static void nfp_flower_clean(struct nfp_app *app)
 {
+        nfp_flower_metadata_cleanup(app);
         vfree(app->priv);
         app->priv = NULL;
 }
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 2e69bcdc5b07..99a26a9efec1 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -2229,6 +2229,7 @@ static int virtnet_find_vqs(struct virtnet_info *vi)
         kfree(names);
         kfree(callbacks);
         kfree(vqs);
+        kfree(ctx);
 
         return 0;
 
diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c
index f4d0054981c6..8a1eaf3c302a 100644
--- a/drivers/net/vrf.c
+++ b/drivers/net/vrf.c
@@ -922,15 +922,10 @@ static int vrf_del_slave(struct net_device *dev, struct net_device *port_dev)
 static void vrf_dev_uninit(struct net_device *dev)
 {
         struct net_vrf *vrf = netdev_priv(dev);
-        struct net_device *port_dev;
-        struct list_head *iter;
 
         vrf_rtable_release(dev, vrf);
         vrf_rt6_release(dev, vrf);
 
-        netdev_for_each_lower_dev(dev, port_dev, iter)
-                vrf_del_slave(dev, port_dev);
-
         free_percpu(dev->dstats);
         dev->dstats = NULL;
 }
@@ -1386,6 +1381,12 @@ static int vrf_validate(struct nlattr *tb[], struct nlattr *data[],
 
 static void vrf_dellink(struct net_device *dev, struct list_head *head)
 {
+        struct net_device *port_dev;
+        struct list_head *iter;
+
+        netdev_for_each_lower_dev(dev, port_dev, iter)
+                vrf_del_slave(dev, port_dev);
+
         unregister_netdevice_queue(dev, head);
 }
 
diff --git a/drivers/ptp/ptp_dte.c b/drivers/ptp/ptp_dte.c
index 00145a3f1e70..faf6f7a83713 100644
--- a/drivers/ptp/ptp_dte.c
+++ b/drivers/ptp/ptp_dte.c
@@ -40,7 +40,7 @@
 #define DTE_WRAP_AROUND_NSEC_SHIFT 44
 
 /* 44 bits NCO */
-#define DTE_NCO_MAX_NS  0xFFFFFFFFFFF
+#define DTE_NCO_MAX_NS  0xFFFFFFFFFFFLL
 
 /* 125MHz with 3.29 reg cfg */
 #define DTE_PPB_ADJ(ppb) (u32)(div64_u64((((u64)abs(ppb) * BIT(28)) +\