aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorChristian König <christian.koenig@amd.com>2017-07-26 11:02:52 -0400
committerAlex Deucher <alexander.deucher@amd.com>2017-08-15 14:45:53 -0400
commit7ecc245a8ce32ffcaa6a3e5795e0b14db8e076fc (patch)
tree204ca80c53ffa1f78696857021c5c65bc166792a /drivers
parentf5e1c740afb6fec8969234a066b1628246a6a08d (diff)
drm/amdgpu: consistent use u64_to_user_ptr
Instead of open coding the conversion from u64 to pointers. Signed-off-by: Christian König <christian.koenig@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c2
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c8
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c2
3 files changed, 6 insertions, 6 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
index d324e1c24028..ccd7697792ab 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c
@@ -270,7 +270,7 @@ int amdgpu_bo_list_ioctl(struct drm_device *dev, void *data,
270 struct amdgpu_fpriv *fpriv = filp->driver_priv; 270 struct amdgpu_fpriv *fpriv = filp->driver_priv;
271 union drm_amdgpu_bo_list *args = data; 271 union drm_amdgpu_bo_list *args = data;
272 uint32_t handle = args->in.list_handle; 272 uint32_t handle = args->in.list_handle;
273 const void __user *uptr = (const void*)(uintptr_t)args->in.bo_info_ptr; 273 const void __user *uptr = u64_to_user_ptr(args->in.bo_info_ptr);
274 274
275 struct drm_amdgpu_bo_list_entry *info; 275 struct drm_amdgpu_bo_list_entry *info;
276 struct amdgpu_bo_list *list; 276 struct amdgpu_bo_list *list;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index 33789510e663..381b4f99648d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
@@ -90,7 +90,7 @@ static int amdgpu_cs_parser_init(struct amdgpu_cs_parser *p, void *data)
90 } 90 }
91 91
92 /* get chunks */ 92 /* get chunks */
93 chunk_array_user = (uint64_t __user *)(uintptr_t)(cs->in.chunks); 93 chunk_array_user = u64_to_user_ptr(cs->in.chunks);
94 if (copy_from_user(chunk_array, chunk_array_user, 94 if (copy_from_user(chunk_array, chunk_array_user,
95 sizeof(uint64_t)*cs->in.num_chunks)) { 95 sizeof(uint64_t)*cs->in.num_chunks)) {
96 ret = -EFAULT; 96 ret = -EFAULT;
@@ -110,7 +110,7 @@ static int amdgpu_cs_parser_init(struct amdgpu_cs_parser *p, void *data)
110 struct drm_amdgpu_cs_chunk user_chunk; 110 struct drm_amdgpu_cs_chunk user_chunk;
111 uint32_t __user *cdata; 111 uint32_t __user *cdata;
112 112
113 chunk_ptr = (void __user *)(uintptr_t)chunk_array[i]; 113 chunk_ptr = u64_to_user_ptr(chunk_array[i]);
114 if (copy_from_user(&user_chunk, chunk_ptr, 114 if (copy_from_user(&user_chunk, chunk_ptr,
115 sizeof(struct drm_amdgpu_cs_chunk))) { 115 sizeof(struct drm_amdgpu_cs_chunk))) {
116 ret = -EFAULT; 116 ret = -EFAULT;
@@ -121,7 +121,7 @@ static int amdgpu_cs_parser_init(struct amdgpu_cs_parser *p, void *data)
121 p->chunks[i].length_dw = user_chunk.length_dw; 121 p->chunks[i].length_dw = user_chunk.length_dw;
122 122
123 size = p->chunks[i].length_dw; 123 size = p->chunks[i].length_dw;
124 cdata = (void __user *)(uintptr_t)user_chunk.chunk_data; 124 cdata = u64_to_user_ptr(user_chunk.chunk_data);
125 125
126 p->chunks[i].kdata = kvmalloc_array(size, sizeof(uint32_t), GFP_KERNEL); 126 p->chunks[i].kdata = kvmalloc_array(size, sizeof(uint32_t), GFP_KERNEL);
127 if (p->chunks[i].kdata == NULL) { 127 if (p->chunks[i].kdata == NULL) {
@@ -1437,7 +1437,7 @@ int amdgpu_cs_wait_fences_ioctl(struct drm_device *dev, void *data,
1437 if (fences == NULL) 1437 if (fences == NULL)
1438 return -ENOMEM; 1438 return -ENOMEM;
1439 1439
1440 fences_user = (void __user *)(uintptr_t)(wait->in.fences); 1440 fences_user = u64_to_user_ptr(wait->in.fences);
1441 if (copy_from_user(fences, fences_user, 1441 if (copy_from_user(fences, fences_user,
1442 sizeof(struct drm_amdgpu_fence) * fence_count)) { 1442 sizeof(struct drm_amdgpu_fence) * fence_count)) {
1443 r = -EFAULT; 1443 r = -EFAULT;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index 917ac5e074a0..88085e7f72de 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
@@ -689,7 +689,7 @@ int amdgpu_gem_op_ioctl(struct drm_device *dev, void *data,
689 switch (args->op) { 689 switch (args->op) {
690 case AMDGPU_GEM_OP_GET_GEM_CREATE_INFO: { 690 case AMDGPU_GEM_OP_GET_GEM_CREATE_INFO: {
691 struct drm_amdgpu_gem_create_in info; 691 struct drm_amdgpu_gem_create_in info;
692 void __user *out = (void __user *)(uintptr_t)args->value; 692 void __user *out = u64_to_user_ptr(args->value);
693 693
694 info.bo_size = robj->gem_base.size; 694 info.bo_size = robj->gem_base.size;
695 info.alignment = robj->tbo.mem.page_alignment << PAGE_SHIFT; 695 info.alignment = robj->tbo.mem.page_alignment << PAGE_SHIFT;