diff options
author | Junwei Zhang <Jerry.Zhang@amd.com> | 2017-01-23 03:30:38 -0500 |
---|---|---|
committer | Alex Deucher <alexander.deucher@amd.com> | 2017-01-27 12:20:37 -0500 |
commit | 50ddc75e32bba7cce994d530ec27aec697a372f8 (patch) | |
tree | 3d0bad738e7f4f5275b175ab45b8dd3f4b245934 /drivers | |
parent | a2e2f29970aa1e53219e3499382c41d61c8959f8 (diff) |
drm/amd/amdgpu: remove the uncessary parameter for ib scheduler
Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 4 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 3 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 4 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/amd/amdgpu/si_dma.c | 2 |
13 files changed, 17 insertions, 18 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index a0728ff8c80f..179f01d44d14 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h | |||
@@ -906,8 +906,8 @@ int amdgpu_ib_get(struct amdgpu_device *adev, struct amdgpu_vm *vm, | |||
906 | void amdgpu_ib_free(struct amdgpu_device *adev, struct amdgpu_ib *ib, | 906 | void amdgpu_ib_free(struct amdgpu_device *adev, struct amdgpu_ib *ib, |
907 | struct dma_fence *f); | 907 | struct dma_fence *f); |
908 | int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs, | 908 | int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs, |
909 | struct amdgpu_ib *ib, struct dma_fence *last_vm_update, | 909 | struct amdgpu_ib *ibs, struct amdgpu_job *job, |
910 | struct amdgpu_job *job, struct dma_fence **f); | 910 | struct dma_fence **f); |
911 | int amdgpu_ib_pool_init(struct amdgpu_device *adev); | 911 | int amdgpu_ib_pool_init(struct amdgpu_device *adev); |
912 | void amdgpu_ib_pool_fini(struct amdgpu_device *adev); | 912 | void amdgpu_ib_pool_fini(struct amdgpu_device *adev); |
913 | int amdgpu_ib_ring_tests(struct amdgpu_device *adev); | 913 | int amdgpu_ib_ring_tests(struct amdgpu_device *adev); |
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c index dcf1d8aa35ea..e02a70dd37b5 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | |||
@@ -116,8 +116,8 @@ void amdgpu_ib_free(struct amdgpu_device *adev, struct amdgpu_ib *ib, | |||
116 | * to SI there was just a DE IB. | 116 | * to SI there was just a DE IB. |
117 | */ | 117 | */ |
118 | int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs, | 118 | int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs, |
119 | struct amdgpu_ib *ibs, struct dma_fence *last_vm_update, | 119 | struct amdgpu_ib *ibs, struct amdgpu_job *job, |
120 | struct amdgpu_job *job, struct dma_fence **f) | 120 | struct dma_fence **f) |
121 | { | 121 | { |
122 | struct amdgpu_device *adev = ring->adev; | 122 | struct amdgpu_device *adev = ring->adev; |
123 | struct amdgpu_ib *ib = &ibs[0]; | 123 | struct amdgpu_ib *ib = &ibs[0]; |
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c index a0de6286c453..86a12424c162 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | |||
@@ -170,8 +170,7 @@ static struct dma_fence *amdgpu_job_run(struct amd_sched_job *sched_job) | |||
170 | BUG_ON(amdgpu_sync_peek_fence(&job->sync, NULL)); | 170 | BUG_ON(amdgpu_sync_peek_fence(&job->sync, NULL)); |
171 | 171 | ||
172 | trace_amdgpu_sched_run_job(job); | 172 | trace_amdgpu_sched_run_job(job); |
173 | r = amdgpu_ib_schedule(job->ring, job->num_ibs, job->ibs, | 173 | r = amdgpu_ib_schedule(job->ring, job->num_ibs, job->ibs, job, &fence); |
174 | job->sync.last_vm_update, job, &fence); | ||
175 | if (r) | 174 | if (r) |
176 | DRM_ERROR("Error scheduling IBs (%d)\n", r); | 175 | DRM_ERROR("Error scheduling IBs (%d)\n", r); |
177 | 176 | ||
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index eebfc1d19b29..10e9b690676e 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | |||
@@ -1294,7 +1294,7 @@ int amdgpu_copy_buffer(struct amdgpu_ring *ring, | |||
1294 | WARN_ON(job->ibs[0].length_dw > num_dw); | 1294 | WARN_ON(job->ibs[0].length_dw > num_dw); |
1295 | if (direct_submit) { | 1295 | if (direct_submit) { |
1296 | r = amdgpu_ib_schedule(ring, job->num_ibs, job->ibs, | 1296 | r = amdgpu_ib_schedule(ring, job->num_ibs, job->ibs, |
1297 | NULL, NULL, fence); | 1297 | NULL, fence); |
1298 | job->fence = dma_fence_get(*fence); | 1298 | job->fence = dma_fence_get(*fence); |
1299 | if (r) | 1299 | if (r) |
1300 | DRM_ERROR("Error scheduling IBs (%d)\n", r); | 1300 | DRM_ERROR("Error scheduling IBs (%d)\n", r); |
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c index 326b7f5a79ff..6f62ac473064 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | |||
@@ -976,7 +976,7 @@ static int amdgpu_uvd_send_msg(struct amdgpu_ring *ring, struct amdgpu_bo *bo, | |||
976 | ib->length_dw = 16; | 976 | ib->length_dw = 16; |
977 | 977 | ||
978 | if (direct) { | 978 | if (direct) { |
979 | r = amdgpu_ib_schedule(ring, 1, ib, NULL, NULL, &f); | 979 | r = amdgpu_ib_schedule(ring, 1, ib, NULL, &f); |
980 | job->fence = dma_fence_get(f); | 980 | job->fence = dma_fence_get(f); |
981 | if (r) | 981 | if (r) |
982 | goto err_free; | 982 | goto err_free; |
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c index 8fec802d3908..79bc9c7aad45 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | |||
@@ -455,7 +455,7 @@ int amdgpu_vce_get_create_msg(struct amdgpu_ring *ring, uint32_t handle, | |||
455 | for (i = ib->length_dw; i < ib_size_dw; ++i) | 455 | for (i = ib->length_dw; i < ib_size_dw; ++i) |
456 | ib->ptr[i] = 0x0; | 456 | ib->ptr[i] = 0x0; |
457 | 457 | ||
458 | r = amdgpu_ib_schedule(ring, 1, ib, NULL, NULL, &f); | 458 | r = amdgpu_ib_schedule(ring, 1, ib, NULL, &f); |
459 | job->fence = dma_fence_get(f); | 459 | job->fence = dma_fence_get(f); |
460 | if (r) | 460 | if (r) |
461 | goto err; | 461 | goto err; |
@@ -518,7 +518,7 @@ int amdgpu_vce_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle, | |||
518 | ib->ptr[i] = 0x0; | 518 | ib->ptr[i] = 0x0; |
519 | 519 | ||
520 | if (direct) { | 520 | if (direct) { |
521 | r = amdgpu_ib_schedule(ring, 1, ib, NULL, NULL, &f); | 521 | r = amdgpu_ib_schedule(ring, 1, ib, NULL, &f); |
522 | job->fence = dma_fence_get(f); | 522 | job->fence = dma_fence_get(f); |
523 | if (r) | 523 | if (r) |
524 | goto err; | 524 | goto err; |
diff --git a/drivers/gpu/drm/amd/amdgpu/cik_sdma.c b/drivers/gpu/drm/amd/amdgpu/cik_sdma.c index 4c34dbc7a254..810bba533975 100644 --- a/drivers/gpu/drm/amd/amdgpu/cik_sdma.c +++ b/drivers/gpu/drm/amd/amdgpu/cik_sdma.c | |||
@@ -651,7 +651,7 @@ static int cik_sdma_ring_test_ib(struct amdgpu_ring *ring, long timeout) | |||
651 | ib.ptr[3] = 1; | 651 | ib.ptr[3] = 1; |
652 | ib.ptr[4] = 0xDEADBEEF; | 652 | ib.ptr[4] = 0xDEADBEEF; |
653 | ib.length_dw = 5; | 653 | ib.length_dw = 5; |
654 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, NULL, &f); | 654 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, &f); |
655 | if (r) | 655 | if (r) |
656 | goto err1; | 656 | goto err1; |
657 | 657 | ||
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c index e0132436c76f..b1f4808109d2 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | |||
@@ -1970,7 +1970,7 @@ static int gfx_v6_0_ring_test_ib(struct amdgpu_ring *ring, long timeout) | |||
1970 | ib.ptr[2] = 0xDEADBEEF; | 1970 | ib.ptr[2] = 0xDEADBEEF; |
1971 | ib.length_dw = 3; | 1971 | ib.length_dw = 3; |
1972 | 1972 | ||
1973 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, NULL, &f); | 1973 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, &f); |
1974 | if (r) | 1974 | if (r) |
1975 | goto err2; | 1975 | goto err2; |
1976 | 1976 | ||
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c index cfed6db69b93..e3589b55a1e1 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | |||
@@ -2316,7 +2316,7 @@ static int gfx_v7_0_ring_test_ib(struct amdgpu_ring *ring, long timeout) | |||
2316 | ib.ptr[2] = 0xDEADBEEF; | 2316 | ib.ptr[2] = 0xDEADBEEF; |
2317 | ib.length_dw = 3; | 2317 | ib.length_dw = 3; |
2318 | 2318 | ||
2319 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, NULL, &f); | 2319 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, &f); |
2320 | if (r) | 2320 | if (r) |
2321 | goto err2; | 2321 | goto err2; |
2322 | 2322 | ||
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index ad8430432cbf..35f9cd83b821 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | |||
@@ -826,7 +826,7 @@ static int gfx_v8_0_ring_test_ib(struct amdgpu_ring *ring, long timeout) | |||
826 | ib.ptr[2] = 0xDEADBEEF; | 826 | ib.ptr[2] = 0xDEADBEEF; |
827 | ib.length_dw = 3; | 827 | ib.length_dw = 3; |
828 | 828 | ||
829 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, NULL, &f); | 829 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, &f); |
830 | if (r) | 830 | if (r) |
831 | goto err2; | 831 | goto err2; |
832 | 832 | ||
@@ -1780,7 +1780,7 @@ static int gfx_v8_0_do_edc_gpr_workarounds(struct amdgpu_device *adev) | |||
1780 | ib.ptr[ib.length_dw++] = EVENT_TYPE(7) | EVENT_INDEX(4); | 1780 | ib.ptr[ib.length_dw++] = EVENT_TYPE(7) | EVENT_INDEX(4); |
1781 | 1781 | ||
1782 | /* shedule the ib on the ring */ | 1782 | /* shedule the ib on the ring */ |
1783 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, NULL, &f); | 1783 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, &f); |
1784 | if (r) { | 1784 | if (r) { |
1785 | DRM_ERROR("amdgpu: ib submit failed (%d).\n", r); | 1785 | DRM_ERROR("amdgpu: ib submit failed (%d).\n", r); |
1786 | goto fail; | 1786 | goto fail; |
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c b/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c index fbe74a33899c..896be64b7013 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | |||
@@ -701,7 +701,7 @@ static int sdma_v2_4_ring_test_ib(struct amdgpu_ring *ring, long timeout) | |||
701 | ib.ptr[7] = SDMA_PKT_HEADER_OP(SDMA_OP_NOP); | 701 | ib.ptr[7] = SDMA_PKT_HEADER_OP(SDMA_OP_NOP); |
702 | ib.length_dw = 8; | 702 | ib.length_dw = 8; |
703 | 703 | ||
704 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, NULL, &f); | 704 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, &f); |
705 | if (r) | 705 | if (r) |
706 | goto err1; | 706 | goto err1; |
707 | 707 | ||
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c index 4bb8bec13c47..31375bdde6f1 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | |||
@@ -910,7 +910,7 @@ static int sdma_v3_0_ring_test_ib(struct amdgpu_ring *ring, long timeout) | |||
910 | ib.ptr[7] = SDMA_PKT_NOP_HEADER_OP(SDMA_OP_NOP); | 910 | ib.ptr[7] = SDMA_PKT_NOP_HEADER_OP(SDMA_OP_NOP); |
911 | ib.length_dw = 8; | 911 | ib.length_dw = 8; |
912 | 912 | ||
913 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, NULL, &f); | 913 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, &f); |
914 | if (r) | 914 | if (r) |
915 | goto err1; | 915 | goto err1; |
916 | 916 | ||
diff --git a/drivers/gpu/drm/amd/amdgpu/si_dma.c b/drivers/gpu/drm/amd/amdgpu/si_dma.c index 3dd552ae0b59..9b6524690e74 100644 --- a/drivers/gpu/drm/amd/amdgpu/si_dma.c +++ b/drivers/gpu/drm/amd/amdgpu/si_dma.c | |||
@@ -301,7 +301,7 @@ static int si_dma_ring_test_ib(struct amdgpu_ring *ring, long timeout) | |||
301 | ib.ptr[2] = upper_32_bits(gpu_addr) & 0xff; | 301 | ib.ptr[2] = upper_32_bits(gpu_addr) & 0xff; |
302 | ib.ptr[3] = 0xDEADBEEF; | 302 | ib.ptr[3] = 0xDEADBEEF; |
303 | ib.length_dw = 4; | 303 | ib.length_dw = 4; |
304 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, NULL, &f); | 304 | r = amdgpu_ib_schedule(ring, 1, &ib, NULL, &f); |
305 | if (r) | 305 | if (r) |
306 | goto err1; | 306 | goto err1; |
307 | 307 | ||