diff options
author | Max Gurtovoy <maxg@mellanox.com> | 2017-03-05 17:30:38 -0500 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2017-04-04 11:48:23 -0400 |
commit | 2ca0786d5a66b919acac865b11b51df43f9457a2 (patch) | |
tree | fc19468ef1ca4f5a46c0d9cdbf9339f4f8ad1595 /drivers | |
parent | 64a0ca88eaa66e3d219296b17aa08b78894e42c8 (diff) |
nvmet: use symbolic constants for log identifiers
Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Reviewed-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/nvme/target/admin-cmd.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c index 105ace88d07e..7ddf75b4d1df 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c | |||
@@ -121,7 +121,7 @@ static void nvmet_execute_get_log_page(struct nvmet_req *req) | |||
121 | } | 121 | } |
122 | 122 | ||
123 | switch (req->cmd->get_log_page.lid) { | 123 | switch (req->cmd->get_log_page.lid) { |
124 | case 0x01: | 124 | case NVME_LOG_ERROR: |
125 | /* | 125 | /* |
126 | * We currently never set the More bit in the status field, | 126 | * We currently never set the More bit in the status field, |
127 | * so all error log entries are invalid and can be zeroed out. | 127 | * so all error log entries are invalid and can be zeroed out. |
@@ -129,7 +129,7 @@ static void nvmet_execute_get_log_page(struct nvmet_req *req) | |||
129 | * mandatory log page. | 129 | * mandatory log page. |
130 | */ | 130 | */ |
131 | break; | 131 | break; |
132 | case 0x02: | 132 | case NVME_LOG_SMART: |
133 | /* | 133 | /* |
134 | * XXX: fill out actual smart log | 134 | * XXX: fill out actual smart log |
135 | * | 135 | * |
@@ -149,7 +149,7 @@ static void nvmet_execute_get_log_page(struct nvmet_req *req) | |||
149 | goto err; | 149 | goto err; |
150 | } | 150 | } |
151 | break; | 151 | break; |
152 | case 0x03: | 152 | case NVME_LOG_FW_SLOT: |
153 | /* | 153 | /* |
154 | * We only support a single firmware slot which always is | 154 | * We only support a single firmware slot which always is |
155 | * active, so we can zero out the whole firmware slot log and | 155 | * active, so we can zero out the whole firmware slot log and |
@@ -496,9 +496,9 @@ u16 nvmet_parse_admin_cmd(struct nvmet_req *req) | |||
496 | req->data_len = nvmet_get_log_page_len(cmd); | 496 | req->data_len = nvmet_get_log_page_len(cmd); |
497 | 497 | ||
498 | switch (cmd->get_log_page.lid) { | 498 | switch (cmd->get_log_page.lid) { |
499 | case 0x01: | 499 | case NVME_LOG_ERROR: |
500 | case 0x02: | 500 | case NVME_LOG_SMART: |
501 | case 0x03: | 501 | case NVME_LOG_FW_SLOT: |
502 | req->execute = nvmet_execute_get_log_page; | 502 | req->execute = nvmet_execute_get_log_page; |
503 | return 0; | 503 | return 0; |
504 | } | 504 | } |