diff options
author | Jan Beulich <JBeulich@suse.com> | 2016-10-24 11:03:49 -0400 |
---|---|---|
committer | David Vrabel <david.vrabel@citrix.com> | 2016-10-24 11:08:04 -0400 |
commit | e1e5b3ff41983f506c3cbcf123fe7d682f61a8f1 (patch) | |
tree | 8c2ef836dd61dd49e72389e6f39e332141cec5bf /drivers/xen | |
parent | cb5f7e7c1ded5ff91b18116669c0f43c82bea3db (diff) |
xenbus: prefer list_for_each()
This is more efficient than list_for_each_safe() when list modification
is accompanied by breaking out of the loop.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Diffstat (limited to 'drivers/xen')
-rw-r--r-- | drivers/xen/xenbus/xenbus_dev_frontend.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/xen/xenbus/xenbus_dev_frontend.c b/drivers/xen/xenbus/xenbus_dev_frontend.c index 7487971f9f78..fe60b12de920 100644 --- a/drivers/xen/xenbus/xenbus_dev_frontend.c +++ b/drivers/xen/xenbus/xenbus_dev_frontend.c | |||
@@ -364,7 +364,7 @@ out: | |||
364 | 364 | ||
365 | static int xenbus_write_watch(unsigned msg_type, struct xenbus_file_priv *u) | 365 | static int xenbus_write_watch(unsigned msg_type, struct xenbus_file_priv *u) |
366 | { | 366 | { |
367 | struct watch_adapter *watch, *tmp_watch; | 367 | struct watch_adapter *watch; |
368 | char *path, *token; | 368 | char *path, *token; |
369 | int err, rc; | 369 | int err, rc; |
370 | LIST_HEAD(staging_q); | 370 | LIST_HEAD(staging_q); |
@@ -399,7 +399,7 @@ static int xenbus_write_watch(unsigned msg_type, struct xenbus_file_priv *u) | |||
399 | } | 399 | } |
400 | list_add(&watch->list, &u->watches); | 400 | list_add(&watch->list, &u->watches); |
401 | } else { | 401 | } else { |
402 | list_for_each_entry_safe(watch, tmp_watch, &u->watches, list) { | 402 | list_for_each_entry(watch, &u->watches, list) { |
403 | if (!strcmp(watch->token, token) && | 403 | if (!strcmp(watch->token, token) && |
404 | !strcmp(watch->watch.node, path)) { | 404 | !strcmp(watch->watch.node, path)) { |
405 | unregister_xenbus_watch(&watch->watch); | 405 | unregister_xenbus_watch(&watch->watch); |