diff options
| author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-07-30 18:59:57 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-08-05 13:35:49 -0400 |
| commit | f368ed6088ae9c1fbe1c897bb5f215ce5e63fa1e (patch) | |
| tree | a9ed27128f04f21ed0f205ec94a1ad0dbf746bb4 /drivers/watchdog/ts72xx_wdt.c | |
| parent | 379e4f756b915bcc35958365e5d1326b3b54efce (diff) | |
char: make misc_deregister a void function
With well over 200+ users of this api, there are a mere 12 users that
actually checked the return value of this function. And all of them
really didn't do anything with that information as the system or module
was shutting down no matter what.
So stop pretending like it matters, and just return void from
misc_deregister(). If something goes wrong in the call, you will get a
WARNING splat in the syslog so you know how to fix up your driver.
Other than that, there's nothing that can go wrong.
Cc: Alasdair Kergon <agk@redhat.com>
Cc: Neil Brown <neilb@suse.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Christine Caulfield <ccaulfie@redhat.com>
Cc: David Teigland <teigland@redhat.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
Acked-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/watchdog/ts72xx_wdt.c')
| -rw-r--r-- | drivers/watchdog/ts72xx_wdt.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/watchdog/ts72xx_wdt.c b/drivers/watchdog/ts72xx_wdt.c index 119beb7f6017..4b541934b6c5 100644 --- a/drivers/watchdog/ts72xx_wdt.c +++ b/drivers/watchdog/ts72xx_wdt.c | |||
| @@ -428,7 +428,8 @@ static int ts72xx_wdt_probe(struct platform_device *pdev) | |||
| 428 | 428 | ||
| 429 | static int ts72xx_wdt_remove(struct platform_device *pdev) | 429 | static int ts72xx_wdt_remove(struct platform_device *pdev) |
| 430 | { | 430 | { |
| 431 | return misc_deregister(&ts72xx_wdt_miscdev); | 431 | misc_deregister(&ts72xx_wdt_miscdev); |
| 432 | return 0; | ||
| 432 | } | 433 | } |
| 433 | 434 | ||
| 434 | static struct platform_driver ts72xx_wdt_driver = { | 435 | static struct platform_driver ts72xx_wdt_driver = { |