diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2016-07-19 07:21:56 -0400 |
|---|---|---|
| committer | Wim Van Sebroeck <wim@iguana.be> | 2016-07-25 06:02:43 -0400 |
| commit | cddd74db8d42b953a0612810f07c99e73deab185 (patch) | |
| tree | 8e3e74691aa5ae55351cb63af53c221a6f9c2c4b /drivers/watchdog/pic32-wdt.c | |
| parent | 919edd5119796f1cc3b47f23e7e15cc0f46942ba (diff) | |
watchdog: pic32-wdt: Fix return value check in pic32_wdt_drv_probe()
In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Diffstat (limited to 'drivers/watchdog/pic32-wdt.c')
| -rw-r--r-- | drivers/watchdog/pic32-wdt.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/watchdog/pic32-wdt.c b/drivers/watchdog/pic32-wdt.c index 18174fef5113..e2761068dc6f 100644 --- a/drivers/watchdog/pic32-wdt.c +++ b/drivers/watchdog/pic32-wdt.c | |||
| @@ -183,8 +183,8 @@ static int pic32_wdt_drv_probe(struct platform_device *pdev) | |||
| 183 | return PTR_ERR(wdt->regs); | 183 | return PTR_ERR(wdt->regs); |
| 184 | 184 | ||
| 185 | wdt->rst_base = devm_ioremap(&pdev->dev, PIC32_BASE_RESET, 0x10); | 185 | wdt->rst_base = devm_ioremap(&pdev->dev, PIC32_BASE_RESET, 0x10); |
| 186 | if (IS_ERR(wdt->rst_base)) | 186 | if (!wdt->rst_base) |
| 187 | return PTR_ERR(wdt->rst_base); | 187 | return -ENOMEM; |
| 188 | 188 | ||
| 189 | wdt->clk = devm_clk_get(&pdev->dev, NULL); | 189 | wdt->clk = devm_clk_get(&pdev->dev, NULL); |
| 190 | if (IS_ERR(wdt->clk)) { | 190 | if (IS_ERR(wdt->clk)) { |