diff options
author | David Howells <dhowells@redhat.com> | 2018-10-19 19:57:56 -0400 |
---|---|---|
committer | David Howells <dhowells@redhat.com> | 2018-10-23 19:41:07 -0400 |
commit | aa563d7bca6e882ec2bdae24603c8f016401a144 (patch) | |
tree | 874b10fc11da3178e4630f7a430e1b299d3b3806 /drivers/usb/usbip/usbip_common.c | |
parent | 00e23707442a75b404392cef1405ab4fd498de6b (diff) |
iov_iter: Separate type from direction and use accessor functions
In the iov_iter struct, separate the iterator type from the iterator
direction and use accessor functions to access them in most places.
Convert a bunch of places to use switch-statements to access them rather
then chains of bitwise-AND statements. This makes it easier to add further
iterator types. Also, this can be more efficient as to implement a switch
of small contiguous integers, the compiler can use ~50% fewer compare
instructions than it has to use bitwise-and instructions.
Further, cease passing the iterator type into the iterator setup function.
The iterator function can set that itself. Only the direction is required.
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'drivers/usb/usbip/usbip_common.c')
-rw-r--r-- | drivers/usb/usbip/usbip_common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/usbip/usbip_common.c b/drivers/usb/usbip/usbip_common.c index 9756752c0681..45da3e01c7b0 100644 --- a/drivers/usb/usbip/usbip_common.c +++ b/drivers/usb/usbip/usbip_common.c | |||
@@ -309,7 +309,7 @@ int usbip_recv(struct socket *sock, void *buf, int size) | |||
309 | if (!sock || !buf || !size) | 309 | if (!sock || !buf || !size) |
310 | return -EINVAL; | 310 | return -EINVAL; |
311 | 311 | ||
312 | iov_iter_kvec(&msg.msg_iter, READ|ITER_KVEC, &iov, 1, size); | 312 | iov_iter_kvec(&msg.msg_iter, READ, &iov, 1, size); |
313 | 313 | ||
314 | usbip_dbg_xmit("enter\n"); | 314 | usbip_dbg_xmit("enter\n"); |
315 | 315 | ||