diff options
author | Boris BREZILLON <b.brezillon@overkiz.com> | 2013-12-09 03:51:53 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-12-18 19:30:36 -0500 |
commit | cca2bbb3083de44394cabe7b3e9937d44bcc8e19 (patch) | |
tree | cd9e6204aa642c132c8a032a404495ad9e5f3133 /drivers/usb/host/ohci-at91.c | |
parent | 4d90b819ae4c7ea8fd5e2bb7edc68c0f334be2e4 (diff) |
usb: ohci-at91: replace request_mem_region + ioremap by devm_ioremap_resource
Replace the request_mem_region + ioremap calls by the
devm_ioremap_resource call which does the same things but with device
managed resources.
Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/host/ohci-at91.c')
-rw-r--r-- | drivers/usb/host/ohci-at91.c | 27 |
1 files changed, 6 insertions, 21 deletions
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index 29d2093e3cee..a0153279f36a 100644 --- a/drivers/usb/host/ohci-at91.c +++ b/drivers/usb/host/ohci-at91.c | |||
@@ -154,24 +154,17 @@ static int usb_hcd_at91_probe(const struct hc_driver *driver, | |||
154 | hcd->rsrc_start = pdev->resource[0].start; | 154 | hcd->rsrc_start = pdev->resource[0].start; |
155 | hcd->rsrc_len = resource_size(&pdev->resource[0]); | 155 | hcd->rsrc_len = resource_size(&pdev->resource[0]); |
156 | 156 | ||
157 | if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len, hcd_name)) { | 157 | hcd->regs = devm_ioremap_resource(dev, res); |
158 | pr_debug("request_mem_region failed\n"); | 158 | if (IS_ERR(hcd->regs)) { |
159 | retval = -EBUSY; | 159 | retval = PTR_ERR(hcd->regs); |
160 | goto err1; | 160 | goto err; |
161 | } | ||
162 | |||
163 | hcd->regs = ioremap(hcd->rsrc_start, hcd->rsrc_len); | ||
164 | if (!hcd->regs) { | ||
165 | pr_debug("ioremap failed\n"); | ||
166 | retval = -EIO; | ||
167 | goto err2; | ||
168 | } | 161 | } |
169 | 162 | ||
170 | iclk = clk_get(&pdev->dev, "ohci_clk"); | 163 | iclk = clk_get(&pdev->dev, "ohci_clk"); |
171 | if (IS_ERR(iclk)) { | 164 | if (IS_ERR(iclk)) { |
172 | dev_err(&pdev->dev, "failed to get ohci_clk\n"); | 165 | dev_err(&pdev->dev, "failed to get ohci_clk\n"); |
173 | retval = PTR_ERR(iclk); | 166 | retval = PTR_ERR(iclk); |
174 | goto err3; | 167 | goto err; |
175 | } | 168 | } |
176 | fclk = clk_get(&pdev->dev, "uhpck"); | 169 | fclk = clk_get(&pdev->dev, "uhpck"); |
177 | if (IS_ERR(fclk)) { | 170 | if (IS_ERR(fclk)) { |
@@ -217,13 +210,7 @@ static int usb_hcd_at91_probe(const struct hc_driver *driver, | |||
217 | err4: | 210 | err4: |
218 | clk_put(iclk); | 211 | clk_put(iclk); |
219 | 212 | ||
220 | err3: | 213 | err: |
221 | iounmap(hcd->regs); | ||
222 | |||
223 | err2: | ||
224 | release_mem_region(hcd->rsrc_start, hcd->rsrc_len); | ||
225 | |||
226 | err1: | ||
227 | usb_put_hcd(hcd); | 214 | usb_put_hcd(hcd); |
228 | return retval; | 215 | return retval; |
229 | } | 216 | } |
@@ -246,8 +233,6 @@ static void usb_hcd_at91_remove(struct usb_hcd *hcd, | |||
246 | { | 233 | { |
247 | usb_remove_hcd(hcd); | 234 | usb_remove_hcd(hcd); |
248 | at91_stop_hc(pdev); | 235 | at91_stop_hc(pdev); |
249 | iounmap(hcd->regs); | ||
250 | release_mem_region(hcd->rsrc_start, hcd->rsrc_len); | ||
251 | usb_put_hcd(hcd); | 236 | usb_put_hcd(hcd); |
252 | 237 | ||
253 | if (IS_ENABLED(CONFIG_COMMON_CLK)) | 238 | if (IS_ENABLED(CONFIG_COMMON_CLK)) |