aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/usb/dwc2/platform.c
diff options
context:
space:
mode:
authorDouglas Anderson <dianders@chromium.org>2019-04-16 17:53:49 -0400
committerFelipe Balbi <felipe.balbi@linux.intel.com>2019-05-03 02:13:47 -0400
commitc40cf7705e13d288d900e044c0a2f756e9e4909a (patch)
tree31ab9133f03c69cda3587744766a8ce59a72eddb /drivers/usb/dwc2/platform.c
parentcc389eaabd7082a14e46aaa5a02f87c9eef37d7f (diff)
usb: dwc2: optionally assert phy reset when waking up
On the rk3288 USB host-only port (the one that's not the OTG-enabled port) the PHY can get into a bad state when a wakeup is asserted (not just a wakeup from full system suspend but also a wakeup from autosuspend). We can get the PHY out of its bad state by asserting its "port reset", but unfortunately that seems to assert a reset onto the USB bus so it could confuse things if we don't actually deenumerate / reenumerate the device. We can also get the PHY out of its bad state by fully resetting it using the reset from the CRU (clock reset unit), which does a more full reset. The CRU-based reset appears to actually cause devices on the bus to be removed and reinserted, which fixes the problem (albeit in a hacky way). It's unfortunate that we need to do a full re-enumeration of devices at wakeup time, but this is better than alternative of letting the bus get wedged. Signed-off-by: Douglas Anderson <dianders@chromium.org> Signed-off-by: Yunzhi Li <lyz@rock-chips.com> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'drivers/usb/dwc2/platform.c')
-rw-r--r--drivers/usb/dwc2/platform.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index 9aa9682a5cd2..c01fa8ffc0c8 100644
--- a/drivers/usb/dwc2/platform.c
+++ b/drivers/usb/dwc2/platform.c
@@ -481,6 +481,15 @@ static int dwc2_driver_probe(struct platform_device *dev)
481 hsotg->gadget_enabled = 1; 481 hsotg->gadget_enabled = 1;
482 } 482 }
483 483
484 hsotg->reset_phy_on_wake =
485 of_property_read_bool(dev->dev.of_node,
486 "snps,reset-phy-on-wake");
487 if (hsotg->reset_phy_on_wake && !hsotg->phy) {
488 dev_warn(hsotg->dev,
489 "Quirk reset-phy-on-wake only supports generic PHYs\n");
490 hsotg->reset_phy_on_wake = false;
491 }
492
484 if (hsotg->dr_mode != USB_DR_MODE_PERIPHERAL) { 493 if (hsotg->dr_mode != USB_DR_MODE_PERIPHERAL) {
485 retval = dwc2_hcd_init(hsotg); 494 retval = dwc2_hcd_init(hsotg);
486 if (retval) { 495 if (retval) {