diff options
author | Johan Hovold <johan@kernel.org> | 2016-11-08 07:24:54 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-11-10 08:41:25 -0500 |
commit | 7a3f09846c978e613979d89f99b633b501f202a2 (patch) | |
tree | 35f5f17e109ef5a97ed008bf269127f2175f47d1 /drivers/tty | |
parent | 6f8ada1292904c8299daa019634b3cddcf2a31c3 (diff) |
tty: rocket: fix invalid user-pointer checks
Drop invalid user-pointer checks from custom ioctl handlers.
A NULL-pointer can be valid in user space and copy_to_user() takes care
of sanity checking.
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
-rw-r--r-- | drivers/tty/rocket.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/tty/rocket.c b/drivers/tty/rocket.c index b0cc47c77b40..d66c1edd9892 100644 --- a/drivers/tty/rocket.c +++ b/drivers/tty/rocket.c | |||
@@ -1189,8 +1189,6 @@ static int get_config(struct r_port *info, struct rocket_config __user *retinfo) | |||
1189 | { | 1189 | { |
1190 | struct rocket_config tmp; | 1190 | struct rocket_config tmp; |
1191 | 1191 | ||
1192 | if (!retinfo) | ||
1193 | return -EFAULT; | ||
1194 | memset(&tmp, 0, sizeof (tmp)); | 1192 | memset(&tmp, 0, sizeof (tmp)); |
1195 | mutex_lock(&info->port.mutex); | 1193 | mutex_lock(&info->port.mutex); |
1196 | tmp.line = info->line; | 1194 | tmp.line = info->line; |
@@ -1255,8 +1253,6 @@ static int get_ports(struct r_port *info, struct rocket_ports __user *retports) | |||
1255 | struct rocket_ports tmp; | 1253 | struct rocket_ports tmp; |
1256 | int board; | 1254 | int board; |
1257 | 1255 | ||
1258 | if (!retports) | ||
1259 | return -EFAULT; | ||
1260 | memset(&tmp, 0, sizeof (tmp)); | 1256 | memset(&tmp, 0, sizeof (tmp)); |
1261 | tmp.tty_major = rocket_driver->major; | 1257 | tmp.tty_major = rocket_driver->major; |
1262 | 1258 | ||