diff options
author | Stephen Boyd <swboyd@chromium.org> | 2019-07-30 14:15:44 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-09-04 06:43:49 -0400 |
commit | 1df217868178bde7f4405255416de9547d16c6e8 (patch) | |
tree | 93dcf66d90acc8b7863d351e62706944800f1093 /drivers/tty/serial/sccnxp.c | |
parent | 769d55c523f7ba572d7e7aefa17106e5deff66e0 (diff) |
tty: Remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.
// <smpl>
@@
expression ret;
struct platform_device *E;
@@
ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);
if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>
While we're here, remove braces on if statements that only have one
statement (manually).
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20190730181557.90391-45-swboyd@chromium.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial/sccnxp.c')
-rw-r--r-- | drivers/tty/serial/sccnxp.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/tty/serial/sccnxp.c b/drivers/tty/serial/sccnxp.c index 68a24a14f6b7..d2b77aae42ae 100644 --- a/drivers/tty/serial/sccnxp.c +++ b/drivers/tty/serial/sccnxp.c | |||
@@ -961,7 +961,6 @@ static int sccnxp_probe(struct platform_device *pdev) | |||
961 | if (!s->poll) { | 961 | if (!s->poll) { |
962 | s->irq = platform_get_irq(pdev, 0); | 962 | s->irq = platform_get_irq(pdev, 0); |
963 | if (s->irq < 0) { | 963 | if (s->irq < 0) { |
964 | dev_err(&pdev->dev, "Missing irq resource data\n"); | ||
965 | ret = -ENXIO; | 964 | ret = -ENXIO; |
966 | goto err_out; | 965 | goto err_out; |
967 | } | 966 | } |