target: More core cleanups from AGrover (round 2)

This patch contains the squashed version of second round of target core
cleanups and simplifications and Andy and Co.   It also contains a handful
of fixes to address bugs the original series and other minor cleanups.

Here is the condensed shortlog:

target: Remove unneeded casts to void*
target: Rename get_lun_for_{cmd,tmr} to lookup_{cmd,tmr}_lun
target: Make t_task a member of se_cmd, not a pointer
target: Handle functions returning "-2"
target: Use cmd->se_dev over cmd->se_lun->lun_se_dev
target: Embed qr in struct se_cmd
target: Replace embedded struct se_queue_req with a list_head
target: Rename list_heads that are nodes in struct se_cmd to "*_node"
target: Fold transport_device_setup_cmd() into lookup_{tmr,cmd}_lun()
target: Make t_mem_list and t_mem_list_bidi members of t_task
target: Add comment & cleanup transport_map_sg_to_mem()
target: Remove unneeded checks in transport_free_pages()

(Roland: Fix se_queue_req removal leftovers OOPs)
(nab: Fix transport_lookup_tmr_lun failure case)
(nab: Fix list_empty(&cmd->t_task.t_mem_bidi_list) inversion bugs)

Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

1 files changed, 6 insertions, 6 deletions

diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
index 0c44bc051484..2e7ea7457501 100644
--- a/drivers/target/target_core_file.c
+++ b/drivers/target/target_core_file.c
@@ -223,7 +223,7 @@ static struct se_device *fd_create_virtdevice(
         dev_limits.queue_depth = FD_DEVICE_QUEUE_DEPTH;
 
         dev = transport_add_device_to_core_hba(hba, &fileio_template,
-                                se_dev, dev_flags, (void *)fd_dev,
+                                se_dev, dev_flags, fd_dev,
                                 &dev_limits, "FILEIO", FD_VERSION);
         if (!(dev))
                 goto fail;
@@ -279,7 +279,7 @@ fd_alloc_task(struct se_cmd *cmd)
                 return NULL;
         }
 
-        fd_req->fd_dev = cmd->se_lun->lun_se_dev->dev_ptr;
+        fd_req->fd_dev = cmd->se_dev->dev_ptr;
 
         return &fd_req->fd_task;
 }
@@ -377,7 +377,7 @@ static void fd_emulate_sync_cache(struct se_task *task)
         struct se_cmd *cmd = task->task_se_cmd;
         struct se_device *dev = cmd->se_dev;
         struct fd_dev *fd_dev = dev->dev_ptr;
-        int immed = (cmd->t_task->t_task_cdb[1] & 0x2);
+        int immed = (cmd->t_task.t_task_cdb[1] & 0x2);
         loff_t start, end;
         int ret;
 
@@ -391,11 +391,11 @@ static void fd_emulate_sync_cache(struct se_task *task)
         /*
          * Determine if we will be flushing the entire device.
          */
-        if (cmd->t_task->t_task_lba == 0 && cmd->data_length == 0) {
+        if (cmd->t_task.t_task_lba == 0 && cmd->data_length == 0) {
                 start = 0;
                 end = LLONG_MAX;
         } else {
-                start = cmd->t_task->t_task_lba * dev->se_sub_dev->se_dev_attrib.block_size;
+                start = cmd->t_task.t_task_lba * dev->se_sub_dev->se_dev_attrib.block_size;
                 if (cmd->data_length)
                         end = start + cmd->data_length;
                 else
@@ -475,7 +475,7 @@ static int fd_do_task(struct se_task *task)
                 if (ret > 0 &&
                     dev->se_sub_dev->se_dev_attrib.emulate_write_cache > 0 &&
                     dev->se_sub_dev->se_dev_attrib.emulate_fua_write > 0 &&
-                    cmd->t_task->t_tasks_fua) {
+                    cmd->t_task.t_tasks_fua) {
                         /*
                          * We might need to be a bit smarter here
                          * and return some sense data to let the initiator