aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/target/target_core_device.c
diff options
context:
space:
mode:
authorChris Zankel <czankel@purestorage.com>2015-07-20 19:29:50 -0400
committerNicholas Bellinger <nab@linux-iscsi.org>2015-07-31 01:57:30 -0400
commitb6a54b8d895648d915c7e8308f3d3e6bf2505d69 (patch)
treeeeb4ba6386eec2961d5319d1fc5100186ee4fe1f /drivers/target/target_core_device.c
parent53c46995b6ed7cb32a28bce1f4a25065baf65d8f (diff)
target: remove initiatorname field in se_acl_lun
From: Chris Zankel <czankel@purestorage.com> The initiatorname field in se_acl_lun is only a copy of the same field in se_node_acl, so remove it and use the version in se_node_acl where needed (it's actually only used for pr_debug) Signed-off-by: Chris Zankel <czankel@purestorage.com> Signed-off-by: Spencer Baugh <spencer.baugh@purestorage.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/target_core_device.c')
-rw-r--r--drivers/target/target_core_device.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index db7034292053..55f2cb2a9947 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -620,8 +620,6 @@ struct se_lun_acl *core_dev_init_initiator_node_lun_acl(
620 620
621 lacl->mapped_lun = mapped_lun; 621 lacl->mapped_lun = mapped_lun;
622 lacl->se_lun_nacl = nacl; 622 lacl->se_lun_nacl = nacl;
623 snprintf(lacl->initiatorname, TRANSPORT_IQN_LEN, "%s",
624 nacl->initiatorname);
625 623
626 return lacl; 624 return lacl;
627} 625}
@@ -656,7 +654,7 @@ int core_dev_add_initiator_node_lun_acl(
656 " InitiatorNode: %s\n", tpg->se_tpg_tfo->get_fabric_name(), 654 " InitiatorNode: %s\n", tpg->se_tpg_tfo->get_fabric_name(),
657 tpg->se_tpg_tfo->tpg_get_tag(tpg), lun->unpacked_lun, lacl->mapped_lun, 655 tpg->se_tpg_tfo->tpg_get_tag(tpg), lun->unpacked_lun, lacl->mapped_lun,
658 (lun_access & TRANSPORT_LUNFLAGS_READ_WRITE) ? "RW" : "RO", 656 (lun_access & TRANSPORT_LUNFLAGS_READ_WRITE) ? "RW" : "RO",
659 lacl->initiatorname); 657 nacl->initiatorname);
660 /* 658 /*
661 * Check to see if there are any existing persistent reservation APTPL 659 * Check to see if there are any existing persistent reservation APTPL
662 * pre-registrations that need to be enabled for this LUN ACL.. 660 * pre-registrations that need to be enabled for this LUN ACL..
@@ -688,7 +686,7 @@ int core_dev_del_initiator_node_lun_acl(
688 " InitiatorNode: %s Mapped LUN: %llu\n", 686 " InitiatorNode: %s Mapped LUN: %llu\n",
689 tpg->se_tpg_tfo->get_fabric_name(), 687 tpg->se_tpg_tfo->get_fabric_name(),
690 tpg->se_tpg_tfo->tpg_get_tag(tpg), lun->unpacked_lun, 688 tpg->se_tpg_tfo->tpg_get_tag(tpg), lun->unpacked_lun,
691 lacl->initiatorname, lacl->mapped_lun); 689 nacl->initiatorname, lacl->mapped_lun);
692 690
693 return 0; 691 return 0;
694} 692}
@@ -701,7 +699,7 @@ void core_dev_free_initiator_node_lun_acl(
701 " Mapped LUN: %llu\n", tpg->se_tpg_tfo->get_fabric_name(), 699 " Mapped LUN: %llu\n", tpg->se_tpg_tfo->get_fabric_name(),
702 tpg->se_tpg_tfo->tpg_get_tag(tpg), 700 tpg->se_tpg_tfo->tpg_get_tag(tpg),
703 tpg->se_tpg_tfo->get_fabric_name(), 701 tpg->se_tpg_tfo->get_fabric_name(),
704 lacl->initiatorname, lacl->mapped_lun); 702 lacl->se_lun_nacl->initiatorname, lacl->mapped_lun);
705 703
706 kfree(lacl); 704 kfree(lacl);
707} 705}