diff options
| author | David Disseldorp <ddiss@suse.de> | 2018-11-23 12:36:11 -0500 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2018-11-28 18:50:53 -0500 |
| commit | 6baca7601bdee2e57f20c45d63eb53b89b33e816 (patch) | |
| tree | 54bed3bbd63a1401e39be2b2ddfe6f13d232e128 /drivers/target/target_core_configfs.c | |
| parent | 359d0ac1e806caa6c233e32d33c8970aa94f6cb7 (diff) | |
scsi: target: drop unused pi_prot_format attribute storage
On write, the pi_prot_format configfs attribute invokes the device
format_prot() callback if present. Read dumps the contents of
se_dev_attrib.pi_prot_format which is always zero. Make the configfs
attribute write-only, and drop the always zero se_dev_attrib.pi_prot_format
storage.
Signed-off-by: David Disseldorp <ddiss@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/target/target_core_configfs.c')
| -rw-r--r-- | drivers/target/target_core_configfs.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index 70b9f6755c36..62427acdf503 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c | |||
| @@ -535,7 +535,6 @@ DEF_CONFIGFS_ATTRIB_SHOW(emulate_3pc); | |||
| 535 | DEF_CONFIGFS_ATTRIB_SHOW(emulate_pr); | 535 | DEF_CONFIGFS_ATTRIB_SHOW(emulate_pr); |
| 536 | DEF_CONFIGFS_ATTRIB_SHOW(pi_prot_type); | 536 | DEF_CONFIGFS_ATTRIB_SHOW(pi_prot_type); |
| 537 | DEF_CONFIGFS_ATTRIB_SHOW(hw_pi_prot_type); | 537 | DEF_CONFIGFS_ATTRIB_SHOW(hw_pi_prot_type); |
| 538 | DEF_CONFIGFS_ATTRIB_SHOW(pi_prot_format); | ||
| 539 | DEF_CONFIGFS_ATTRIB_SHOW(pi_prot_verify); | 538 | DEF_CONFIGFS_ATTRIB_SHOW(pi_prot_verify); |
| 540 | DEF_CONFIGFS_ATTRIB_SHOW(enforce_pr_isids); | 539 | DEF_CONFIGFS_ATTRIB_SHOW(enforce_pr_isids); |
| 541 | DEF_CONFIGFS_ATTRIB_SHOW(is_nonrot); | 540 | DEF_CONFIGFS_ATTRIB_SHOW(is_nonrot); |
| @@ -1121,7 +1120,7 @@ CONFIGFS_ATTR(, emulate_3pc); | |||
| 1121 | CONFIGFS_ATTR(, emulate_pr); | 1120 | CONFIGFS_ATTR(, emulate_pr); |
| 1122 | CONFIGFS_ATTR(, pi_prot_type); | 1121 | CONFIGFS_ATTR(, pi_prot_type); |
| 1123 | CONFIGFS_ATTR_RO(, hw_pi_prot_type); | 1122 | CONFIGFS_ATTR_RO(, hw_pi_prot_type); |
| 1124 | CONFIGFS_ATTR(, pi_prot_format); | 1123 | CONFIGFS_ATTR_WO(, pi_prot_format); |
| 1125 | CONFIGFS_ATTR(, pi_prot_verify); | 1124 | CONFIGFS_ATTR(, pi_prot_verify); |
| 1126 | CONFIGFS_ATTR(, enforce_pr_isids); | 1125 | CONFIGFS_ATTR(, enforce_pr_isids); |
| 1127 | CONFIGFS_ATTR(, is_nonrot); | 1126 | CONFIGFS_ATTR(, is_nonrot); |
