diff options
author | Christoph Hellwig <hch@lst.de> | 2018-12-13 10:17:02 -0500 |
---|---|---|
committer | Martin K. Petersen <martin.petersen@oracle.com> | 2018-12-18 23:13:12 -0500 |
commit | 2a3d4eb8e228061c09d5ca8bf39e7f00c2091213 (patch) | |
tree | 867ce9fbb2ecee876580bb728ef3affb3e1b41d3 /drivers/scsi/scsi_debug.c | |
parent | 4dd4130a722fb046e941010cf5576aed252bb58a (diff) |
scsi: flip the default on use_clustering
Most SCSI drivers want to enable "clustering", that is merging of
segments so that they might span more than a single page. Remove the
ENABLE_CLUSTERING define, and require drivers to explicitly set
DISABLE_CLUSTERING to disable this feature.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/scsi_debug.c')
-rw-r--r-- | drivers/scsi/scsi_debug.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index 60bcc6df97a9..53ba417bef8a 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c | |||
@@ -5851,7 +5851,6 @@ static struct scsi_host_template sdebug_driver_template = { | |||
5851 | .sg_tablesize = SG_MAX_SEGMENTS, | 5851 | .sg_tablesize = SG_MAX_SEGMENTS, |
5852 | .cmd_per_lun = DEF_CMD_PER_LUN, | 5852 | .cmd_per_lun = DEF_CMD_PER_LUN, |
5853 | .max_sectors = -1U, | 5853 | .max_sectors = -1U, |
5854 | .use_clustering = DISABLE_CLUSTERING, | ||
5855 | .module = THIS_MODULE, | 5854 | .module = THIS_MODULE, |
5856 | .track_queue_depth = 1, | 5855 | .track_queue_depth = 1, |
5857 | }; | 5856 | }; |
@@ -5866,8 +5865,8 @@ static int sdebug_driver_probe(struct device *dev) | |||
5866 | sdbg_host = to_sdebug_host(dev); | 5865 | sdbg_host = to_sdebug_host(dev); |
5867 | 5866 | ||
5868 | sdebug_driver_template.can_queue = sdebug_max_queue; | 5867 | sdebug_driver_template.can_queue = sdebug_max_queue; |
5869 | if (sdebug_clustering) | 5868 | if (!sdebug_clustering) |
5870 | sdebug_driver_template.use_clustering = ENABLE_CLUSTERING; | 5869 | sdebug_driver_template.use_clustering = DISABLE_CLUSTERING; |
5871 | hpnt = scsi_host_alloc(&sdebug_driver_template, sizeof(sdbg_host)); | 5870 | hpnt = scsi_host_alloc(&sdebug_driver_template, sizeof(sdbg_host)); |
5872 | if (NULL == hpnt) { | 5871 | if (NULL == hpnt) { |
5873 | pr_err("scsi_host_alloc failed\n"); | 5872 | pr_err("scsi_host_alloc failed\n"); |