diff options
| author | Amitoj Kaur Chawla <amitoj1606@gmail.com> | 2016-02-17 08:32:54 -0500 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2016-03-01 20:06:49 -0500 |
| commit | a6d24143fca421c836f78538705c8e5b3ef04e3d (patch) | |
| tree | dcfed74a1ac7ec1cefd9210c9e541b1f16d3c01c /drivers/scsi/qlogicpti.c | |
| parent | 8d5dbec3bcb24a7d071962448e0fecaca8c75cc7 (diff) | |
qlogicpti: Return correct error code
The return value of of_ioremap on failure should be -ENODEV and not
-1.
Found using Coccinelle. A simplified version of the semantic patch
used is:
//<smpl>
@@
expression *e;
@@
e = of_ioremap(...);
if (e == NULL) {
...
return
- -1
+ -ENODEV
;
}
//</smpl>
The single call site only checks that the return value is less than 0,
hence no change is required at the call site.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Reviewed-by: Shane Seymour <shane.seymour@hpe.com>
Reviewed-by: Hannes Reinicke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/qlogicpti.c')
| -rw-r--r-- | drivers/scsi/qlogicpti.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c index 676385ff28ef..69bfc0a1aea3 100644 --- a/drivers/scsi/qlogicpti.c +++ b/drivers/scsi/qlogicpti.c | |||
| @@ -710,7 +710,7 @@ static int qpti_map_regs(struct qlogicpti *qpti) | |||
| 710 | "PTI Qlogic/ISP"); | 710 | "PTI Qlogic/ISP"); |
| 711 | if (!qpti->qregs) { | 711 | if (!qpti->qregs) { |
| 712 | printk("PTI: Qlogic/ISP registers are unmappable\n"); | 712 | printk("PTI: Qlogic/ISP registers are unmappable\n"); |
| 713 | return -1; | 713 | return -ENODEV; |
| 714 | } | 714 | } |
| 715 | if (qpti->is_pti) { | 715 | if (qpti->is_pti) { |
| 716 | qpti->sreg = of_ioremap(&op->resource[0], (16 * 4096), | 716 | qpti->sreg = of_ioremap(&op->resource[0], (16 * 4096), |
| @@ -718,7 +718,7 @@ static int qpti_map_regs(struct qlogicpti *qpti) | |||
| 718 | "PTI Qlogic/ISP statreg"); | 718 | "PTI Qlogic/ISP statreg"); |
| 719 | if (!qpti->sreg) { | 719 | if (!qpti->sreg) { |
| 720 | printk("PTI: Qlogic/ISP status register is unmappable\n"); | 720 | printk("PTI: Qlogic/ISP status register is unmappable\n"); |
| 721 | return -1; | 721 | return -ENODEV; |
| 722 | } | 722 | } |
| 723 | } | 723 | } |
| 724 | return 0; | 724 | return 0; |