diff options
| author | Joe Carnuccio <joe.carnuccio@qlogic.com> | 2016-01-27 12:03:34 -0500 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2016-02-23 21:27:02 -0500 |
| commit | da08ef5c30a28745cc789f024a2095f85a4b2b12 (patch) | |
| tree | 46afdb0c99054677a17d26ef8513946f6e79d221 /drivers/scsi/qla2xxx/qla_mbx.c | |
| parent | 243de6768db50266f595ec62c5ae34783edb72ea (diff) | |
qla2xxx: Avoid side effects when using endianizer macros.
Signed-off-by: Joe Carnuccio <joe.carnuccio@qlogic.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/qla2xxx/qla_mbx.c')
| -rw-r--r-- | drivers/scsi/qla2xxx/qla_mbx.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 3dd339846a55..968b84613096 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c | |||
| @@ -2759,7 +2759,7 @@ qla2x00_get_link_status(scsi_qla_host_t *vha, uint16_t loop_id, | |||
| 2759 | int rval; | 2759 | int rval; |
| 2760 | mbx_cmd_t mc; | 2760 | mbx_cmd_t mc; |
| 2761 | mbx_cmd_t *mcp = &mc; | 2761 | mbx_cmd_t *mcp = &mc; |
| 2762 | uint32_t *siter, *diter, dwords; | 2762 | uint32_t *iter, dwords; |
| 2763 | struct qla_hw_data *ha = vha->hw; | 2763 | struct qla_hw_data *ha = vha->hw; |
| 2764 | 2764 | ||
| 2765 | ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x1084, | 2765 | ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x1084, |
| @@ -2801,9 +2801,9 @@ qla2x00_get_link_status(scsi_qla_host_t *vha, uint16_t loop_id, | |||
| 2801 | "Done %s.\n", __func__); | 2801 | "Done %s.\n", __func__); |
| 2802 | dwords = offsetof(struct link_statistics, | 2802 | dwords = offsetof(struct link_statistics, |
| 2803 | link_up_cnt) / 4; | 2803 | link_up_cnt) / 4; |
| 2804 | siter = diter = &stats->link_fail_cnt; | 2804 | iter = &stats->link_fail_cnt; |
| 2805 | while (dwords--) | 2805 | for ( ; dwords--; iter++) |
| 2806 | *diter++ = le32_to_cpu(*siter++); | 2806 | le32_to_cpus(iter); |
| 2807 | } | 2807 | } |
| 2808 | } else { | 2808 | } else { |
| 2809 | /* Failed. */ | 2809 | /* Failed. */ |
| @@ -2820,7 +2820,7 @@ qla24xx_get_isp_stats(scsi_qla_host_t *vha, struct link_statistics *stats, | |||
| 2820 | int rval; | 2820 | int rval; |
| 2821 | mbx_cmd_t mc; | 2821 | mbx_cmd_t mc; |
| 2822 | mbx_cmd_t *mcp = &mc; | 2822 | mbx_cmd_t *mcp = &mc; |
| 2823 | uint32_t *siter, *diter, dwords; | 2823 | uint32_t *iter, dwords; |
| 2824 | 2824 | ||
| 2825 | ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x1088, | 2825 | ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x1088, |
| 2826 | "Entered %s.\n", __func__); | 2826 | "Entered %s.\n", __func__); |
| @@ -2849,9 +2849,9 @@ qla24xx_get_isp_stats(scsi_qla_host_t *vha, struct link_statistics *stats, | |||
| 2849 | "Done %s.\n", __func__); | 2849 | "Done %s.\n", __func__); |
| 2850 | /* Copy over data -- firmware data is LE. */ | 2850 | /* Copy over data -- firmware data is LE. */ |
| 2851 | dwords = sizeof(struct link_statistics) / 4; | 2851 | dwords = sizeof(struct link_statistics) / 4; |
| 2852 | siter = diter = &stats->link_fail_cnt; | 2852 | iter = &stats->link_fail_cnt; |
| 2853 | while (dwords--) | 2853 | for ( ; dwords--; iter++) |
| 2854 | *diter++ = le32_to_cpu(*siter++); | 2854 | le32_to_cpus(iter); |
| 2855 | } | 2855 | } |
| 2856 | } else { | 2856 | } else { |
| 2857 | /* Failed. */ | 2857 | /* Failed. */ |