diff options
author | David Gibson <david@gibson.dropbear.id.au> | 2015-02-03 00:36:21 -0500 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2015-03-22 23:29:40 -0400 |
commit | f5718726714cd6114876c4e3ca9b6992ab81176c (patch) | |
tree | c8cfe34ac28b22e89e8f5aac01c615ac61fbb221 /drivers/scsi/mac53c94.c | |
parent | 9eccca0843205f87c00404b663188b88eb248051 (diff) |
powerpc: Move Power Macintosh drivers to generic byteswappers
ppc has special instruction forms to efficiently load and store values
in non-native endianness. These can be accessed via the arch-specific
{ld,st}_le{16,32}() inlines in arch/powerpc/include/asm/swab.h.
However, gcc is perfectly capable of generating the byte-reversing
load/store instructions when using the normal, generic cpu_to_le*() and
le*_to_cpu() functions eaning the arch-specific functions don't have much
point.
Worse the "le" in the names of the arch specific functions is now
misleading, because they always generate byte-reversing forms, but some
ppc machines can now run a little-endian kernel.
To start getting rid of the arch-specific forms, this patch removes them
from all the old Power Macintosh drivers, replacing them with the
generic byteswappers.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'drivers/scsi/mac53c94.c')
-rw-r--r-- | drivers/scsi/mac53c94.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/scsi/mac53c94.c b/drivers/scsi/mac53c94.c index e5cd8d8d4ce7..0adb2e015597 100644 --- a/drivers/scsi/mac53c94.c +++ b/drivers/scsi/mac53c94.c | |||
@@ -382,16 +382,16 @@ static void set_dma_cmds(struct fsc_state *state, struct scsi_cmnd *cmd) | |||
382 | if (dma_len > 0xffff) | 382 | if (dma_len > 0xffff) |
383 | panic("mac53c94: scatterlist element >= 64k"); | 383 | panic("mac53c94: scatterlist element >= 64k"); |
384 | total += dma_len; | 384 | total += dma_len; |
385 | st_le16(&dcmds->req_count, dma_len); | 385 | dcmds->req_count = cpu_to_le16(dma_len); |
386 | st_le16(&dcmds->command, dma_cmd); | 386 | dcmds->command = cpu_to_le16(dma_cmd); |
387 | st_le32(&dcmds->phy_addr, dma_addr); | 387 | dcmds->phy_addr = cpu_to_le32(dma_addr); |
388 | dcmds->xfer_status = 0; | 388 | dcmds->xfer_status = 0; |
389 | ++dcmds; | 389 | ++dcmds; |
390 | } | 390 | } |
391 | 391 | ||
392 | dma_cmd += OUTPUT_LAST - OUTPUT_MORE; | 392 | dma_cmd += OUTPUT_LAST - OUTPUT_MORE; |
393 | st_le16(&dcmds[-1].command, dma_cmd); | 393 | dcmds[-1].command = cpu_to_le16(dma_cmd); |
394 | st_le16(&dcmds->command, DBDMA_STOP); | 394 | dcmds->command = cpu_to_le16(DBDMA_STOP); |
395 | cmd->SCp.this_residual = total; | 395 | cmd->SCp.this_residual = total; |
396 | } | 396 | } |
397 | 397 | ||