scsi: libsas: Drop SAS_DPRINTK() and revise logs levels

Like sas_printk() did previously, SAS_DPRINTK() offers little value now
that libsas logs already have the "sas" prefix through pr_fmt(fmt). So it
can be dropped.

However, after reviewing some logs in libsas, it is noticed that debug
level is too low in many instances.

So this change drops SAS_DPRINTK() and revises some logs to a more
appropriate level. However many stay at debug level, although some
are significantly promoted.

We add -DDEBUG for compilation so that we keep the debug messages by
default, as before.

All the pre-existing checkpatch errors for spanning messages across
multiple lines are also fixed.

Finally, all other references to printk() [apart from special formatting
in sas_ata.c] are removed and replaced with appropriate pr_xxx().

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/drivers/scsi/libsas/sas_init.c b/drivers/scsi/libsas/sas_init.c
index a3c25e22b939..221340ee8651 100644
--- a/drivers/scsi/libsas/sas_init.c
+++ b/drivers/scsi/libsas/sas_init.c
@@ -128,19 +128,19 @@ int sas_register_ha(struct sas_ha_struct *sas_ha)
 
         error = sas_register_phys(sas_ha);
         if (error) {
-                printk(KERN_NOTICE "couldn't register sas phys:%d\n", error);
+                pr_notice("couldn't register sas phys:%d\n", error);
                 return error;
         }
 
         error = sas_register_ports(sas_ha);
         if (error) {
-                printk(KERN_NOTICE "couldn't register sas ports:%d\n", error);
+                pr_notice("couldn't register sas ports:%d\n", error);
                 goto Undo_phys;
         }
 
         error = sas_init_events(sas_ha);
         if (error) {
-                printk(KERN_NOTICE "couldn't start event thread:%d\n", error);
+                pr_notice("couldn't start event thread:%d\n", error);
                 goto Undo_ports;
         }