diff options
author | Bart Van Assche <bvanassche@acm.org> | 2013-08-14 11:32:51 -0400 |
---|---|---|
committer | Robert Love <robert.w.love@intel.com> | 2013-09-04 15:55:02 -0400 |
commit | b20d9bfda77306c2f66a90eb94ef9db58fb1e682 (patch) | |
tree | 965d772c974767e416e57027cf338dca17a357f0 /drivers/scsi/libfc/fc_lport.c | |
parent | c1d454246c1339388ed0788f34f88ee12ad58ef3 (diff) |
libfc: Debug code fixes
The second argument of fc_lport_error() may be a valid frame pointer.
Hence only print it as an error code if it really is an error code.
Debug statements must end in a newline. Add one where it is missing.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Diffstat (limited to 'drivers/scsi/libfc/fc_lport.c')
-rw-r--r-- | drivers/scsi/libfc/fc_lport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c index a32f3141f3f9..e01a29863c38 100644 --- a/drivers/scsi/libfc/fc_lport.c +++ b/drivers/scsi/libfc/fc_lport.c | |||
@@ -1088,7 +1088,7 @@ static void fc_lport_error(struct fc_lport *lport, struct fc_frame *fp) | |||
1088 | { | 1088 | { |
1089 | unsigned long delay = 0; | 1089 | unsigned long delay = 0; |
1090 | FC_LPORT_DBG(lport, "Error %ld in state %s, retries %d\n", | 1090 | FC_LPORT_DBG(lport, "Error %ld in state %s, retries %d\n", |
1091 | PTR_ERR(fp), fc_lport_state(lport), | 1091 | IS_ERR(fp) ? -PTR_ERR(fp) : 0, fc_lport_state(lport), |
1092 | lport->retry_count); | 1092 | lport->retry_count); |
1093 | 1093 | ||
1094 | if (PTR_ERR(fp) == -FC_EX_CLOSED) | 1094 | if (PTR_ERR(fp) == -FC_EX_CLOSED) |