diff options
| author | John Garry <john.garry@huawei.com> | 2015-12-21 06:35:08 -0500 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2016-01-08 12:11:06 -0500 |
| commit | 8fb88201b4303159638976c2c4c4769fc89d64d1 (patch) | |
| tree | 5eb0c49b3d71e0205f62c53b2cdc9ad318e8e550 /drivers/scsi/hisi_sas | |
| parent | 8ceec33223f0cf8849d47dbe2203ce82c9875d09 (diff) | |
hisi_sas: Fix typo in setup_itct_v1_hw()
We were doing a arithmetic comparison instead of logical shift by
accident. Mis-programming the itct did not seem to make a difference to
operation.
Fixes: abda97c2fe874 ("hisi_sas: Add dev_found")
Signed-off-by: John Garry <john.garry@huawei.com>
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Reviewed-by: Shane Seymour <shane.seymour@hpe.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/hisi_sas')
| -rw-r--r-- | drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c index 0af682cafa0b..38ff575775f1 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | |||
| @@ -528,10 +528,10 @@ static void setup_itct_v1_hw(struct hisi_hba *hisi_hba, | |||
| 528 | itct->sas_addr = __swab64(itct->sas_addr); | 528 | itct->sas_addr = __swab64(itct->sas_addr); |
| 529 | 529 | ||
| 530 | /* qw2 */ | 530 | /* qw2 */ |
| 531 | itct->qw2 = cpu_to_le64((500 < ITCT_HDR_IT_NEXUS_LOSS_TL_OFF) | | 531 | itct->qw2 = cpu_to_le64((500ULL << ITCT_HDR_IT_NEXUS_LOSS_TL_OFF) | |
| 532 | (0xff00 < ITCT_HDR_BUS_INACTIVE_TL_OFF) | | 532 | (0xff00ULL << ITCT_HDR_BUS_INACTIVE_TL_OFF) | |
| 533 | (0xff00 < ITCT_HDR_MAX_CONN_TL_OFF) | | 533 | (0xff00ULL << ITCT_HDR_MAX_CONN_TL_OFF) | |
| 534 | (0xff00 < ITCT_HDR_REJ_OPEN_TL_OFF)); | 534 | (0xff00ULL << ITCT_HDR_REJ_OPEN_TL_OFF)); |
| 535 | } | 535 | } |
| 536 | 536 | ||
| 537 | static void free_device_v1_hw(struct hisi_hba *hisi_hba, | 537 | static void free_device_v1_hw(struct hisi_hba *hisi_hba, |