aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/s390/net
diff options
context:
space:
mode:
authorEugene Crosser <Eugene.Crosser@ru.ibm.com>2015-05-18 08:27:54 -0400
committerDavid S. Miller <davem@davemloft.net>2015-05-18 12:14:17 -0400
commitd3c29a5c3fb81b9e2eef65c9edd3b43e7f7510f2 (patch)
treedfe4cc0a4d02cb91caaffc21e0e45800bb8fb2d0 /drivers/s390/net
parentc88394e7ee5ecf425754f78d38b4968eb60ffba5 (diff)
qeth: remove locks from sysfs _show
Locking is probably unnecessary in this case, and the rest of the qeth sysfs code does not use locks in the *_show() functions. Remove locks from the layer2 *_show() functions in which they where accidentally introduced. Signed-off-by: Eugene Crosser <Eugene.Crosser@ru.ibm.com> Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390/net')
-rw-r--r--drivers/s390/net/qeth_l2_sys.c8
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/s390/net/qeth_l2_sys.c b/drivers/s390/net/qeth_l2_sys.c
index 59e3aa538b4d..6504d48bdd97 100644
--- a/drivers/s390/net/qeth_l2_sys.c
+++ b/drivers/s390/net/qeth_l2_sys.c
@@ -23,8 +23,6 @@ static ssize_t qeth_bridge_port_role_state_show(struct device *dev,
23 if (!card) 23 if (!card)
24 return -EINVAL; 24 return -EINVAL;
25 25
26 mutex_lock(&card->conf_mutex);
27
28 if (qeth_card_hw_is_reachable(card) && 26 if (qeth_card_hw_is_reachable(card) &&
29 card->options.sbp.supported_funcs) 27 card->options.sbp.supported_funcs)
30 rc = qeth_bridgeport_query_ports(card, 28 rc = qeth_bridgeport_query_ports(card,
@@ -59,8 +57,6 @@ static ssize_t qeth_bridge_port_role_state_show(struct device *dev,
59 rc = sprintf(buf, "%s\n", word); 57 rc = sprintf(buf, "%s\n", word);
60 } 58 }
61 59
62 mutex_unlock(&card->conf_mutex);
63
64 return rc; 60 return rc;
65} 61}
66 62
@@ -123,12 +119,8 @@ static ssize_t qeth_bridgeport_hostnotification_show(struct device *dev,
123 if (!card) 119 if (!card)
124 return -EINVAL; 120 return -EINVAL;
125 121
126 mutex_lock(&card->conf_mutex);
127
128 enabled = card->options.sbp.hostnotification; 122 enabled = card->options.sbp.hostnotification;
129 123
130 mutex_unlock(&card->conf_mutex);
131
132 return sprintf(buf, "%d\n", enabled); 124 return sprintf(buf, "%d\n", enabled);
133} 125}
134 126