diff options
author | Laxman Dewangan <ldewangan@nvidia.com> | 2014-01-23 18:55:02 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-01-23 19:36:59 -0500 |
commit | 75465c49f092f24acc236b0f51e9b8bf8adc329e (patch) | |
tree | f852c230cb60efeb812937912a9bf74168efb0e8 /drivers/rtc | |
parent | 8dc51fe5ab9edcaebb5438d6462befdc6922b4a1 (diff) |
drivers/rtc/rtc-as3722: use devm for rtc and irq registration
Use devm_* calls for rtc and irq registration and get rid of
remove callback for platform driver.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rtc')
-rw-r--r-- | drivers/rtc/rtc-as3722.c | 19 |
1 files changed, 3 insertions, 16 deletions
diff --git a/drivers/rtc/rtc-as3722.c b/drivers/rtc/rtc-as3722.c index 9cfa8170a2d6..4af016985890 100644 --- a/drivers/rtc/rtc-as3722.c +++ b/drivers/rtc/rtc-as3722.c | |||
@@ -198,7 +198,7 @@ static int as3722_rtc_probe(struct platform_device *pdev) | |||
198 | 198 | ||
199 | device_init_wakeup(&pdev->dev, 1); | 199 | device_init_wakeup(&pdev->dev, 1); |
200 | 200 | ||
201 | as3722_rtc->rtc = rtc_device_register("as3722", &pdev->dev, | 201 | as3722_rtc->rtc = devm_rtc_device_register(&pdev->dev, "as3722-rtc", |
202 | &as3722_rtc_ops, THIS_MODULE); | 202 | &as3722_rtc_ops, THIS_MODULE); |
203 | if (IS_ERR(as3722_rtc->rtc)) { | 203 | if (IS_ERR(as3722_rtc->rtc)) { |
204 | ret = PTR_ERR(as3722_rtc->rtc); | 204 | ret = PTR_ERR(as3722_rtc->rtc); |
@@ -209,28 +209,16 @@ static int as3722_rtc_probe(struct platform_device *pdev) | |||
209 | as3722_rtc->alarm_irq = platform_get_irq(pdev, 0); | 209 | as3722_rtc->alarm_irq = platform_get_irq(pdev, 0); |
210 | dev_info(&pdev->dev, "RTC interrupt %d\n", as3722_rtc->alarm_irq); | 210 | dev_info(&pdev->dev, "RTC interrupt %d\n", as3722_rtc->alarm_irq); |
211 | 211 | ||
212 | ret = request_threaded_irq(as3722_rtc->alarm_irq, NULL, | 212 | ret = devm_request_threaded_irq(&pdev->dev, as3722_rtc->alarm_irq, NULL, |
213 | as3722_alarm_irq, IRQF_ONESHOT | IRQF_EARLY_RESUME, | 213 | as3722_alarm_irq, IRQF_ONESHOT | IRQF_EARLY_RESUME, |
214 | "rtc-alarm", as3722_rtc); | 214 | "rtc-alarm", as3722_rtc); |
215 | if (ret < 0) { | 215 | if (ret < 0) { |
216 | dev_err(&pdev->dev, "Failed to request alarm IRQ %d: %d\n", | 216 | dev_err(&pdev->dev, "Failed to request alarm IRQ %d: %d\n", |
217 | as3722_rtc->alarm_irq, ret); | 217 | as3722_rtc->alarm_irq, ret); |
218 | goto scrub; | 218 | return ret; |
219 | } | 219 | } |
220 | disable_irq(as3722_rtc->alarm_irq); | 220 | disable_irq(as3722_rtc->alarm_irq); |
221 | return 0; | 221 | return 0; |
222 | scrub: | ||
223 | rtc_device_unregister(as3722_rtc->rtc); | ||
224 | return ret; | ||
225 | } | ||
226 | |||
227 | static int as3722_rtc_remove(struct platform_device *pdev) | ||
228 | { | ||
229 | struct as3722_rtc *as3722_rtc = platform_get_drvdata(pdev); | ||
230 | |||
231 | free_irq(as3722_rtc->alarm_irq, as3722_rtc); | ||
232 | rtc_device_unregister(as3722_rtc->rtc); | ||
233 | return 0; | ||
234 | } | 222 | } |
235 | 223 | ||
236 | #ifdef CONFIG_PM_SLEEP | 224 | #ifdef CONFIG_PM_SLEEP |
@@ -260,7 +248,6 @@ static const struct dev_pm_ops as3722_rtc_pm_ops = { | |||
260 | 248 | ||
261 | static struct platform_driver as3722_rtc_driver = { | 249 | static struct platform_driver as3722_rtc_driver = { |
262 | .probe = as3722_rtc_probe, | 250 | .probe = as3722_rtc_probe, |
263 | .remove = as3722_rtc_remove, | ||
264 | .driver = { | 251 | .driver = { |
265 | .name = "as3722-rtc", | 252 | .name = "as3722-rtc", |
266 | .pm = &as3722_rtc_pm_ops, | 253 | .pm = &as3722_rtc_pm_ops, |