diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2013-09-11 17:24:27 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-09-11 18:58:59 -0400 |
commit | 7c1d69ee11b8986c40a53d8e2238204fc86f5b33 (patch) | |
tree | e711a10129ef7b6e060fdfa82dc7eb31f55be2d8 /drivers/rtc/rtc-mxc.c | |
parent | 1735be4b822e8e3808f461372ff3942824790172 (diff) |
rtc: simplify devm_request_mem_region/devm_ioremap
Convert the composition of devm_request_mem_region and devm_ioremap to a
single call to devm_ioremap_resource. The associated call to
platform_get_resource is also simplified and moved next to the new call
to devm_ioremap_resource.
This was done using a combination of the semantic patches
devm_ioremap_resource.cocci and devm_request_and_ioremap.cocci, found in
the scripts/coccinelle/api directory.
In rtc-lpc32xx.c and rtc-mv.c, the local variable size is no longer needed.
In rtc-ds1511.c the size field of the local structure is not useful any
more, and is deleted.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rtc/rtc-mxc.c')
-rw-r--r-- | drivers/rtc/rtc-mxc.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c index ab87bacb8f88..50c572645546 100644 --- a/drivers/rtc/rtc-mxc.c +++ b/drivers/rtc/rtc-mxc.c | |||
@@ -377,22 +377,16 @@ static int mxc_rtc_probe(struct platform_device *pdev) | |||
377 | unsigned long rate; | 377 | unsigned long rate; |
378 | int ret; | 378 | int ret; |
379 | 379 | ||
380 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | ||
381 | if (!res) | ||
382 | return -ENODEV; | ||
383 | |||
384 | pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); | 380 | pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); |
385 | if (!pdata) | 381 | if (!pdata) |
386 | return -ENOMEM; | 382 | return -ENOMEM; |
387 | 383 | ||
388 | pdata->devtype = pdev->id_entry->driver_data; | 384 | pdata->devtype = pdev->id_entry->driver_data; |
389 | 385 | ||
390 | if (!devm_request_mem_region(&pdev->dev, res->start, | 386 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
391 | resource_size(res), pdev->name)) | 387 | pdata->ioaddr = devm_ioremap_resource(&pdev->dev, res); |
392 | return -EBUSY; | 388 | if (IS_ERR(pdata->ioaddr)) |
393 | 389 | return PTR_ERR(pdata->ioaddr); | |
394 | pdata->ioaddr = devm_ioremap(&pdev->dev, res->start, | ||
395 | resource_size(res)); | ||
396 | 390 | ||
397 | pdata->clk = devm_clk_get(&pdev->dev, NULL); | 391 | pdata->clk = devm_clk_get(&pdev->dev, NULL); |
398 | if (IS_ERR(pdata->clk)) { | 392 | if (IS_ERR(pdata->clk)) { |