diff options
author | Joe Perches <joe@perches.com> | 2015-04-16 15:46:14 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-04-17 09:04:02 -0400 |
commit | a737e835e5769ef22897179ed7f82b1fc50bfa58 (patch) | |
tree | adf239d0ad61f2d92460ded814da3168aca8d0f7 /drivers/rtc/rtc-ds3232.c | |
parent | f539a8acf1070557aef9c5df682751ba2af1005f (diff) |
rtc: use more standard kernel logging styles
Neaten the logging a bit by adding #define pr_fmt
Miscellanea:
o Remove __FILE__/__func__ uses
o Coalesce formats adding missing spaces
o Align arguments
o (rtc-cmos) Integrated 2 consecutive messages
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Joshua Kinard <kumba@gentoo.org>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/rtc/rtc-ds3232.c')
-rw-r--r-- | drivers/rtc/rtc-ds3232.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index adaf06c41479..7e48e532214f 100644 --- a/drivers/rtc/rtc-ds3232.c +++ b/drivers/rtc/rtc-ds3232.c | |||
@@ -15,6 +15,8 @@ | |||
15 | * "Sending and receiving", using SMBus level communication is preferred. | 15 | * "Sending and receiving", using SMBus level communication is preferred. |
16 | */ | 16 | */ |
17 | 17 | ||
18 | #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt | ||
19 | |||
18 | #include <linux/kernel.h> | 20 | #include <linux/kernel.h> |
19 | #include <linux/module.h> | 21 | #include <linux/module.h> |
20 | #include <linux/interrupt.h> | 22 | #include <linux/interrupt.h> |
@@ -373,8 +375,8 @@ static void ds3232_work(struct work_struct *work) | |||
373 | if (stat & DS3232_REG_SR_A1F) { | 375 | if (stat & DS3232_REG_SR_A1F) { |
374 | control = i2c_smbus_read_byte_data(client, DS3232_REG_CR); | 376 | control = i2c_smbus_read_byte_data(client, DS3232_REG_CR); |
375 | if (control < 0) { | 377 | if (control < 0) { |
376 | pr_warn("Read DS3232 Control Register error." | 378 | pr_warn("Read Control Register error - Disable IRQ%d\n", |
377 | "Disable IRQ%d.\n", client->irq); | 379 | client->irq); |
378 | } else { | 380 | } else { |
379 | /* disable alarm1 interrupt */ | 381 | /* disable alarm1 interrupt */ |
380 | control &= ~(DS3232_REG_CR_A1IE); | 382 | control &= ~(DS3232_REG_CR_A1IE); |