aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/regulator/isl6271a-regulator.c
diff options
context:
space:
mode:
authorMark Brown <broonie@opensource.wolfsonmicro.com>2012-04-03 19:50:22 -0400
committerMark Brown <broonie@opensource.wolfsonmicro.com>2012-04-09 07:37:09 -0400
commitc172708d38a401b2f3f841dfcd862b469fa0b670 (patch)
tree75e89c63fd0c76a2c69bb5ad6e45b3762bceb6b6 /drivers/regulator/isl6271a-regulator.c
parent1474e4dbcae04125ed6e503eadcef266846f4675 (diff)
regulator: core: Use a struct to pass in regulator runtime configuration
Rather than adding new arguments to regulator_register() every time we want to add a new bit of dynamic information at runtime change the function to take these via a struct. By doing this we avoid needing to do further changes like the recent addition of device tree support which required each regulator driver to be updated to take an additional parameter. The regulator_desc which should (mostly) be static data is still passed separately as most drivers are able to configure this statically at build time. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers/regulator/isl6271a-regulator.c')
-rw-r--r--drivers/regulator/isl6271a-regulator.c11
1 files changed, 9 insertions, 2 deletions
diff --git a/drivers/regulator/isl6271a-regulator.c b/drivers/regulator/isl6271a-regulator.c
index eee6f6b85ebc..863f45a18c30 100644
--- a/drivers/regulator/isl6271a-regulator.c
+++ b/drivers/regulator/isl6271a-regulator.c
@@ -140,6 +140,7 @@ static const struct regulator_desc isl_rd[] = {
140static int __devinit isl6271a_probe(struct i2c_client *i2c, 140static int __devinit isl6271a_probe(struct i2c_client *i2c,
141 const struct i2c_device_id *id) 141 const struct i2c_device_id *id)
142{ 142{
143 struct regulator_config config = { };
143 struct regulator_init_data *init_data = i2c->dev.platform_data; 144 struct regulator_init_data *init_data = i2c->dev.platform_data;
144 struct isl_pmic *pmic; 145 struct isl_pmic *pmic;
145 int err, i; 146 int err, i;
@@ -156,8 +157,14 @@ static int __devinit isl6271a_probe(struct i2c_client *i2c,
156 mutex_init(&pmic->mtx); 157 mutex_init(&pmic->mtx);
157 158
158 for (i = 0; i < 3; i++) { 159 for (i = 0; i < 3; i++) {
159 pmic->rdev[i] = regulator_register(&isl_rd[i], &i2c->dev, 160 config.dev = &i2c->dev;
160 init_data, pmic, NULL); 161 if (i == 0)
162 config.init_data = init_data;
163 else
164 config.init_data = 0;
165 config.driver_data = pmic;
166
167 pmic->rdev[i] = regulator_register(&isl_rd[i], &config);
161 if (IS_ERR(pmic->rdev[i])) { 168 if (IS_ERR(pmic->rdev[i])) {
162 dev_err(&i2c->dev, "failed to register %s\n", id->name); 169 dev_err(&i2c->dev, "failed to register %s\n", id->name);
163 err = PTR_ERR(pmic->rdev[i]); 170 err = PTR_ERR(pmic->rdev[i]);