usb: phy: fix return value check of usb_get_phy

usb_get_phy will return -ENODEV if it's not able to find the phy. Hence
fixed all the callers of usb_get_phy to check for this error condition
instead of relying on a non-zero value as success condition.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

1 files changed, 4 insertions, 3 deletions

diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c
index 13f9db2e8538..7cacbaa68efe 100644
--- a/drivers/power/twl4030_charger.c
+++ b/drivers/power/twl4030_charger.c
@@ -15,6 +15,7 @@
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/slab.h>
+#include <linux/err.h>
 #include <linux/platform_device.h>
 #include <linux/interrupt.h>
 #include <linux/i2c/twl.h>
@@ -480,7 +481,7 @@ static int __init twl4030_bci_probe(struct platform_device *pdev)
         INIT_WORK(&bci->work, twl4030_bci_usb_work);
 
         bci->transceiver = usb_get_phy(USB_PHY_TYPE_USB2);
-        if (bci->transceiver != NULL) {
+        if (!IS_ERR_OR_NULL(bci->transceiver)) {
                 bci->usb_nb.notifier_call = twl4030_bci_usb_ncb;
                 usb_register_notifier(bci->transceiver, &bci->usb_nb);
         }
@@ -507,7 +508,7 @@ static int __init twl4030_bci_probe(struct platform_device *pdev)
         return 0;
 
 fail_unmask_interrupts:
-        if (bci->transceiver != NULL) {
+        if (!IS_ERR_OR_NULL(bci->transceiver)) {
                 usb_unregister_notifier(bci->transceiver, &bci->usb_nb);
                 usb_put_phy(bci->transceiver);
         }
@@ -538,7 +539,7 @@ static int __exit twl4030_bci_remove(struct platform_device *pdev)
         twl_i2c_write_u8(TWL4030_MODULE_INTERRUPTS, 0xff,
                          TWL4030_INTERRUPTS_BCIIMR2A);
 
-        if (bci->transceiver != NULL) {
+        if (!IS_ERR_OR_NULL(bci->transceiver)) {
                 usb_unregister_notifier(bci->transceiver, &bci->usb_nb);
                 usb_put_phy(bci->transceiver);
         }