diff options
author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2014-12-29 07:26:50 -0500 |
---|---|---|
committer | Darren Hart <dvhart@linux.intel.com> | 2015-10-06 18:22:08 -0400 |
commit | 7d3777d1069137800cdd1420a6c75cd94151d877 (patch) | |
tree | 3c26a4cbf933be48cd61a8e245bcaa377b09e2f8 /drivers/platform | |
parent | 3a4bceeffae5b170af523cd9f2798d5a0d14a2d7 (diff) |
OLPC: Use %*ph specifier instead of passing direct values
The %*ph specifier allows to dump small buffers in hex format. Let's use it
instead of passing direct values via stack.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Paul Fox <pgf@laptop.org>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Diffstat (limited to 'drivers/platform')
-rw-r--r-- | drivers/platform/olpc/olpc-ec.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c index f9119525f557..f99b183d5296 100644 --- a/drivers/platform/olpc/olpc-ec.c +++ b/drivers/platform/olpc/olpc-ec.c | |||
@@ -192,18 +192,15 @@ static ssize_t ec_dbgfs_cmd_write(struct file *file, const char __user *buf, | |||
192 | for (i = 0; i <= ec_cmd_bytes; i++) | 192 | for (i = 0; i <= ec_cmd_bytes; i++) |
193 | ec_cmd[i] = ec_cmd_int[i]; | 193 | ec_cmd[i] = ec_cmd_int[i]; |
194 | 194 | ||
195 | pr_debug("olpc-ec: debugfs cmd 0x%02x with %d args %02x %02x %02x %02x %02x, want %d returns\n", | 195 | pr_debug("olpc-ec: debugfs cmd 0x%02x with %d args %5ph, want %d returns\n", |
196 | ec_cmd[0], ec_cmd_bytes, ec_cmd[1], ec_cmd[2], | 196 | ec_cmd[0], ec_cmd_bytes, ec_cmd + 1, |
197 | ec_cmd[3], ec_cmd[4], ec_cmd[5], ec_dbgfs_resp_bytes); | 197 | ec_dbgfs_resp_bytes); |
198 | 198 | ||
199 | olpc_ec_cmd(ec_cmd[0], (ec_cmd_bytes == 0) ? NULL : &ec_cmd[1], | 199 | olpc_ec_cmd(ec_cmd[0], (ec_cmd_bytes == 0) ? NULL : &ec_cmd[1], |
200 | ec_cmd_bytes, ec_dbgfs_resp, ec_dbgfs_resp_bytes); | 200 | ec_cmd_bytes, ec_dbgfs_resp, ec_dbgfs_resp_bytes); |
201 | 201 | ||
202 | pr_debug("olpc-ec: response %02x %02x %02x %02x %02x %02x %02x %02x (%d bytes expected)\n", | 202 | pr_debug("olpc-ec: response %8ph (%d bytes expected)\n", |
203 | ec_dbgfs_resp[0], ec_dbgfs_resp[1], ec_dbgfs_resp[2], | 203 | ec_dbgfs_resp, ec_dbgfs_resp_bytes); |
204 | ec_dbgfs_resp[3], ec_dbgfs_resp[4], ec_dbgfs_resp[5], | ||
205 | ec_dbgfs_resp[6], ec_dbgfs_resp[7], | ||
206 | ec_dbgfs_resp_bytes); | ||
207 | 204 | ||
208 | out: | 205 | out: |
209 | mutex_unlock(&ec_dbgfs_lock); | 206 | mutex_unlock(&ec_dbgfs_lock); |