diff options
author | Axel Lin <axel.lin@ingics.com> | 2016-09-18 21:33:51 -0400 |
---|---|---|
committer | Darren Hart <dvhart@linux.intel.com> | 2016-12-13 12:29:01 -0500 |
commit | 3526ecadc86cc1d485153255498cde7d0275dd37 (patch) | |
tree | 2b46fccd8bda332ae1ca2b9c91e6b28f0114e86e /drivers/platform/x86/intel-hid.c | |
parent | 5dc444b804eae57abaf6f05663d9cb9f030bb9d2 (diff) |
platform/x86: Use ACPI_FAILURE at appropriate places
Use ACPI_FAILURE() to replace !ACPI_SUCCESS(), this avoid !! operations.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Diffstat (limited to 'drivers/platform/x86/intel-hid.c')
-rw-r--r-- | drivers/platform/x86/intel-hid.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c index ed5874217ee7..00cbeca2108d 100644 --- a/drivers/platform/x86/intel-hid.c +++ b/drivers/platform/x86/intel-hid.c | |||
@@ -69,7 +69,7 @@ static int intel_hid_set_enable(struct device *device, int enable) | |||
69 | 69 | ||
70 | arg0.integer.value = enable; | 70 | arg0.integer.value = enable; |
71 | status = acpi_evaluate_object(ACPI_HANDLE(device), "HDSM", &args, NULL); | 71 | status = acpi_evaluate_object(ACPI_HANDLE(device), "HDSM", &args, NULL); |
72 | if (!ACPI_SUCCESS(status)) { | 72 | if (ACPI_FAILURE(status)) { |
73 | dev_warn(device, "failed to %sable hotkeys\n", | 73 | dev_warn(device, "failed to %sable hotkeys\n", |
74 | enable ? "en" : "dis"); | 74 | enable ? "en" : "dis"); |
75 | return -EIO; | 75 | return -EIO; |
@@ -148,7 +148,7 @@ static void notify_handler(acpi_handle handle, u32 event, void *context) | |||
148 | } | 148 | } |
149 | 149 | ||
150 | status = acpi_evaluate_integer(handle, "HDEM", NULL, &ev_index); | 150 | status = acpi_evaluate_integer(handle, "HDEM", NULL, &ev_index); |
151 | if (!ACPI_SUCCESS(status)) { | 151 | if (ACPI_FAILURE(status)) { |
152 | dev_warn(&device->dev, "failed to get event index\n"); | 152 | dev_warn(&device->dev, "failed to get event index\n"); |
153 | return; | 153 | return; |
154 | } | 154 | } |
@@ -167,7 +167,7 @@ static int intel_hid_probe(struct platform_device *device) | |||
167 | int err; | 167 | int err; |
168 | 168 | ||
169 | status = acpi_evaluate_integer(handle, "HDMM", NULL, &mode); | 169 | status = acpi_evaluate_integer(handle, "HDMM", NULL, &mode); |
170 | if (!ACPI_SUCCESS(status)) { | 170 | if (ACPI_FAILURE(status)) { |
171 | dev_warn(&device->dev, "failed to read mode\n"); | 171 | dev_warn(&device->dev, "failed to read mode\n"); |
172 | return -ENODEV; | 172 | return -ENODEV; |
173 | } | 173 | } |