pinctrl: Pass all configs to driver on pin_config_set()

When setting pin configuration in the pinctrl framework, pin_config_set() or
pin_config_group_set() is called in a loop to set one configuration at a time
for the specified pin or group.

This patch 1) removes the loop and 2) changes the API to pass the whole pin
config array to the driver.  It is now up to the driver to loop through the
configs.  This allows the driver to potentially combine configs and reduce the
number of writes to pin config registers.

All c files changed have been build-tested to verify the change compiles and
that the corresponding .o is successfully generated.

Signed-off-by: Sherman Yin <syin@broadcom.com>
Reviewed-by: Christian Daudt <csd@broadcom.com>
Reviewed-by: Matt Porter <matt.porter@linaro.org>
Tested-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

1 files changed, 29 insertions, 19 deletions

diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index 7cce066c71b6..9685ff6c8b01 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -736,30 +736,40 @@ static int at91_pinconf_get(struct pinctrl_dev *pctldev,
 }
 
 static int at91_pinconf_set(struct pinctrl_dev *pctldev,
-                             unsigned pin_id, unsigned long config)
+                             unsigned pin_id, unsigned long *configs,
+                             unsigned num_configs)
 {
         struct at91_pinctrl *info = pinctrl_dev_get_drvdata(pctldev);
         unsigned mask;
         void __iomem *pio;
-
-        dev_dbg(info->dev, "%s:%d, pin_id=%d, config=0x%lx", __func__, __LINE__, pin_id, config);
-        pio = pin_to_controller(info, pin_to_bank(pin_id));
-        mask = pin_to_mask(pin_id % MAX_NB_GPIO_PER_BANK);
-
-        if (config & PULL_UP && config & PULL_DOWN)
-                return -EINVAL;
-
-        at91_mux_set_pullup(pio, mask, config & PULL_UP);
-        at91_mux_set_multidrive(pio, mask, config & MULTI_DRIVE);
-        if (info->ops->set_deglitch)
-                info->ops->set_deglitch(pio, mask, config & DEGLITCH);
-        if (info->ops->set_debounce)
-                info->ops->set_debounce(pio, mask, config & DEBOUNCE,
+        int i;
+        unsigned long config;
+
+        for (i = 0; i < num_configs; i++) {
+                config = configs[i];
+
+                dev_dbg(info->dev,
+                        "%s:%d, pin_id=%d, config=0x%lx",
+                        __func__, __LINE__, pin_id, config);
+                pio = pin_to_controller(info, pin_to_bank(pin_id));
+                mask = pin_to_mask(pin_id % MAX_NB_GPIO_PER_BANK);
+
+                if (config & PULL_UP && config & PULL_DOWN)
+                        return -EINVAL;
+
+                at91_mux_set_pullup(pio, mask, config & PULL_UP);
+                at91_mux_set_multidrive(pio, mask, config & MULTI_DRIVE);
+                if (info->ops->set_deglitch)
+                        info->ops->set_deglitch(pio, mask, config & DEGLITCH);
+                if (info->ops->set_debounce)
+                        info->ops->set_debounce(pio, mask, config & DEBOUNCE,
                                 (config & DEBOUNCE_VAL) >> DEBOUNCE_VAL_SHIFT);
-        if (info->ops->set_pulldown)
-                info->ops->set_pulldown(pio, mask, config & PULL_DOWN);
-        if (info->ops->disable_schmitt_trig && config & DIS_SCHMIT)
-                info->ops->disable_schmitt_trig(pio, mask);
+                if (info->ops->set_pulldown)
+                        info->ops->set_pulldown(pio, mask, config & PULL_DOWN);
+                if (info->ops->disable_schmitt_trig && config & DIS_SCHMIT)
+                        info->ops->disable_schmitt_trig(pio, mask);
+
+        } /* for each config */
 
         return 0;
 }