diff options
author | Peter Zijlstra <peterz@infradead.org> | 2017-11-13 08:28:33 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2018-03-12 10:28:49 -0400 |
commit | 8343aae66167df6708128a778e750d48dbe31302 (patch) | |
tree | 9b843bb1def15ca6e44e7ee0a80dc89e643ab9ee /drivers/perf | |
parent | 1cac7b1ae3579457200213303fc28ca13b75592f (diff) |
perf/core: Remove perf_event::group_entry
Now that all the grouping is done with RB trees, we no longer need
group_entry and can replace the whole thing with sibling_list.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Carrillo-Cisneros <davidcc@google.com>
Cc: Dmitri Prokhorov <Dmitry.Prohorov@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Valery Cherepennikov <valery.cherepennikov@intel.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'drivers/perf')
-rw-r--r-- | drivers/perf/arm_dsu_pmu.c | 2 | ||||
-rw-r--r-- | drivers/perf/arm_pmu.c | 2 | ||||
-rw-r--r-- | drivers/perf/hisilicon/hisi_uncore_pmu.c | 3 | ||||
-rw-r--r-- | drivers/perf/qcom_l2_pmu.c | 4 | ||||
-rw-r--r-- | drivers/perf/qcom_l3_pmu.c | 2 | ||||
-rw-r--r-- | drivers/perf/xgene_pmu.c | 2 |
6 files changed, 7 insertions, 8 deletions
diff --git a/drivers/perf/arm_dsu_pmu.c b/drivers/perf/arm_dsu_pmu.c index 38f2cc2a6c74..660680d78147 100644 --- a/drivers/perf/arm_dsu_pmu.c +++ b/drivers/perf/arm_dsu_pmu.c | |||
@@ -536,7 +536,7 @@ static bool dsu_pmu_validate_group(struct perf_event *event) | |||
536 | memset(fake_hw.used_mask, 0, sizeof(fake_hw.used_mask)); | 536 | memset(fake_hw.used_mask, 0, sizeof(fake_hw.used_mask)); |
537 | if (!dsu_pmu_validate_event(event->pmu, &fake_hw, leader)) | 537 | if (!dsu_pmu_validate_event(event->pmu, &fake_hw, leader)) |
538 | return false; | 538 | return false; |
539 | list_for_each_entry(sibling, &leader->sibling_list, group_entry) { | 539 | list_for_each_entry(sibling, &leader->sibling_list, sibling_list) { |
540 | if (!dsu_pmu_validate_event(event->pmu, &fake_hw, sibling)) | 540 | if (!dsu_pmu_validate_event(event->pmu, &fake_hw, sibling)) |
541 | return false; | 541 | return false; |
542 | } | 542 | } |
diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c index 0c2ed11c0603..628d7a7b9526 100644 --- a/drivers/perf/arm_pmu.c +++ b/drivers/perf/arm_pmu.c | |||
@@ -311,7 +311,7 @@ validate_group(struct perf_event *event) | |||
311 | if (!validate_event(event->pmu, &fake_pmu, leader)) | 311 | if (!validate_event(event->pmu, &fake_pmu, leader)) |
312 | return -EINVAL; | 312 | return -EINVAL; |
313 | 313 | ||
314 | list_for_each_entry(sibling, &leader->sibling_list, group_entry) { | 314 | list_for_each_entry(sibling, &leader->sibling_list, sibling_list) { |
315 | if (!validate_event(event->pmu, &fake_pmu, sibling)) | 315 | if (!validate_event(event->pmu, &fake_pmu, sibling)) |
316 | return -EINVAL; | 316 | return -EINVAL; |
317 | } | 317 | } |
diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.c b/drivers/perf/hisilicon/hisi_uncore_pmu.c index 7ed24b954422..e3356087fd76 100644 --- a/drivers/perf/hisilicon/hisi_uncore_pmu.c +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.c | |||
@@ -82,8 +82,7 @@ static bool hisi_validate_event_group(struct perf_event *event) | |||
82 | counters++; | 82 | counters++; |
83 | } | 83 | } |
84 | 84 | ||
85 | list_for_each_entry(sibling, &event->group_leader->sibling_list, | 85 | list_for_each_entry(sibling, &event->group_leader->sibling_list, sibling_list) { |
86 | group_entry) { | ||
87 | if (is_software_event(sibling)) | 86 | if (is_software_event(sibling)) |
88 | continue; | 87 | continue; |
89 | if (sibling->pmu != event->pmu) | 88 | if (sibling->pmu != event->pmu) |
diff --git a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c index 4fdc8486a8e4..5e535a718965 100644 --- a/drivers/perf/qcom_l2_pmu.c +++ b/drivers/perf/qcom_l2_pmu.c | |||
@@ -535,7 +535,7 @@ static int l2_cache_event_init(struct perf_event *event) | |||
535 | } | 535 | } |
536 | 536 | ||
537 | list_for_each_entry(sibling, &event->group_leader->sibling_list, | 537 | list_for_each_entry(sibling, &event->group_leader->sibling_list, |
538 | group_entry) | 538 | sibling_list) |
539 | if (sibling->pmu != event->pmu && | 539 | if (sibling->pmu != event->pmu && |
540 | !is_software_event(sibling)) { | 540 | !is_software_event(sibling)) { |
541 | dev_dbg_ratelimited(&l2cache_pmu->pdev->dev, | 541 | dev_dbg_ratelimited(&l2cache_pmu->pdev->dev, |
@@ -572,7 +572,7 @@ static int l2_cache_event_init(struct perf_event *event) | |||
572 | } | 572 | } |
573 | 573 | ||
574 | list_for_each_entry(sibling, &event->group_leader->sibling_list, | 574 | list_for_each_entry(sibling, &event->group_leader->sibling_list, |
575 | group_entry) { | 575 | sibling_list) { |
576 | if ((sibling != event) && | 576 | if ((sibling != event) && |
577 | !is_software_event(sibling) && | 577 | !is_software_event(sibling) && |
578 | (L2_EVT_GROUP(sibling->attr.config) == | 578 | (L2_EVT_GROUP(sibling->attr.config) == |
diff --git a/drivers/perf/qcom_l3_pmu.c b/drivers/perf/qcom_l3_pmu.c index 7f6b62b29e9d..5dedf4b1a552 100644 --- a/drivers/perf/qcom_l3_pmu.c +++ b/drivers/perf/qcom_l3_pmu.c | |||
@@ -468,7 +468,7 @@ static bool qcom_l3_cache__validate_event_group(struct perf_event *event) | |||
468 | counters = event_num_counters(event); | 468 | counters = event_num_counters(event); |
469 | counters += event_num_counters(leader); | 469 | counters += event_num_counters(leader); |
470 | 470 | ||
471 | list_for_each_entry(sibling, &leader->sibling_list, group_entry) { | 471 | list_for_each_entry(sibling, &leader->sibling_list, sibling_list) { |
472 | if (is_software_event(sibling)) | 472 | if (is_software_event(sibling)) |
473 | continue; | 473 | continue; |
474 | if (sibling->pmu != event->pmu) | 474 | if (sibling->pmu != event->pmu) |
diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c index eb23311bc70c..f1f4a56cab5e 100644 --- a/drivers/perf/xgene_pmu.c +++ b/drivers/perf/xgene_pmu.c | |||
@@ -950,7 +950,7 @@ static int xgene_perf_event_init(struct perf_event *event) | |||
950 | return -EINVAL; | 950 | return -EINVAL; |
951 | 951 | ||
952 | list_for_each_entry(sibling, &event->group_leader->sibling_list, | 952 | list_for_each_entry(sibling, &event->group_leader->sibling_list, |
953 | group_entry) | 953 | sibling_list) |
954 | if (sibling->pmu != event->pmu && | 954 | if (sibling->pmu != event->pmu && |
955 | !is_software_event(sibling)) | 955 | !is_software_event(sibling)) |
956 | return -EINVAL; | 956 | return -EINVAL; |